Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use signed stacks account in transaction #4923 #5152

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

pete-watters
Copy link
Contributor

@pete-watters pete-watters commented Apr 2, 2024

Try out Leather build 4427429Extension build, Test report, Storybook, Chromatic

This PR takes changes from #4923 and re-adds them avoiding conflicts.

It attempts to fix #4599

@pete-watters
Copy link
Contributor Author

I can't test this properly as when I try and buy something on Gamma its failing with:

Unexpected Application Error!
Unable to handle request, errorCode: 1398
Error: Unable to handle request, errorCode: 1398
    at useBreakOnNonCompliantEntity (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:210851:11)
    at PsbtSigner (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:182761:126)
    at renderWithHooks (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:280888:18)
    at updateFunctionComponent (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:284166:20)
    at beginWork (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:286179:16)
    at beginWork$1 (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:292004:14)
    at performUnitOfWork (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:291135:12)
    at workLoopSync (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:291044:5)
    at renderRootSync (chrome-extension://dbbkfepagfalpohacffnpaodaklhamif/index.js:291012:7)
    at recoverFromConcurrentError

@pete-watters pete-watters self-assigned this Apr 2, 2024
@pete-watters pete-watters force-pushed the fix/4599/use-correct-signed-account branch from aaf9c15 to 4427429 Compare April 3, 2024 07:19
@pete-watters
Copy link
Contributor Author

I'm merging this to help add this fix and close #4923.

When this is released though, we will no longer see the account at all in the header as when implementing global headers here we changed this header so that it only shows the logo and not the account:
Screenshot 2024-04-03 at 11 06 05

@pete-watters pete-watters added this pull request to the merge queue Apr 3, 2024
Merged via the queue into dev with commit 6dca269 Apr 3, 2024
28 of 29 checks passed
@pete-watters pete-watters deleted the fix/4599/use-correct-signed-account branch April 3, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix recognition of active account during Stacks contract execution
2 participants