fix: use signed stacks account in transaction #4923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious why the popup window appears so wide for you? What browser is this? |
|
@markmhendrickson it's Arc related. It remembers dimensions of the previous popup window Chrome: chrome.movArc: arc.mov |
kyranjamie
approved these changes
Feb 8, 2024
| @@ -5,7 +5,7 @@ import { Stack } from 'leather-styles/jsx'; | |||
|
|
|||
| import { AccountInfoCard } from './account-info-card'; | |||
|
|
|||
| type HomeLayoutProps = Record<'currentAccount' | 'children', React.ReactNode>; | |||
| type HomeLayoutProps = Record<'children', React.ReactNode>; | |||
There was a problem hiding this comment.
We have a HasChildren helper type we could replace this with
|
Let's get this merged |
pete-watters
added a commit
that referenced
this pull request
Apr 2, 2024
pete-watters
added a commit
that referenced
this pull request
Apr 3, 2024
|
I'm going to close this PR as I made the same changes in #5152 to avoid rebasing issues |
kyranjamie
pushed a commit
that referenced
this pull request
Apr 10, 2024
## [6.33.0](v6.32.1...v6.33.0) (2024-04-10) ### Features * add balances shimmer loader, closes [#5119](#5119) ([5c1c284](5c1c284)) * add src-20 token balances, closes [#3751](#3751) ([fb859b6](fb859b6)) * add stacks balance loader ([20418ab](20418ab)) * change query persister to chrome storage, closes [#5153](#5153) ([1cd2625](1cd2625)) * compliance checks ([6df0869](6df0869)) * stacks ft fiat values from alex-sdk, closes [#4653](#4653) ([0f7e44e](0f7e44e)) * support multiple recipients in rpc send transfer method, closes [#5174](#5174) ([a470a57](a470a57)) ### Bug Fixes * add border to onboarding form ([a6bda2d](a6bda2d)) * container when resized ([909fa0c](909fa0c)) * dependabot ([d927ec0](d927ec0)) * deprecate InfoCard to add border correctly ([b6864cd](b6864cd)) * fix routing issues with send flow ([f32151d](f32151d)) * only show messages on homepage ([8228c11](8228c11)) * refetch brc20 tokens on window focus ([a985e0f](a985e0f)) * shimmer styles import ([868ee71](868ee71)) * swap test ([85eb975](85eb975)) * swap toggle with new routing ([f179f3e](f179f3e)) * use signed stacks account in transaction [#4923](#4923) ([6dca269](6dca269)) ### Internal * Add wallet user survey, adjust styling ([3c242cf](3c242cf)) * disable compliance check ([b4b1d11](b4b1d11)) * fmt ([a937795](a937795)) * implement fix to limit amount of accounts rendered ([629ef97](629ef97)) * post-release merge back ([3c9c0f8](3c9c0f8)) * replace drawer dialog, containers and global header footers, onboarding, settings, ref [#4371](#4371) ([6262267](6262267)) * swaps routes, closes [#4317](#4317) ([70c51a1](70c51a1)) * ugprade dev packages ([4ed8326](4ed8326)) * update express, ref [#5130](#5130) ([264bf8d](264bf8d)) * update prettier package ([e75990f](e75990f)) * update stx avatar ([03fe093](03fe093)) * update undici, ref [#4956](#4956) ([8019e0d](8019e0d)) * update webpack + axios, ref [#5090](#5090) ([77803f5](77803f5)) * upgrade redux toolkit, redux ([2eb8090](2eb8090))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4599
Fix account name and avatar for transactions:
stacksSigning.mov
Note: noticed a weird bg color when picking an account for sign in