Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display SRC-20 token balances #3751

Closed
DeeList opened this issue May 25, 2023 · 7 comments · Fixed by #5156
Closed

Display SRC-20 token balances #3751

DeeList opened this issue May 25, 2023 · 7 comments · Fixed by #5156
Assignees
@fbwoolf
Labels
area:stamps enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Milestone
Redesign tokens UX

Comments

@DeeList
Copy link

DeeList commented May 25, 2023

Show SRC-20 token balances.

This would allow users SRC-20 token name and balance to display.

https://github.com/hydren-crypto/stampchain/blob/main/docs/src20.md
@DeeList DeeList mentioned this issue May 25, 2023
Open
@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p2 Critical functionality needed by few users, with no clear alternatives area:stamps labels May 28, 2023
@github-project-automation github-project-automation bot moved this from Triage to Enhancements backlog in Hiro Wallet (DEPRECATED) May 28, 2023
@markmhendrickson markmhendrickson moved this from Enhancements backlog to Triage in Hiro Wallet (DEPRECATED) May 28, 2023
@markmhendrickson markmhendrickson moved this from Triage to Assigned in Hiro Wallet (DEPRECATED) May 29, 2023
@markmhendrickson markmhendrickson moved this from Assigned to Triage in Hiro Wallet (DEPRECATED) Jun 12, 2023
@markmhendrickson markmhendrickson moved this from Triage to Enhancements backlog in Hiro Wallet (DEPRECATED) Jun 20, 2023
@markmhendrickson markmhendrickson moved this from Enhancements backlog to Triage in Hiro Wallet (DEPRECATED) Jun 26, 2023
@markmhendrickson markmhendrickson moved this from Triage to Assigned in Hiro Wallet (DEPRECATED) Jul 3, 2023
@markmhendrickson markmhendrickson moved this from Assigned to Triage in Hiro Wallet (DEPRECATED) Jul 3, 2023
@markmhendrickson markmhendrickson moved this from Triage to Assigned in Hiro Wallet (DEPRECATED) Jul 31, 2023
@fbwoolf fbwoolf moved this from Assigned to WIP in Hiro Wallet (DEPRECATED) Aug 3, 2023
@fbwoolf
Copy link
Contributor

fbwoolf commented Aug 3, 2023 •
edited
Loading

@markmhx I'm not seeing an api to get SRC-20 balances? The link here is just for the token data itself. For BRC-20, we query:

https://brc20api.bestinslot.xyz/v1/get_brc20_balance/${address} ...which appears to have been changed by @alter-eggo after my initial implementation using Unisat api.

EDIT: Not sure from what I see that this should be a priority? 🤔

@fbwoolf fbwoolf moved this from WIP to Assigned in Hiro Wallet (DEPRECATED) Aug 7, 2023
@markmhendrickson markmhendrickson moved this from Assigned to Triage in Hiro Wallet (DEPRECATED) Aug 9, 2023
@markmhendrickson
Copy link
Collaborator

Steve from Stamp Wallet has provided this endpoint, which is currently using in that wallet as well: https://pkizh327c7.execute-api.us-west-2.amazonaws.com/prod/src20/balanceByAddressV1?address=bc1qzat8m5ufnpwcng3j9ytd6a04k6uj7mc335m2v3

@alter-eggo alter-eggo self-assigned this Feb 26, 2024
@markmhendrickson
Copy link
Collaborator

The Stampchain API now supports SRC-20 balances.

@markmhendrickson markmhendrickson added this to the Redesign tokens UX milestone Mar 15, 2024
@fbwoolf
Copy link
Contributor

fbwoolf commented Mar 25, 2024 •
edited
Loading

@markmhendrickson made some progress here, but the api schema documented is not what is returned in the query ...so a bit hesitant to feel like this is stable? Who is our contact for Stamps at this point?

Schema documented: https://stampchain.io/docs#/default/get_api_v2_src20_balance__address_
My SRC-20 balances: https://stampchain.io/api/v2/src20/balance/bc1qqwl3fwlarjt4rhhvtyekzd9mxf6jhw5q8fw3v0

What I see is the schema in the Stamps query we already use that returns an array of src20 here:
https://stampchain.io/docs#/default/get_api_v2_balance__address_

Or, do you know something I'm missing? Also, I'm not seeing the Stamp I purchased in my collectibles, is that a known issue I'm forgetting I should address here? ...I'll look to see if there is an open issue. 👀 Nvm, I see it now.

@fbwoolf
Copy link
Contributor

fbwoolf commented Mar 26, 2024

@DeeList are you with stampchain.io to answer my question above ^?

@markmhendrickson
Copy link
Collaborator

I believe the API owner should be in the "Leather & Bitcoin Stamps" group in TG. I've inquired there and CC'ed you @fbwoolf

fbwoolf added a commit that referenced this issue Apr 2, 2024
@fbwoolf
feat: add src-20 token balances, closes #3751
1d4b60d
fbwoolf added a commit that referenced this issue Apr 4, 2024
@fbwoolf
feat: add src-20 token balances, closes #3751
087e017
fbwoolf added a commit that referenced this issue Apr 4, 2024
@fbwoolf
feat: add src-20 token balances, closes #3751
129c999
fbwoolf added a commit that referenced this issue Apr 4, 2024
@fbwoolf
feat: add src-20 token balances, closes #3751
9700f85
github-merge-queue bot pushed a commit that referenced this issue Apr 4, 2024
@fbwoolf
feat: add src-20 token balances, closes #3751
fb859b6
@fbwoolf
Copy link
Contributor

fbwoolf commented Apr 4, 2024

Was merged in #3751 ...I linked to the wrong issue so it didn't close automatically.

@fbwoolf fbwoolf closed this as completed Apr 4, 2024
@fbwoolf fbwoolf linked a pull request Apr 4, 2024 that will close this issue
feat: add src-20 token balances #5156
Merged
@pete-watters pete-watters mentioned this issue Apr 8, 2024
Merged
kyranjamie pushed a commit that referenced this issue Apr 10, 2024
@semantic-release-bot
chore(release): 6.33.0
7b78c24 
## [6.33.0](v6.32.1...v6.33.0) (2024-04-10)

### Features

* add balances shimmer loader, closes [#5119](#5119) ([5c1c284](5c1c284))
* add src-20 token balances, closes [#3751](#3751) ([fb859b6](fb859b6))
* add stacks balance loader ([20418ab](20418ab))
* change query persister to chrome storage, closes [#5153](#5153) ([1cd2625](1cd2625))
* compliance checks ([6df0869](6df0869))
* stacks ft fiat values from alex-sdk, closes [#4653](#4653) ([0f7e44e](0f7e44e))
* support multiple recipients in rpc send transfer method, closes [#5174](#5174) ([a470a57](a470a57))

### Bug Fixes

* add border to onboarding form ([a6bda2d](a6bda2d))
* container when resized ([909fa0c](909fa0c))
* dependabot ([d927ec0](d927ec0))
* deprecate InfoCard to add border correctly ([b6864cd](b6864cd))
* fix routing issues with send flow ([f32151d](f32151d))
* only show messages on homepage ([8228c11](8228c11))
* refetch brc20 tokens on window focus ([a985e0f](a985e0f))
* shimmer styles import ([868ee71](868ee71))
* swap test ([85eb975](85eb975))
* swap toggle with new routing ([f179f3e](f179f3e))
* use signed stacks account in transaction [#4923](#4923) ([6dca269](6dca269))

### Internal

* Add wallet user survey, adjust styling ([3c242cf](3c242cf))
* disable compliance check ([b4b1d11](b4b1d11))
* fmt ([a937795](a937795))
* implement fix to limit amount of accounts rendered ([629ef97](629ef97))
* post-release merge back ([3c9c0f8](3c9c0f8))
* replace drawer dialog, containers and global header footers, onboarding, settings, ref [#4371](#4371) ([6262267](6262267))
* swaps routes, closes [#4317](#4317) ([70c51a1](70c51a1))
* ugprade dev packages ([4ed8326](4ed8326))
* update express, ref [#5130](#5130) ([264bf8d](264bf8d))
* update prettier package ([e75990f](e75990f))
* update stx avatar ([03fe093](03fe093))
* update undici, ref [#4956](#4956) ([8019e0d](8019e0d))
* update webpack + axios, ref [#5090](#5090) ([77803f5](77803f5))
* upgrade redux toolkit, redux ([2eb8090](2eb8090))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbwoolf fbwoolf

Labels
area:stamps enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
Redesign tokens UX
Development

Successfully merging a pull request may close this issue.

feat: add src-20 token balances leather-io/extension
5 participants
@markmhendrickson @kyranjamie @fbwoolf @alter-eggo @DeeList