-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show USD values for Stacks FTs #4653
Comments
@alter-eggo @fbwoolf Might one of you want to take this using the ALEX SDK for Stacks FTs and another for BRC-20 ones (e.g. perhaps Best in Slot, UniSat or CoinMarketCap's API)? It seems like a possible quick win ahead of redesigning the tokens UX in general. Note that in addition to showing the USD values per token, we'd want to incorporate their values in the account total as well. |
Yep, sure, I can take it after my UI issues. |
@markmhendrickson is it ok just to handle what is returned by the alex-sdk for fiat prices?
|
Yep that works |
@fabric-8 there are so many tokens being airdropped into wallets that don't have a fiat conversion available, should I just not show anything for now if |
I think displaying 0$ is ok, people might otherwise wonder wether any given token might actually be worth something and start looking around. The more fundamental issue which we'll address is to not display spammy tokens in first place or give the user the option to hide those. I think we're planning to do that, @kyranjamie @markmhendrickson discussed this earlier this week btw: can we just do $0 without the decimals? Makes it a bit faster to parse / less noisy :) |
Let's just show blank? It's best not to give the impression that we know the value (or lack thereof) if we simply don't have the data |
Ah, is there a difference between an unknown value and 0? I was assuming that we or the service we're using "knows" that the fiat value is 0 |
There is a difference in that that alex-sdk only returns data for a hand full of tokens, the others have no market data. |
ok thanks for clarifying - Agree with Mark then 👍 |
## [6.33.0](v6.32.1...v6.33.0) (2024-04-10) ### Features * add balances shimmer loader, closes [#5119](#5119) ([5c1c284](5c1c284)) * add src-20 token balances, closes [#3751](#3751) ([fb859b6](fb859b6)) * add stacks balance loader ([20418ab](20418ab)) * change query persister to chrome storage, closes [#5153](#5153) ([1cd2625](1cd2625)) * compliance checks ([6df0869](6df0869)) * stacks ft fiat values from alex-sdk, closes [#4653](#4653) ([0f7e44e](0f7e44e)) * support multiple recipients in rpc send transfer method, closes [#5174](#5174) ([a470a57](a470a57)) ### Bug Fixes * add border to onboarding form ([a6bda2d](a6bda2d)) * container when resized ([909fa0c](909fa0c)) * dependabot ([d927ec0](d927ec0)) * deprecate InfoCard to add border correctly ([b6864cd](b6864cd)) * fix routing issues with send flow ([f32151d](f32151d)) * only show messages on homepage ([8228c11](8228c11)) * refetch brc20 tokens on window focus ([a985e0f](a985e0f)) * shimmer styles import ([868ee71](868ee71)) * swap test ([85eb975](85eb975)) * swap toggle with new routing ([f179f3e](f179f3e)) * use signed stacks account in transaction [#4923](#4923) ([6dca269](6dca269)) ### Internal * Add wallet user survey, adjust styling ([3c242cf](3c242cf)) * disable compliance check ([b4b1d11](b4b1d11)) * fmt ([a937795](a937795)) * implement fix to limit amount of accounts rendered ([629ef97](629ef97)) * post-release merge back ([3c9c0f8](3c9c0f8)) * replace drawer dialog, containers and global header footers, onboarding, settings, ref [#4371](#4371) ([6262267](6262267)) * swaps routes, closes [#4317](#4317) ([70c51a1](70c51a1)) * ugprade dev packages ([4ed8326](4ed8326)) * update express, ref [#5130](#5130) ([264bf8d](264bf8d)) * update prettier package ([e75990f](e75990f)) * update stx avatar ([03fe093](03fe093)) * update undici, ref [#4956](#4956) ([8019e0d](8019e0d)) * update webpack + axios, ref [#5090](#5090) ([77803f5](77803f5)) * upgrade redux toolkit, redux ([2eb8090](2eb8090))
No description provided.
The text was updated successfully, but these errors were encountered: