Update gdbinit-gep.py with [TAB] and [BTAB] for fzf list navigation #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebr0nli
approved these changes
May 5, 2024
There was a problem hiding this comment.
This is a nice change, thanks for the PR!
@sweetbbak But there seems have a small lint issue:
+ ruff check
gdbinit-gep.py:78:22: W291 [*] Trailing whitespace
Found 1 error.
[*] 1 fixable with the `--fix` option.
Would you mind running ./lint.sh -f and committing it again?
(Or perhaps it'd be simpler to just edit it directly without having to install the dependencies for lint.sh :p)
|
Thanks! I love the project. |
|
Merged. Thanks for the nice change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this was a nice change, it kind of goes in line with the feeling of tab completion where you can use tab and shift+tab to navigate up and down through fzf lists.