Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an ability to use preallocated memory instead of file #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erhoof
Copy link

@erhoof erhoof commented May 27, 2024

Speeds up execution on low-powered devices via USE_ALLOCATED_SPACE define

Also i added some c-style casts, to make possible compiling via C++ compiler

@paulmenzel
Copy link

Thank you for your contribution. Two minor comments. It’d be great if you added benchmark data to the commit message. Second, it’d be great if you used imperative mood in the commit message summary/title.

@Voidless7125
Copy link

You have a RAM leak. Here's the fix:

    if (!emu_memory)
    {
        fclose(f); // Fix
        return -1;
    }

I checked with Cppcheck. (And tested and confirmed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants