Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated numpy dtypes "int" and "float" #217

Closed
wants to merge 3 commits into from

Conversation

jaycedowell
Copy link
Collaborator

No description provided.

@jaycedowell
Copy link
Collaborator Author

jaycedowell commented Jul 21, 2023

It looks like this has sorta kinda already been merged in but with numpy.int64 replacing numpy.int and numpy.float64 replacing numpy.float. I think those are the correct sizes for native Python int's and float's so maybe this PR isn't needed? I guess the advantage of this approach is that integer allows both int32 and int64, and floating worth with float32 and float64.

@jaycedowell
Copy link
Collaborator Author

@dentalfloss1 @league Any opinions on this PR which would allow lower precision values to be stored in a "standard header"? I'm currently leaning towards keeping the current behavior in master and not merging this one.

@dentalfloss1
Copy link
Collaborator

I agree.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (becbf48) 65.39% compared to head (778c666) 65.39%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files          67       67           
  Lines        5840     5840           
=======================================
  Hits         3819     3819           
  Misses       2021     2021           
Files Changed Coverage Δ
python/bifrost/header_standard.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaycedowell
Copy link
Collaborator Author

Motion carries, closing.

@jaycedowell jaycedowell deleted the numpy_deprecated_dtypes branch August 22, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants