Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dep warning #219

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Fix dep warning #219

merged 3 commits into from
Aug 22, 2023

Conversation

dentalfloss1
Copy link
Collaborator

Deprecation warnings should be gone. Notable is the change from np.int8 to np.uint8 in the ci4 datatype. One test failed because I was testing against numpy 1.25 and one of our tutorial files still requires numba, which is incompatible with numpy 1.25

@jaycedowell
Copy link
Collaborator

I noticed that a few of the CI tests failed so I'm rerunning them.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (842e8f4) 65.39% compared to head (becbf48) 65.39%.

❗ Current head becbf48 differs from pull request most recent head 78b78f0. Consider uploading reports for the commit 78b78f0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files          67       67           
  Lines        5840     5840           
=======================================
  Hits         3819     3819           
  Misses       2021     2021           
Files Changed Coverage Δ
python/bifrost/DataType.py 66.89% <100.00%> (ø)
python/bifrost/block.py 89.51% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaycedowell jaycedowell merged commit 5611735 into master Aug 22, 2023
11 checks passed
@jaycedowell jaycedowell deleted the fix-dep-warning branch August 22, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants