Bring ibverb-support up-to-date with master #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Stokes I and coherence modes, which were in a previous PR that was too difficult to merge
The telescope -> integer ID scheme is insane, but I've added a few from https://github.com/SixByNine/sigproc/blob/28ba4f4539d41a8722c6ed194fa66e87bf4610fc/src/aliases.c#L52 and https://github.com/FRBs/sigpyproc3 and set MWA = 12
I recall we tackled this a few years ago, perhaps in the ill-fated dcp-merge PR.
I guess that "broken" else branch was being used. Can claim then that dtype is optional and keep None there.
Updates to detect.py, sigproc.py and quantize.py blocks
Probably makes no difference on Python 3.6 failing on MacOS. (Most likely the fix is just to drop 3.6.)
Python 3.6 is no longer supported on macos-latest build image, and 3.6 is EOL anyway. (So prefer to ditch 3.6 rather than pin macos to an earlier image.)
Mac builds with Python 3.6 are failing in Github Actions
Fix DeprecationWarning: invalid escape sequence \d
Lockfile will warn periodically if waiting more than 5s
Update telemetry to include the Python version
… to get around a recent change to how nvcc runs.
|
I did something. |
|
Looks like these failures are related to the firewall issues. Yet another thing that is on hold until we get those resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.