-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of transactions for #mark_collection_as_read #94
Reduce number of transactions for #mark_collection_as_read #94
Conversation
d29c431
to
747df0f
Compare
747df0f
to
b34110a
Compare
Thanks for your work, but this transaction seems to be needed for PostgreSQL. Please see here: |
@ledermann Yes, you are right. I should probably better read git history of changing files. What do you think, should I rework this or left for #95? |
Thanks @fatkodima, your commitment is is highly appreciated! Implementing a DB switch to use inner transactions for PostgreSQL only seems a good improvement to me. Regarding #95: I'd prefer to avoid adding a new gem dependency (upsert) into this little project. |
Ok, I will update this PR with db switch.
Yes, I'm not also a big fan of dependencies. Will appreciate, if you have suggestions of how that feature can be implemented in other ways. |
b34110a
to
2add795
Compare
@ledermann Updated this. |
Great work, thanks! |
Inner transactions are not necessary (if I'm not missing something obvious) and can be replaced as was done in this PR.
Fixes #80.