[1장_이지훈] Pull Request #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 아직 테스트 코드는 구현하지 않은 상태
- getter setter 중복 있던 버그 해결 - Bag 클래스에 has 값들 사용할 때 결정되게 custom getter 사용
- 초대권이 없는 경우 -> 금액 줄어들고, hasTicket true - 초대권이 있는 경우 -> 금액 보존되고, hasTicket true
- bag을 private으로 바꾸기 위해서 수정
- 응집도를 높이고 결합도를 낮추자 - 각 클래스가 최대한 능동적으로 동작하게 변경
- Bag 클래스의 생성자들이 variable이기 때문에 private 제어자로 조금이나마 안전하게 변경 - Bag 클래스도 자기 자신의 책임을 갖게 하기 위해서 Audience.buy() 함수 로직을 Bag.hold()로 이전
- TicketOffice가 능동적으로 행동할 수 있게 변경
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1
고민거리
-> 이것을 어떻게 해결할 수 있을지?