fix mkdirp path when processing a source directory #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running into an odd issue with `async-to-gen --out-dir out src` where the tool would try to write files to directories that don't exist. For example, my `src` directory looked like: ``` src\ src\index.js src\subfolder\ src\subfolder\index.js ``` After running the tool, the out directory looked like ``` out\ out\index.js out\src\ out\src\subfolder ``` and then it would panic when it tried to write to `out\subfolder\index.js`, because that directory didn't exist. FWIW I'm working on Windows, which might have different behavior for `path.join` or `path.dirname`. The above change fixed the issue for me, and I don't see any issues with taking the directory path straight from the output file path, but I can't test it really thoroughly right now.
|
Great catch! Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an odd issue with
async-to-gen --out-dir out srcwhere the tool would try to write files to directories that don't exist. For example, mysrcdirectory looked like:After running the tool, the out directory looked like
and then it would panic when it tried to write to
out\subfolder\index.js, because that directory didn't exist. FWIW I'm working on Windows, which might have different behavior forpath.joinorpath.dirname. The above change fixed the issue for me, and I don't see any issues with taking the directory path straight from the output file path, but I can't test it really thoroughly right now.