Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mjs modules #34

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Support mjs modules #34

merged 1 commit into from
Feb 15, 2018

Conversation

leebyron
Copy link
Owner

This reshapes the source files to make index.mjs the source of truth and inlines the flow definitions using flow comments (removing the need for a separate file).

A new babel based build step replaces the mjs exports with cjs exports to produce an index.js artifact (which is no longer checked in) for distribution.

@coveralls
Copy link

coveralls commented Feb 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 1624826 on mjs into d576f74 on master.

This reshapes the source files to make index.mjs the source of truth and inlines the flow definitions using flow comments (removing the need for a separate file).

A new babel based build step replaces the mjs exports with cjs exports to produce an index.js artifact (which is no longer checked in) for distribution.
@leebyron leebyron merged commit d77c3ee into master Feb 15, 2018
@leebyron leebyron deleted the mjs branch February 15, 2018 20:53
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants