Skip to content

Commit

Permalink
http2: fix session[kSession] undefined issue
Browse files Browse the repository at this point in the history
`finishSessionDestroy` already done session cleaning up.

Fix: nodejs#24546
  • Loading branch information
leeight committed Nov 22, 2018
1 parent 9d34a1e commit 8e5e01c
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
1 change: 1 addition & 0 deletions lib/internal/http2/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -1989,6 +1989,7 @@ class Http2Stream extends Duplex {
// attempt to gracefully close the session.
const state = this[kState];
if (this.headersSent &&
this[kSession] &&
this[kSession][kType] === NGHTTP2_SESSION_SERVER &&
!(state.flags & STREAM_FLAGS_HAS_TRAILERS) &&
!state.didRead &&
Expand Down
16 changes: 16 additions & 0 deletions test/parallel/test-http2-server-session-destroy.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const h2 = require('http2');

const server = h2.createServer();
server.listen(0, common.mustCall(() => {
h2.connect(`http://localhost:${server.address().port}`, (session) => {
session.request({ ':method': 'POST' }).end(common.mustCall(() => {
session.destroy();
server.close();
}));
});
}));

0 comments on commit 8e5e01c

Please sign in to comment.