Problem: config/client.toml keyring-backend not working correctly (fix …

…evmos#724) refactoring fix lint refactoring Apply suggestions from code review add changelog
leejw51crypto · Nov 12, 2021 · 61d9c37 · 61d9c37
1 parent a874c1e
commit 61d9c37
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 -->
 
 # Changelog
+* (app,cli)[\#725](https://github.com/tharsis/ethermint/pull/725) different keyring-backend in adding,list keys
 
 ## Unreleased
 

diff --git a/client/keys.go b/client/keys.go
@@ -93,14 +93,12 @@ func runAddCmd(cmd *cobra.Command, args []string) error {
 	dryRun, _ := cmd.Flags().GetBool(flags.FlagDryRun)
 	if dryRun {
 		kr, err = keyring.New(sdk.KeyringServiceName(), keyring.BackendMemory, clientCtx.KeyringDir, buf, hd.EthSecp256k1Option())
-	} else {
-		backend, _ := cmd.Flags().GetString(flags.FlagKeyringBackend)
-		kr, err = keyring.New(sdk.KeyringServiceName(), backend, clientCtx.KeyringDir, buf, hd.EthSecp256k1Option())
+		clientCtx = clientCtx.WithKeyring(kr)
 	}
 
 	if err != nil {
 		return err
 	}
 
-	return clientkeys.RunAddCmd(clientCtx.WithKeyring(kr), cmd, args, buf)
+	return clientkeys.RunAddCmd(clientCtx, cmd, args, buf)
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,6 +34,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ @@
     -->
     # Changelog
+    * (app,cli)[\#725](https://github.com/tharsis/ethermint/pull/725) different keyring-backend in adding,list keys
     ## Unreleased
@@ Expand Down @@