Skip to content

Commit

Permalink
fix: handle file close logic (evmos#679)
Browse files Browse the repository at this point in the history
* handle file close logic

* Update rpc/ethereum/namespaces/debug/utils.go

* update changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
  • Loading branch information
JayT106 and fedekunze authored Oct 19, 2021
1 parent 1076307 commit c644dd6
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (evm) [tharsis#660](https://github.com/tharsis/ethermint/pull/660) Fix `nil` pointer panic in `ApplyNativeMessage`.
* (evm, test) [tharsis#649](https://github.com/tharsis/ethermint/pull/649) Test DynamicFeeTx.

### Improvements

(rpc) [tharsis#679](https://github.com/tharsis/ethermint/pull/679) Fix file close handle.

## [v0.7.0] - 2021-10-07

### API Breaking
Expand Down
8 changes: 6 additions & 2 deletions rpc/ethereum/namespaces/debug/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ func writeProfile(name, file string, log log.Logger) error {
if err != nil {
return err
}
defer f.Close()

return p.WriteTo(f, 0)
if err := p.WriteTo(f, 0); err != nil {
f.Close()
return err
}

return f.Close()
}

0 comments on commit c644dd6

Please sign in to comment.