Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null arguments sent to non null parameters #205

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix null arguments sent to non null parameters #205

merged 1 commit into from
Aug 30, 2023

Conversation

@williamdes
Copy link
Author

Hi @leenooks
Could you let me know if this PR and the PHP 8 one are okay please ?

@leenooks
Copy link
Owner

leenooks commented Aug 7, 2023

I havent looked at anything related to 1.2 - my focus is on 2.0 (and other person projects) - but its good that the patches are here for others to find and try - thank you.

My quick look at 1.2 and PHP 8.x seemed that many things needed to be fixed - and, IIRC, the patches here didnt address them all. So I'm concentrating my effort on v2 to replace v1.

Thanks for keep 1.2 alive :)

@williamdes
Copy link
Author

I havent looked at anything related to 1.2 - my focus is on 2.0 (and other person projects) - but its good that the patches are here for others to find and try - thank you.

My quick look at 1.2 and PHP 8.x seemed that many things needed to be fixed - and, IIRC, the patches here didnt address them all. So I'm concentrating my effort on v2 to replace v1.

Thanks for keep 1.2 alive :)

I tested the interface for php 8.2 on Debian and as today my patches cover all the normal cases and even some edge cases. Could you merge my work so everyone can benefit from it?
I can continue to work on fixing more php 8 stuff

@leenooks leenooks merged commit e31d6c2 into leenooks:BRANCH-1.2 Aug 30, 2023
@williamdes williamdes deleted the fix-null-args-for-non-null-params branch August 30, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants