Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Pagination: changing items per page #425

Closed
pat-s opened this issue May 9, 2023 · 3 comments · Fixed by #461
Closed

FR: Pagination: changing items per page #425

pat-s opened this issue May 9, 2023 · 3 comments · Fixed by #461

Comments

@pat-s
Copy link
Contributor

pat-s commented May 9, 2023

Would be great if this would be configurable or if pagination could be turned off entirely. Makes it easier to search for workspaces as one does not need to find the matching page in the workspace overview.

Tags help already (and I like it!) but I think this could be a nice addition with maybe not too much effort?

Thanks for your work again! 🚀
@leg100
Copy link
Owner

leg100 commented May 9, 2023

Changing items per page is certainly doable. We'll keep this issue open until that's done.

As for turning it off entirely, that might take a lot more work. Instead I think adding a search box to the workspace listing page might be a better approach.

@pat-s
Copy link
Contributor Author

pat-s commented May 10, 2023

Ah sure, whatever is easier or more liked by you. In the longterm a search functionality is certainly a more professional solution but maybe not so trivial to implement.

@leg100 leg100 mentioned this issue Jun 1, 2023
Merged
leg100 added a commit that referenced this issue Jun 2, 2023
@leg100
feat: workspace search on UI (#461)
4f30539 
Fixes #425 

* Add search to workspaces page
* Increases page size from 10 items to 100 items.
* Changes behaviour of `name[search]` query when listing workspaces via
the API

For the last item, the behaviour up until now has been to set the search
term as the _prefix_. I think this was the old behaviour of TFC. But
both the documentation and anecdotal testing shows TFC treats it as full
substring search, so OTF now adopts this approach too.
@leg100
Copy link
Owner

leg100 commented Jun 2, 2023

Note: #461 adds search and sets the number of items per page to 100 rather than 10. I thought that was better than permitting the user to configure a specific number of items per page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: workspace search on UI leg100/otf
2 participants
@leg100 @pat-s