Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhooks: Ability to change hostname #668

Closed
arcdigital opened this issue Dec 13, 2023 · 1 comment
Closed

Webhooks: Ability to change hostname #668

arcdigital opened this issue Dec 13, 2023 · 1 comment

Comments

@arcdigital
Copy link
Contributor

We are trying to deploy OTF to our internal k8s cluster (it's not accessible via the internet). Since OTF requires webhooks for the VCS integration, we have configured a separate ingress that only allows access to the /webhooks path from specific IPs. Currently OTF doesn't provide a way to configure the hostname used for webhooks (it just uses the same hostname as the rest of the app). If we could configure this hostname that would be really helpful.
@arcdigital arcdigital changed the title Webhook: Ability to customize hostname Webhooks: Ability to change hostname Dec 13, 2023
leg100 added a commit that referenced this issue Dec 16, 2023
@arcdigital @leg100
feat: Add Webhook Hostname (#668) (#670)
f2dc7e9 
Co-authored-by: Anand Capur <anand.capur@corelight.com>
Co-authored-by: Louis Garman <louisgarman@gmail.com>
@github-actions github-actions bot mentioned this issue Dec 16, 2023
Merged
@leg100
Copy link
Owner

leg100 commented Dec 16, 2023

Fixed by #670

@leg100 leg100 closed this as completed Dec 16, 2023
leg100 pushed a commit that referenced this issue Dec 16, 2023
@github-actions
chore(master): release 0.2.4 (#674)
a2d4583 
🤖 I have created a release *beep* *boop*
---


## [0.2.4](v0.2.3...v0.2.4)
(2023-12-16)


### Features

* Add Webhook Hostname
([#668](#668))
([#670](#670))
([f2dc7e9](f2dc7e9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leg100 @arcdigital