Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Webhook Hostname (#668) #670

Merged
merged 3 commits into from
Dec 16, 2023
Merged

feat: Add Webhook Hostname (#668) #670

merged 3 commits into from
Dec 16, 2023

Conversation

arcdigital
Copy link
Contributor

No description provided.

leg100
leg100 reviewed Dec 15, 2023
View reviewed changes
internal/daemon/daemon.go Outdated Show resolved Hide resolved
leg100
leg100 reviewed Dec 15, 2023
View reviewed changes
internal/daemon/daemon.go Outdated Show resolved Hide resolved
@arcdigital arcdigital force-pushed the 668-add-webhook-hostname branch from 6983e96 to ec7158d Compare December 15, 2023 19:53
@arcdigital arcdigital force-pushed the 668-add-webhook-hostname branch from ec7158d to 0244378 Compare December 15, 2023 20:49
@leg100 leg100 changed the title Add Webhook Hostname (#668) feat: Add Webhook Hostname (#668) Dec 16, 2023
@leg100
Copy link
Owner

leg100 commented Dec 16, 2023

@arcdigital Looks good. I've made a few updates:

  • Added unit tests that test the behaviour you reported to me in Slack
  • Set the webhook hostname for Github Apps as well (they're managed separately from per-repo webhooks)
  • Changed the logging key from webhookHostname to webhook_hostname (keeps it consistent with other multi word logging keys).

@leg100 leg100 merged commit f2dc7e9 into leg100:master Dec 16, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Dec 16, 2023
Merged
@leg100 leg100 mentioned this pull request Dec 16, 2023
Closed
leg100 pushed a commit that referenced this pull request Dec 16, 2023
@github-actions
chore(master): release 0.2.4 (#674)
a2d4583 
🤖 I have created a release *beep* *boop*
---


## [0.2.4](v0.2.3...v0.2.4)
(2023-12-16)


### Features

* Add Webhook Hostname
([#668](#668))
([#670](#670))
([f2dc7e9](f2dc7e9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leg100 leg100 leg100 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcdigital @leg100