Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata to pubsub notifications #481

Merged
merged 4 commits into from
Jun 26, 2023

Conversation

leg100
Copy link
Owner

@leg100 leg100 commented Jun 26, 2023

No description provided.

Copy link
Contributor

@fsaintjacques fsaintjacques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fsaintjacques
Copy link
Contributor

I suspect that docs action shouldn't be skipped.

@leg100
Copy link
Owner Author

leg100 commented Jun 26, 2023

I suspect that docs action shouldn't be skipped.

That's ok, that action publishes the docs and is only run when a tag is pushed. (Having said that, there should probably be some sort of linting of docs on every PR...).

@leg100 leg100 merged commit 19597a8 into master Jun 26, 2023
@leg100 leg100 deleted the feat/add-metadata-to-pubsub-notifications branch December 16, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants