Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: chromium bug fixed #559

Merged
merged 3 commits into from
Aug 5, 2023
Merged

chore: chromium bug fixed #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
266669e
chore: chromium bug fixed
leg100 Aug 5, 2023
e807163
Update main_test.go
leg100 Aug 5, 2023
bf6fd5d
wip
leg100 Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ jobs:
run: make vet
- name: API tests
run: make go-tfe-tests
# chromium breaks browser-based tests:
# https://github.com/chromedp/chromedp/issues/1325#issuecomment-1606114185
- name: Remove chromium
run: |
sudo rm /usr/bin/chromium
sudo rm /usr/bin/chromium-browser
- name: Tests
env:
GOOGLE_CREDENTIALS: ${{ secrets.GOOGLE_CREDENTIALS }}
Expand Down
7 changes: 0 additions & 7 deletions internal/integration/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"crypto/rand"
"fmt"
"os"
"os/exec"
"path"
"path/filepath"
"testing"
Expand Down Expand Up @@ -44,12 +43,6 @@ func TestMain(m *testing.M) {
}

func doMain(m *testing.M) (int, error) {
for _, chromium := range []string{"chromium", "chromium-browser"} {
if _, err := exec.LookPath(chromium); err == nil {
return 0, fmt.Errorf("found %s executable in path; chromium has a bug that breaks the browser-based tests; see https://github.com/chromedp/chromedp/issues/1325", chromium)
}
}

// Start external services
if err := testcompose.Up(); err != nil {
return 0, fmt.Errorf("starting external services: %w", err)
Expand Down