Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS deb packages not building #55

Open
mikaelarguedas opened this issue Jan 21, 2018 · 1 comment
Open

ROS deb packages not building #55

mikaelarguedas opened this issue Jan 21, 2018 · 1 comment

Comments

@mikaelarguedas
Copy link

Hi @mbjelonic,

Cool package 👍

I saw this was released on the ROS buildfarm but never succeeded to build due to the missing darknet submodule.
This can be solved in various ways (from the nicest to the riskiest):

  1. release darknet as a standalone ros package, that allows to get rid of the submodule issue and also to remove the darknet package completely the day it gets packaged as an official deb
  2. Use CMake external project feature. This is known to work with bloom. An example can be found at: https://github.com/esteve/LMS1xx/blob/619ff1ff42124cc9628f9c8e244aad79b0c0763d/CMakeLists.txt#L10-L18
    con: This means downloading and compiling 3rd party code at build time
  3. Clone and init the submodule in CMake. Still unclear to me if this works well with bloom or not: support upstream git repositories with submodules ros-infrastructure/bloom#217
    con: This means downloading and compiling 3rd party code at build time
@mbjelonic
Copy link
Collaborator

mbjelonic commented Jan 22, 2018 •
edited
Loading

Hi @mikaelarguedas,
thanks for the detailed information. I am aware of this problem and I will look into this.
Best,
Marko

tfoote added a commit to ros/rosdistro that referenced this issue Jan 23, 2018
@tfoote
Clearing continuously failing kinetic builds
56a5990 
 * bag_tools: http://build.ros.org/view/Kbin_uX64/job/Kbin_uX64__bag_tools__ubuntu_xenial_amd64__binary/96/console srv/srv_tools#17
 * op3_direct_control_module ROBOTIS-GIT/ROBOTIS-OP3#24
 * darknet_ros leggedrobotics/darknet_ros#55
@tfoote tfoote mentioned this issue Jan 23, 2018
Merged
tfoote added a commit to ros/rosdistro that referenced this issue Jan 23, 2018
@tfoote
Clearing continuously failing kinetic builds (#16815)
59b6ea7 
* bag_tools: http://build.ros.org/view/Kbin_uX64/job/Kbin_uX64__bag_tools__ubuntu_xenial_amd64__binary/96/console srv/srv_tools#17
 * op3_direct_control_module ROBOTIS-GIT/ROBOTIS-OP3#24
 * darknet_ros leggedrobotics/darknet_ros#55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikaelarguedas @mbjelonic