Migrate to Rust 1.61.0 (+WSL fixes) #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R3DP1XL
force-pushed
the
wsl-rust-1.61-fixes
branch
from
d0d9d14 to
a57f0d3
Compare
|
Still some warnings related to clippy::use_self in code generated by
|
|
I have another PR that updates dependency maybe something that was already fixed? |
I don't think so unfortunately, I tried updating serde&strum to latest locally, but didn't remove warnings. |
|
Is it this: serde-rs/serde@2e38e2b |
No it's related to use_self, in code generated for enums |
R3DP1XL
force-pushed
the
wsl-rust-1.61-fixes
branch
from
17c7c06 to
efd837d
Compare
|
@R3DP1XL do we disable this lint for now ? or we wait for 1.62 ? |
I would go for a general disable, with a note that we re-enable for 1.62 |
R3DP1XL
force-pushed
the
wsl-rust-1.61-fixes
branch
from
29e2395 to
b28ffaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.