-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps and fix schema #42
Conversation
It appears that you have incorporated my changes from #41 into this one so I will close mine. @legokichi gentle ping :) |
I've also added running the tests using Playwright, and moved from Travis to Github Actions. |
}, | ||
"aliasify": { | ||
"aliases": { | ||
"ebml": "ebml/lib/ebml.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to point out that this is important for consumers of ts-ebml
too. The dependency ebml
3.0.0 has a browser
entry in its package.json that points at an IIFE bundle which is not what bundlers expect so it has to be aliased to ebml/lib/ebml.js
or ebml/lib/ebml.esm.js
Nice work @davedoesdev & @thatsmydoing |
@davedoesdev thank you so much for your hard work here! 🙏🏾 Given this fixes a pretty critical licensing issue, is there a timeline on merging? If you're under water, happy to take on just the updating of where we pull the spec in a separate PR. Lmk! |
@davedoesdev |
Includes fix for #40
All the commands in
package.json
now work, tests all pass and doc generation works.I've added the generated
doc
directory and the browserifieddist/EBML.js
file.