-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] Add standalone diagnostics to fix build #334
base: v1
Are you sure you want to change the base?
Conversation
Coverage Report
|
from homeassistant.const import ( | ||
CONF_API_KEY, | ||
CONF_PASSWORD, | ||
CONF_URL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question Is there a need to redact the URL? The URL is currently a part of the config entry's title/display name, so this should already be "public"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little worried about having the URL and the fact that there is no authentication in the same diagnostic message but I'll take another look at this and remove the URL for now
Is this PR still valid? |
#332