Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Add standalone diagnostics to fix build #334

Open
wants to merge 3 commits into
base: v1
Choose a base branch
from

Conversation

strawgate
Copy link
Collaborator

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
elasticsearch
   __init__.py112694%119, 153–154, 174–175, 269
   config_flow.py2222090%165, 198, 328, 365, 379, 438–439, 450–452, 466–467, 471, 510, 516, 556, 631, 640, 674–675
   const.py340100% 
   diagnostics.py70100% 
   entity_details.py330100% 
   errors.py28389%51, 60, 67
   es_doc_creator.py193199%322
   es_doc_publisher.py2683885%142–143, 182, 185, 188, 193, 210–211, 229–232, 236, 251–252, 268–269, 273, 298, 302, 396, 416, 458, 472, 483, 486, 514–515, 517–518, 520–521, 525–527, 546, 548, 554
   es_gateway.py1442086%94–95, 114, 133–135, 137, 139–140, 142–143, 146–148, 153–154, 158–160, 253
   es_index_manager.py1231091%74, 79, 242–243, 260–261, 266–267, 296–297
   es_integration.py35294%45–46
   es_privilege_check.py610100% 
   es_serializer.py10190%17
   es_version.py300100% 
   logger.py20100% 
   system_info.py25196%37
   utils.py40100% 
TOTAL133110292% 

Tests Skipped Failures Errors Time
223 0 💤 0 ❌ 0 🔥 11.548s ⏱️

from homeassistant.const import (
CONF_API_KEY,
CONF_PASSWORD,
CONF_URL,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question Is there a need to redact the URL? The URL is currently a part of the config entry's title/display name, so this should already be "public"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little worried about having the URL and the fact that there is no authentication in the same diagnostic message but I'll take another look at this and remove the URL for now

@legrego
Copy link
Owner

legrego commented Sep 19, 2024

Is this PR still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants