✅ (rc): Fix startChargingBehavior tests

leka · Mar 16, 2022 · 303ede8 · 303ede8
1 parent d2cc608
commit 303ede8
Show file tree

Hide file tree

Showing 2 changed files with 64 additions and 16 deletions.
diff --git a/libs/RobotKit/include/RobotController.h b/libs/RobotKit/include/RobotController.h
@@ -50,23 +50,26 @@ class RobotController : public interface::RobotController
 
 	auto isCharging() -> bool final { return _battery.isCharging(); };
 
+	void onStartChargingBehavior(uint8_t level)
+	{
+		_service_battery.setBatteryLevel(level);
+
+		if (level < 25) {
+			_video_kit.displayImage("/fs/images/battery_0.jpg");
+		} else if (level < 50) {
+			_video_kit.displayImage("/fs/images/battery_red.jpg");
+		} else if (level < 75) {
+			_video_kit.displayImage("/fs/images/battery_yellow_2.jpg");
+		} else if (level < 100) {
+			_video_kit.displayImage("/fs/images/battery_green_3.jpg");
+		} else {
+			_video_kit.displayImage("/fs/images/battery_green_4.jpg");
+		}
+	}
+
 	void startChargingBehavior() final
 	{
-		_battery_kit.onDataUpdated([this](uint8_t level) {
-			_service_battery.setBatteryLevel(level);
-
-			if (level < 25) {
-				_video_kit.displayImage("/fs/images/battery_0.jpg");
-			} else if (level < 50) {
-				_video_kit.displayImage("/fs/images/battery_red.jpg");
-			} else if (level < 75) {
-				_video_kit.displayImage("/fs/images/battery_yellow_2.jpg");
-			} else if (level < 100) {
-				_video_kit.displayImage("/fs/images/battery_green_3.jpg");
-			} else {
-				_video_kit.displayImage("/fs/images/battery_green_4.jpg");
-			}
-		});
+		_battery_kit.onDataUpdated([this](uint8_t level) { onStartChargingBehavior(level); });
 	}
 	void stopChargingBehavior() final
 	{

diff --git a/libs/RobotKit/tests/RobotController_test.cpp b/libs/RobotKit/tests/RobotController_test.cpp
@@ -52,7 +52,7 @@ class RobotControllerTest : public testing::Test
 		rc.initializeComponents();
 
 		EXPECT_CALL(battery, level).Times(1);
-		EXPECT_CALL(mbed_mock_gatt, write(_, _, _, _)).Times(1);
+		EXPECT_CALL(mbed_mock_gatt, write(_, _, _, _)).Times(AnyNumber());
 		EXPECT_CALL(sleep_timeout, onTimeout).WillOnce(GetCallback<interface::Timeout::callback_t>(&on_sleep_timeout));
 		EXPECT_CALL(battery, onChargeDidStart).WillOnce(GetCallback<mbed::Callback<void()>>(&on_charge_did_start));
 		EXPECT_CALL(battery, onChargeDidStop).WillOnce(GetCallback<mbed::Callback<void()>>(&on_charge_did_stop));
@@ -94,6 +94,51 @@ TEST_F(RobotControllerTest, initializeComponents)
 	rc.initializeComponents();
 }
 
+TEST_F(RobotControllerTest, onStartChargingBehaviorLevelBelow25)
+{
+	auto battery_level = 0;
+
+	rc.onStartChargingBehavior(battery_level);
+
+	// nohting expected
+}
+
+TEST_F(RobotControllerTest, onStartChargingBehaviorLevelAbove25Below50)
+{
+	auto battery_level = 42;
+
+	rc.onStartChargingBehavior(battery_level);
+
+	// nohting expected
+}
+
+TEST_F(RobotControllerTest, onStartChargingBehaviorLevelAbove50Below75)
+{
+	auto battery_level = 66;
+
+	rc.onStartChargingBehavior(battery_level);
+
+	// nohting expected
+}
+
+TEST_F(RobotControllerTest, onStartChargingBehaviorLevelAbove75Below100)
+{
+	auto battery_level = 90;
+
+	rc.onStartChargingBehavior(battery_level);
+
+	// nohting expected
+}
+
+TEST_F(RobotControllerTest, onStartChargingBehaviorLevelAt100)
+{
+	auto battery_level = 100;
+
+	rc.onStartChargingBehavior(battery_level);
+
+	// nohting expected
+}
+
 TEST_F(RobotControllerTest, stateSetupEventSetupComplete)
 {
 	ble::GapMock &mbed_mock_gap			= ble::gap_mock();