Skip to content

Commit

Permalink
🔀 Merge branch 'ladislas/bugfix/ci-sonarcloud-pull_request_target' in…
Browse files Browse the repository at this point in the history
…to develop

* ladislas/bugfix/ci-sonarcloud-pull_request_target:
  💄 (workflows): Display raw code size if no differences
  ⏪ (workflows): Revert running on pull_request_target
  • Loading branch information
ladislas committed Jan 20, 2022
2 parents 14b9d50 + 0938815 commit f82bf1d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
5 changes: 4 additions & 1 deletion .github/actions/compare_files/get_diffs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ target_name=$target
echo "$target not deleted nor new, running diff"

if ! diff_map_output=$(diff --unified=150 $BASE_DIR/$target_name-map.txt $HEAD_DIR/$target_name-map.txt); then
diff_size_output=$(diff --unified=150 $BASE_DIR/$target_name-code_size.txt $HEAD_DIR/$target_name-code_size.txt)

if ! diff_size_output=$(diff --unified=150 $BASE_DIR/$target_name-code_size.txt $HEAD_DIR/$target_name-code_size.txt); then
diff_size_output=$(cat $HEAD_DIR/$target_name-code_size.txt)
fi

echo $diff_map_output
echo $diff_size_output
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ci-code_analysis-compare_base_head.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ on:
pull_request:
types: [opened, synchronize, reopened]

pull_request_target:
types: [opened, synchronize, reopened]

jobs:
#
# Mark: - Job - build_base_ref
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ci-code_analysis-sonarcloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ on:
pull_request:
types: [opened, synchronize, reopened]

pull_request_target:
types: [opened, synchronize, reopened]

jobs:
run:
runs-on: ubuntu-latest
Expand Down

0 comments on commit f82bf1d

Please sign in to comment.