hugo/feature/Add SuperSimon activity #1014

HPezz · 2022-09-09T13:11:48Z

Validated on robot

github-actions · 2022-09-09T13:23:28Z

File comparision analysis report

🔖 Info

base: hugo/feature/Add-FlashNumberCounting-activity / c3540a1 + mbed-os-6.15.1+fixes + -std=c++20
head: hugo/feature/Add-SuperSimon-activity / ccca540 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	181884 (69%)	80260 (30%)	37456 (7%)
os	432308 (27%)	1132364 (72%)	85640 (16%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	430300 (20%) 432308 (20%)	📈 2008 (0%)	84960 (16%) 85640 (16%)	📈 680 (0%)
bootloader	✔️	✅	✅	181884 (8%)	ø	37456 (7%)	ø
spike_lk_audio	✔️	✅	✅	132380 (6%)	ø	20984 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	195476 (9%)	ø	54528 (10%)	ø
spike_lk_ble	✔️	✅	✅	233676 (11%)	ø	34712 (6%)	ø
spike_lk_bluetooth	✔️	✅	✅	92236 (4%)	ø	18064 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	152264 (7%)	ø	53064 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88352 (4%)	ø	20216 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	200020 (9%)	ø	57864 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	136100 (6%)	ø	20976 (4%)	ø
spike_lk_coreled	✔️	✅	✅	87916 (4%)	ø	20104 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84088 (4%)	ø	18744 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	143648 (6%)	ø	21304 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331036 (15%)	ø	34072 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	86712 (4%)	ø	18056 (3%)	ø
spike_lk_fs	✔️	✅	✅	171216 (8%)	ø	47968 (9%)	ø
spike_lk_lcd	✔️	✅	✅	169100 (8%)	ø	53288 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115708 (5%)	ø	21024 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84440 (4%)	ø	19248 (3%)	ø
spike_lk_motors	✔️	✅	✅	86008 (4%)	ø	18088 (3%)	ø
spike_lk_qdac	✔️	✅	✅	91508 (4%)	ø	18616 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	112188 (5%)	ø	21024 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84636 (4%)	ø	18024 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87056 (4%)	ø	19120 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	83944 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84696 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90336 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91608 (4%)	ø	18296 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	82176 (3%)	ø	18336 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82584 (3%)	ø	18072 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	145284 (6%)	ø	21904 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100328 (4%)	ø	19080 (3%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87940 (4%)	ø	19960 (3%)	ø
spike_lk_wifi	✔️	✅	✅	130640 (6%)	ø	21368 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84112 (4%)	ø	18920 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83424 (3%)	ø	18144 (3%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-22 09:39:56.769073059 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-09-22 09:39:57.201079098 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       616(+616) |     22(+22) |     220(+220) |
-| [lib]/ActivityKit.a        |   15708(+15708) |       0(+0) |         0(+0) |
+| [fill]                     |       610(+610) |     22(+22) |     220(+220) |
+| [lib]/ActivityKit.a        |   17324(+17324) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       750(+750) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1484(+1484) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   42180(+42180) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 172108(+172108) |   769(+769) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   96110(+96110) |   548(+548) | 29386(+29386) |
-| Subtotals                  | 389016(+389016) | 3944(+3944) | 80656(+80656) |
-Total Static RAM memory (data + bss): 84600(+84600) bytes
-Total Flash memory (text + data): 392960(+392960) bytes
+| main.cpp.obj               |   96484(+96484) |   548(+548) | 30058(+30058) |
+| Subtotals                  | 391000(+391000) | 3944(+3944) | 81328(+81328) |
+Total Static RAM memory (data + bss): 85272(+85272) bytes
+Total Flash memory (text + data): 394944(+394944) bytes

Flash used: 432308&nbsp;(20%) / total: 2097152
SRAM used: 85640&nbsp;(16%) / total: 524288

github-actions · 2022-09-09T13:23:28Z

File comparision analysis report

🔖 Info

base: hugo/feature/Add-FlashNumberCounting-activity / c3540a1 + mbed-os-6.15.1+fixes + -std=c++20
head: hugo/feature/Add-SuperSimon-activity / ccca540 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	169508 (64%)	92636 (35%)	30920 (5%)
os	394216 (25%)	1170456 (74%)	78712 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	392208 (18%) 394216 (18%)	📈 2008 (0%)	78032 (14%) 78712 (15%)	📈 680 (0%)
bootloader	✔️	✅	✅	169508 (8%)	ø	30920 (5%)	ø
spike_lk_audio	✔️	✅	✅	122324 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	186992 (8%)	ø	48112 (9%)	ø
spike_lk_ble	✔️	✅	✅	225792 (10%)	ø	28056 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	144632 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	189760 (9%)	ø	50936 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	124188 (5%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	128680 (6%)	ø	14384 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326968 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	171856 (8%)	ø	47880 (9%)	ø
spike_lk_lcd	✔️	✅	✅	159468 (7%)	ø	46616 (8%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78564 (3%)	ø	11816 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	80920 (3%)	ø	11520 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	58904 (2%)	ø	11480 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	123476 (5%)	ø	15296 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	82032 (3%)	ø	13288 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-22 09:39:42.650954270 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-09-22 09:39:43.042952186 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       638(+638) |     22(+22) |     199(+199) |
-| [lib]/ActivityKit.a        |   15708(+15708) |       0(+0) |         0(+0) |
+| [fill]                     |       620(+620) |     22(+22) |     199(+199) |
+| [lib]/ActivityKit.a        |   17324(+17324) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1292(+1292) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1854(+1854) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1308(+1308) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       750(+750) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1062(+1062) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1484(+1484) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       232(+232) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   43284(+43284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 170856(+170856) |   769(+769) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   58652(+58652) |   548(+548) | 22567(+22567) |
-| Subtotals                  | 351384(+351384) | 3944(+3944) | 73728(+73728) |
-Total Static RAM memory (data + bss): 77672(+77672) bytes
-Total Flash memory (text + data): 355328(+355328) bytes
+| main.cpp.obj               |   59038(+59038) |   548(+548) | 23239(+23239) |
+| Subtotals                  | 353368(+353368) | 3944(+3944) | 74400(+74400) |
+Total Static RAM memory (data + bss): 78344(+78344) bytes
+Total Flash memory (text + data): 357312(+357312) bytes

Flash used: 394216&nbsp;(18%) / total: 2097152
SRAM used: 78712&nbsp;(15%) / total: 524288

codecov · 2022-09-09T13:26:12Z

Codecov Report

Merging #1014 (ccca540) into develop (a2ea7e7) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head ccca540 differs from pull request most recent head 23f3098. Consider uploading reports for the commit 23f3098 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1014      +/-   ##
===========================================
- Coverage    96.08%   96.01%   -0.07%     
===========================================
  Files          133      131       -2     
  Lines         3138     3085      -53     
===========================================
- Hits          3015     2962      -53     
  Misses         123      123

Impacted Files	Coverage Δ
libs/RFIDKit/include/MagicCard.h	`100.00% <100.00%> (ø)`
libs/Utils/include/MathUtils.h	`100.00% <0.00%> (ø)`
libs/FileManagerKit/source/File.cpp	`100.00% <0.00%> (ø)`
libs/FileManagerKit/include/FileManagerKit.h	`100.00% <0.00%> (ø)`
libs/SerialNumberKit/include/SerialNumberKit.h	`100.00% <0.00%> (ø)`
libs/SerialNumberKit/source/SerialNumberKit.cpp	`100.00% <0.00%> (ø)`
...bs/SerialNumberKit/source/SerialNumberFormater.cpp
...ibs/SerialNumberKit/include/SerialNumberFormater.h

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ladislas

Quick review, but this one is bit complex, would like to discuss offline

ladislas · 2022-09-18T22:06:20Z

libs/ActivityKit/include/activities/SuperSimon.h

+
+// LCOV_EXCL_START
+
+#include <random>


if possible, move to .cpp

ladislas · 2022-09-18T22:07:38Z

libs/ActivityKit/include/activities/SuperSimon.h

+	std::array<Color, 2 *kNumberOfColors> _colors_table = {Color::blue,	  Color::blue,	 Color::green,	Color::green,
+														   Color::red,	  Color::red,	 Color::purple, Color::purple,
+														   Color::orange, Color::orange, Color::yellow, Color::yellow};
+	std::span<Color> _colors_span {_colors_table};


ladislas · 2022-09-18T22:08:05Z

libs/ActivityKit/include/activities/SuperSimon.h

+	ReinforcerKit &_reinforcerkit;
+	interface::LED &_led;
+
+	static constexpr uint8_t kNumberOfColors = 6;


Suggested change

static constexpr uint8_t kNumberOfColors = 6;

static constexpr uint8_t kNumberOfColors = 6 * 2;

ladislas · 2022-09-18T22:08:49Z

libs/ActivityKit/include/activities/SuperSimon.h

+	uint8_t _score		  = 0;
+	uint8_t _pos		  = 0;
+	uint8_t _index_number = 0;
+	uint8_t _score_to_win = 5;


Suggested change

uint8_t _score = 0;

uint8_t _pos = 0;

uint8_t _index_number = 0;

uint8_t _score_to_win = 5;

uint8_t _current_round = 0;

uint8_t _pos = 0;

uint8_t _index_number = 0;

uint8_t _number_of_rounds = 5;

what is _pos and _index_number?

position and index are usually the exact same thing

ladislas · 2022-09-18T22:15:13Z

libs/ActivityKit/source/activities/SuperSimon.cpp

+			return card == MagicCard::number_1 || card == MagicCard::number_2 || card == MagicCard::number_3 ||
+				   card == MagicCard::number_4 || card == MagicCard::number_5 || card == MagicCard::number_6 ||
+				   card == MagicCard::number_7 || card == MagicCard::number_8 || card == MagicCard::number_9 ||
+				   card == MagicCard::number_10;


You have the numbers_table, why not use std::find?

https://stackoverflow.com/a/64341713/2205264

sonarcloud · 2022-09-22T09:42:04Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
2 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

HPezz changed the base branch from develop to hugo/feature/Add-FlashNumberCounting-activity September 9, 2022 13:12

HPezz force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from b2d56e2 to 18663aa Compare September 9, 2022 16:49

HPezz force-pushed the hugo/feature/Add-SuperSimon-activity branch from 3633449 to dda1778 Compare September 9, 2022 16:54

HPezz requested a review from ladislas September 9, 2022 16:59

HPezz self-assigned this Sep 9, 2022

HPezz requested a review from YannLocatelli September 9, 2022 16:59

HPezz added 01 - type: story Clear roadmap to implement a new feature, refactor code, etc. 01 - type: task Something to do labels Sep 9, 2022

HPezz added this to the Next Release milestone Sep 9, 2022

HPezz force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from 18663aa to 2b3ced2 Compare September 15, 2022 12:38

HPezz force-pushed the hugo/feature/Add-SuperSimon-activity branch from dda1778 to 831e956 Compare September 15, 2022 15:16

ladislas requested changes Sep 18, 2022

View reviewed changes

HPezz force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from 2b3ced2 to 3aecfd2 Compare September 20, 2022 09:25

HPezz force-pushed the hugo/feature/Add-SuperSimon-activity branch from 831e956 to 685ff14 Compare September 20, 2022 10:06

HPezz force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from 3aecfd2 to 8d97d1b Compare September 20, 2022 14:42

HPezz force-pushed the hugo/feature/Add-SuperSimon-activity branch from 685ff14 to 7b788a4 Compare September 20, 2022 14:47

HPezz force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from 8d97d1b to b832f46 Compare September 22, 2022 07:57

HPezz force-pushed the hugo/feature/Add-SuperSimon-activity branch from 7b788a4 to b88df8a Compare September 22, 2022 07:57

HPezz force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from b832f46 to c3540a1 Compare September 22, 2022 09:16

HPezz force-pushed the hugo/feature/Add-SuperSimon-activity branch from b88df8a to ccca540 Compare September 22, 2022 09:17

HPezz force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from c3540a1 to dc28ebc Compare September 22, 2022 10:02

ladislas force-pushed the hugo/feature/Add-FlashNumberCounting-activity branch from dc28ebc to 29a9e5a Compare September 22, 2022 10:05

Base automatically changed from hugo/feature/Add-FlashNumberCounting-activity to develop September 22, 2022 10:05

HPezz force-pushed the hugo/feature/Add-SuperSimon-activity branch from ccca540 to bd777e8 Compare September 22, 2022 10:07

HPezz added 2 commits September 22, 2022 12:13

✨ (ActivityKit): Add new activity - SuperSimon

20eab69

✨ (os): Add activity - SuperSimon

23f3098

ladislas force-pushed the hugo/feature/Add-SuperSimon-activity branch from bd777e8 to 23f3098 Compare September 22, 2022 10:14

ladislas merged commit ca75f11 into develop Sep 22, 2022

ladislas deleted the hugo/feature/Add-SuperSimon-activity branch September 22, 2022 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hugo/feature/Add SuperSimon activity #1014

hugo/feature/Add SuperSimon activity #1014

HPezz commented Sep 9, 2022 •

edited

Loading

github-actions bot commented Sep 9, 2022 •

edited

Loading

github-actions bot commented Sep 9, 2022 •

edited

Loading

codecov bot commented Sep 9, 2022 •

edited

Loading

ladislas left a comment

ladislas Sep 18, 2022

ladislas Sep 18, 2022

ladislas Sep 18, 2022

ladislas Sep 18, 2022

ladislas Sep 18, 2022

ladislas Sep 18, 2022

sonarcloud bot commented Sep 22, 2022

	static constexpr uint8_t kNumberOfColors = 6;
	static constexpr uint8_t kNumberOfColors = 6 * 2;

hugo/feature/Add SuperSimon activity #1014

hugo/feature/Add SuperSimon activity #1014

Conversation

HPezz commented Sep 9, 2022 • edited Loading

github-actions bot commented Sep 9, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Sep 9, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

codecov bot commented Sep 9, 2022 • edited Loading

Codecov Report

ladislas left a comment

Choose a reason for hiding this comment

ladislas Sep 18, 2022

Choose a reason for hiding this comment

ladislas Sep 18, 2022

Choose a reason for hiding this comment

ladislas Sep 18, 2022

Choose a reason for hiding this comment

ladislas Sep 18, 2022

Choose a reason for hiding this comment

ladislas Sep 18, 2022

Choose a reason for hiding this comment

ladislas Sep 18, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Sep 22, 2022

HPezz commented Sep 9, 2022 •

edited

Loading

github-actions bot commented Sep 9, 2022 •

edited

Loading

github-actions bot commented Sep 9, 2022 •

edited

Loading

codecov bot commented Sep 9, 2022 •

edited

Loading