Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 (bugfix): Fix python crash #1040

Merged
merged 1 commit into from
Sep 22, 2022
Merged

👷 (bugfix): Fix python crash #1040

merged 1 commit into from
Sep 22, 2022

Conversation

ladislas
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169636 (64%) 92508 (35%) 30920 (5%)
os 407192 (26%) 1157480 (73%) 79080 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 407192 (19%) ø 79080 (15%) ø
bootloader ✔️ ✅ ✅ 169636 (8%) ø 30920 (5%) ø
spike_lk_audio ✔️ ✅ ✅ 125076 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 189752 (9%) ø 48120 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 228544 (10%) ø 28056 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 192520 (9%) ø 50944 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 126956 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139016 (6%) ø 14416 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 327112 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 174616 (8%) ø 47888 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 162236 (7%) ø 46616 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78564 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 80920 (3%) ø 11520 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 114244 (5%) ø 14056 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 126236 (6%) ø 15304 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 82032 (3%) ø 13288 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182012 (69%) 80132 (30%) 37456 (7%)
os 445284 (28%) 1119388 (71%) 86008 (16%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 445284 (21%) ø 86008 (16%) ø
bootloader ✔️ ✅ ✅ 182012 (8%) ø 37456 (7%) ø
spike_lk_audio ✔️ ✅ ✅ 135068 (6%) ø 20984 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198252 (9%) ø 54536 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 236428 (11%) ø 34712 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92236 (4%) ø 18064 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152264 (7%) ø 53064 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88352 (4%) ø 20216 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 202716 (9%) ø 57872 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 138868 (6%) ø 20976 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 87916 (4%) ø 20104 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84088 (4%) ø 18744 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 153984 (7%) ø 21336 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331180 (15%) ø 34072 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86712 (4%) ø 18056 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 173976 (8%) ø 47976 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 171852 (8%) ø 53288 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115708 (5%) ø 21024 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84440 (4%) ø 19248 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86008 (4%) ø 18088 (3%) ø
spike_lk_qdac ✔️ ✅ ✅ 91508 (4%) ø 18616 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112188 (5%) ø 21024 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84636 (4%) ø 18024 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87056 (4%) ø 19120 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 83944 (4%) ø 18056 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84696 (4%) ø 18056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90336 (4%) ø 18032 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91608 (4%) ø 18296 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 136188 (6%) ø 20896 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82584 (3%) ø 18072 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 148044 (7%) ø 21912 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100328 (4%) ø 19080 (3%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87940 (4%) ø 19960 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130640 (6%) ø 21368 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84112 (4%) ø 18920 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83424 (3%) ø 18144 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@ladislas
👷 (setup): Remove actions/setup-python
655c564 
it was causing CI to crash, see:

actions/setup-python#442

With ubuntu-22.04 the action is not needed anymore as the default Python
version is 3.10.4
@ladislas ladislas self-assigned this Sep 22, 2022
@ladislas ladislas added the 01 - type: task Something to do label Sep 22, 2022
@ladislas ladislas added this to the Next Release milestone Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022 •
edited
Loading

Codecov Report

Merging #1040 (253ee4c) into develop (a2ea7e7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 253ee4c differs from pull request most recent head 655c564. Consider uploading reports for the commit 655c564 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1040   +/-   ##
========================================
  Coverage    96.08%   96.08%           
========================================
  Files          133      133           
  Lines         3138     3138           
========================================
  Hits          3015     3015           
  Misses         123      123
Impacted Files Coverage Δ
libs/RFIDKit/include/MagicCard.h 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ladislas ladislas changed the title 👷 (bugfix): Bump actions/setup-python to v4 + specify python v3.10 👷 (bugfix): Fix python crash Sep 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ladislas ladislas merged commit e0418ae into develop Sep 22, 2022
@ladislas ladislas deleted the ladislas/bugfix/ci-python-bug branch September 22, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli approved these changes

@HPezz HPezz Awaiting requested review from HPezz

Assignees

@ladislas ladislas

Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislas @YannLocatelli