-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ladislas+mmyster/feature/functional tests #1079
Conversation
6b881d1
to
8b2039b
Compare
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1079 +/- ##
========================================
Coverage 96.05% 96.05%
========================================
Files 133 133
Lines 3191 3191
========================================
Hits 3065 3065
Misses 126 126 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I made a review on original PR: #1020 (review) + a PR for CMakeLists simplification #1080 |
b0d1e6b
to
eea278c
Compare
5183147
to
a2a3957
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Verified on the robot
A little optional suggestion about CMakeLists of tests' content readability
- avoid the need for each test to add the test_main.cpp source file - creates a `TARGET` compile definition used to output the target name when running tests
The function takes care of all the boiler plate code needed to register a new functional test. This allows developer to add them faster and more easily.
a2a3957
to
799dc5d
Compare
Kudos, SonarCloud Quality Gate passed! |
replacement of #1020