-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ - deep sleep - hal & logkit #1102
Merged
ladislas
merged 5 commits into
develop
from
ladislas/feature/deep-sleep-logkit-compatibility
Nov 17, 2022
Merged
⚡ - deep sleep - hal & logkit #1102
ladislas
merged 5 commits into
develop
from
ladislas/feature/deep-sleep-logkit-compatibility
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladislas
force-pushed
the
ladislas/feature/deep-sleep-logkit-compatibility
branch
from
November 3, 2022 14:08
a3163f6
to
5410f44
Compare
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1102 +/- ##
========================================
Coverage 96.03% 96.03%
========================================
Files 138 138
Lines 3251 3256 +5
========================================
+ Hits 3122 3127 +5
Misses 129 129
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ladislas
force-pushed
the
ladislas/feature/deep-sleep-logkit-compatibility
branch
from
November 6, 2022 14:25
5410f44
to
34091a1
Compare
ladislas
changed the title
🔧 (mbed): Set default stdio baudrate to 115200
⚡ - deep sleep - hal & logkit
Nov 6, 2022
ladislas
force-pushed
the
ladislas/feature/deep-sleep-logkit-compatibility
branch
from
November 6, 2022 14:33
34091a1
to
50f11a0
Compare
ladislas
force-pushed
the
ladislas/feature/deep-sleep-logkit-compatibility
branch
2 times, most recently
from
November 7, 2022 11:58
56a1813
to
5c8dff2
Compare
ladislas
force-pushed
the
ladislas/feature/deep-sleep-logkit-compatibility
branch
3 times, most recently
from
November 17, 2022 10:36
9cd8933
to
eaedb0d
Compare
YannLocatelli
approved these changes
Nov 17, 2022
HPezz
approved these changes
Nov 17, 2022
ladislas
force-pushed
the
ladislas/feature/deep-sleep-logkit-compatibility
branch
from
November 17, 2022 12:44
eaedb0d
to
d2b0426
Compare
Not passing without LogKit modifications
SerialBuffer, by default, holds a lock on deep sleep preventing the system from deep sleeping to wait for incoming data, thus preventing the system from saving power when needed. In our case, nothing is ever sent to the robot through UART, so input can be safely disabled. This has the effect to allow deep sleep when using LogKit. If at some point we would like to send data through UART, it can be enabled back on when needed. See link for more information: https://os.mbed.com/docs/mbed-os/v6.15/apis/power-management-sleep.html
ladislas
force-pushed
the
ladislas/feature/deep-sleep-logkit-compatibility
branch
from
November 17, 2022 22:56
0e4867f
to
8799580
Compare
ladislas
deleted the
ladislas/feature/deep-sleep-logkit-compatibility
branch
November 17, 2022 22:57
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for background, see #1101
topics: