Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas/feature/rfidkit fix refactor #1126

Merged
merged 4 commits into from
Nov 17, 2022
Merged

ladislas/feature/rfidkit fix refactor #1126

merged 4 commits into from
Nov 17, 2022

Conversation

ladislas
Copy link
Member

  • ♻️ (CoreRFIDReader): Replace for loops w/ std::copy
  • 🚨 (RFIDKit): Fix warnings
  • ♻️ (RFIDKit): Refactor struct Command to be fully constexpr + return std::span
  • 🩹 (RFIDKit): Add missing inline qualifiers

@ladislas ladislas requested a review from HPezz November 17, 2022 11:50
@ladislas ladislas self-assigned this Nov 17, 2022
@ladislas ladislas added the 01 - type: task Something to do label Nov 17, 2022
@ladislas ladislas added this to the Future Release milestone Nov 17, 2022
@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182028 (69%) 80116 (30%) 37520 (7%)
os 451780 (28%) 1112892 (71%) 86728 (16%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 451828 (21%)
451780 (21%)		 📉
-48 (0%)		 86728 (16%) ø
bootloader ✔️ ✅ ✅ 182028 (8%) ø 37520 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 396192 (18%) ø 27152 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 366688 (17%) ø 27104 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 368240 (17%) ø 27104 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 385928 (18%) ø 27400 (5%) ø
functional_ut_imu ✔️ ✅ ✅ 381324 (18%) ø 27120 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 371832 (17%) ø 27120 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 373144 (17%) ø 27120 (5%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 94048 (4%) ø 18472 (3%) ø
spike_lk_audio ✔️ ✅ ✅ 135196 (6%) ø 21048 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198380 (9%) ø 54600 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 236780 (11%) ø 34920 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92364 (4%) ø 18128 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152392 (7%) ø 53128 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88480 (4%) ø 20280 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 202844 (9%) ø 57936 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 138932 (6%) ø 21040 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88044 (4%) ø 20168 (3%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 92884 (4%) ø 18736 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84152 (4%) ø 18808 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 154048 (7%) ø 21400 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331308 (15%) ø 34136 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86776 (4%) ø 18120 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 173976 (8%) ø 47976 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 171916 (8%) ø 53352 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115772 (5%) ø 21088 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84776 (4%) ø 19312 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86072 (4%) ø 18152 (3%) ø
spike_lk_qdac ✔️ ✅ ✅ 91572 (4%) ø 18680 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112316 (5%) ø 21088 (4%) ø
spike_lk_rfid ✔️ ❌ ❌ 84764 (4%)
84080 (4%)		 📉
-684 (0%)		 18088 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87184 (4%) ø 19184 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84072 (4%) ø 18120 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84824 (4%) ø 18120 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90400 (4%) ø 18096 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91672 (4%) ø 18360 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 136316 (6%) ø 20960 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82712 (3%) ø 18136 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 148044 (7%) ø 21968 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100456 (4%) ø 19144 (3%) ø
spike_lk_watchdog_isr ✔️ ❌ ❌ 88068 (4%)
87320 (4%)		 📉
-748 (0%)		 20024 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130832 (6%) ø 21432 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84176 (4%) ø 18984 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83488 (3%) ø 18208 (3%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-11-17 23:41:27.665312700 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-11-17 23:41:28.021319021 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       632(+632) |     18(+18) |     233(+233) |
+| [fill]                     |       620(+620) |     18(+18) |     233(+233) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1794(+1794) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       638(+638) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
-| [lib]/RFIDKit.a            |     1074(+1074) |       0(+0) |         8(+8) |
+| [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1484(+1484) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 174476(+174476) |   773(+773) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
 | main.cpp.obj               | 102964(+102964) |   548(+548) | 31133(+31133) |
-| Subtotals                  | 409188(+409188) | 3944(+3944) | 82416(+82416) |
+| Subtotals                  | 409124(+409124) | 3944(+3944) | 82416(+82416) |
 Total Static RAM memory (data + bss): 86360(+86360) bytes
-Total Flash memory (text + data): 413132(+413132) bytes
+Total Flash memory (text + data): 413068(+413068) bytes
 
Flash used: 451780 (21%) / total: 2097152
SRAM used: 86728 (16%) / total: 524288
spike_lk_rfid (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_rfid-map.txt	2022-11-17 23:41:42.182379314 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_rfid-map.txt	2022-11-17 23:41:42.346383679 +0000
@@ -1,21 +1,21 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     122(+122) |       8(+8) |       28(+28) |
+| [fill]                     |     166(+166) |       8(+8) |       28(+28) |
 | [lib]/CoreBufferedSerial.a |     108(+108) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     702(+702) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     670(+670) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/RFIDKit.a            |   1066(+1066) |       0(+0) |         8(+8) |
+| [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/c.a                  | 25048(+25048) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 31650(+31650) |   444(+444) |   8226(+8226) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a             |   5864(+5864) |       8(+8) |       44(+44) |
+| [lib]/stdc++.a             |   5424(+5424) |       8(+8) |       44(+44) |
 | main.cpp.obj               |   2736(+2736) |       0(+0) |   6472(+6472) |
-| Subtotals                  | 75220(+75220) | 2936(+2936) | 14864(+14864) |
+| Subtotals                  | 74772(+74772) | 2936(+2936) | 14864(+14864) |
 Total Static RAM memory (data + bss): 17800(+17800) bytes
-Total Flash memory (text + data): 78156(+78156) bytes
+Total Flash memory (text + data): 77708(+77708) bytes
 
Flash used: 84080 (4%) / total: 2097152
SRAM used: 18088 (3%) / total: 524288
spike_lk_watchdog_isr (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_watchdog_isr-map.txt	2022-11-17 23:41:46.014481315 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_watchdog_isr-map.txt	2022-11-17 23:41:46.178485680 +0000
@@ -1,21 +1,21 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     144(+144) |       8(+8) |       62(+62) |
+| [fill]                     |     124(+124) |       8(+8) |       62(+62) |
 | [lib]/CoreBufferedSerial.a |       62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     624(+624) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     592(+592) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/RFIDKit.a            |   1066(+1066) |       0(+0) |         8(+8) |
+| [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/c.a                  | 25048(+25048) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 32840(+32840) |   444(+444) |   8242(+8242) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a             |   5864(+5864) |       8(+8) |       44(+44) |
+| [lib]/stdc++.a             |   5424(+5424) |       8(+8) |       44(+44) |
 | main.cpp.obj               |   4592(+4592) |       0(+0) |   8358(+8358) |
-| Subtotals                  | 78164(+78164) | 2936(+2936) | 16800(+16800) |
+| Subtotals                  | 77652(+77652) | 2936(+2936) | 16800(+16800) |
 Total Static RAM memory (data + bss): 19736(+19736) bytes
-Total Flash memory (text + data): 81100(+81100) bytes
+Total Flash memory (text + data): 80588(+80588) bytes
 
Flash used: 87320 (4%) / total: 2097152
SRAM used: 20024 (3%) / total: 524288

@github-actions
Copy link

github-actions bot commented Nov 17, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169508 (64%) 92636 (35%) 30920 (5%)
os 410728 (26%) 1153944 (73%) 79608 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 410792 (19%)
410728 (19%)		 📉
-64 (0%)		 79608 (15%) ø
bootloader ✔️ ✅ ✅ 169508 (8%) ø 30920 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 384496 (18%) ø 20424 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 353936 (16%) ø 20376 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 355456 (16%) ø 20376 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 373280 (17%) ø 20664 (3%) ø
functional_ut_imu ✔️ ✅ ✅ 369644 (17%) ø 20392 (3%) ø
functional_ut_io_expander ✔️ ✅ ✅ 360200 (17%) ø 20392 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 361448 (17%) ø 20392 (3%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 71184 (3%) ø 11808 (2%) ø
spike_lk_audio ✔️ ✅ ✅ 125076 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 189752 (9%) ø 48120 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 228768 (10%) ø 28200 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144696 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65776 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 192520 (9%) ø 50944 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 126956 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 80228 (3%) ø 12256 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139016 (6%) ø 14416 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 327112 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 174616 (8%) ø 47888 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 162236 (7%) ø 46616 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63288 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78628 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ❌ ❌ 80920 (3%)
78884 (3%)		 📉
-2036 (-2%)		 11520 (2%)
11504 (2%)		 📉
-16 (0%)
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 114244 (5%) ø 14056 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 126092 (6%) ø 15296 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ❌ ❌ 82032 (3%)
80060 (3%)		 📉
-1972 (-2%)		 13288 (2%)
13272 (2%)		 📉
-16 (0%)
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-11-17 23:41:47.845169592 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-11-17 23:41:48.201174475 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       664(+664) |     18(+18) |     212(+212) |
+| [fill]                     |       652(+652) |     18(+18) |     212(+212) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1794(+1794) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       638(+638) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
-| [lib]/RFIDKit.a            |     1074(+1074) |       0(+0) |         8(+8) |
+| [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1484(+1484) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 173224(+173224) |   773(+773) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
 | main.cpp.obj               |   62552(+62552) |   548(+548) | 24122(+24122) |
-| Subtotals                  | 368612(+368612) | 3944(+3944) | 75296(+75296) |
+| Subtotals                  | 368548(+368548) | 3944(+3944) | 75296(+75296) |
 Total Static RAM memory (data + bss): 79240(+79240) bytes
-Total Flash memory (text + data): 372556(+372556) bytes
+Total Flash memory (text + data): 372492(+372492) bytes
 
Flash used: 410728 (19%) / total: 2097152
SRAM used: 79608 (15%) / total: 524288
spike_lk_rfid (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_rfid-map.txt	2022-11-17 23:42:01.865357823 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_rfid-map.txt	2022-11-17 23:42:02.025359996 +0000
@@ -1,19 +1,19 @@
 | Module                     |         .text |       .data |        .bss |
 |----------------------------|---------------|-------------|-------------|
-| [fill]                     |     156(+156) |       8(+8) |     20(+20) |
+| [fill]                     |     128(+128) |       8(+8) |     20(+20) |
 | [lib]/CoreBufferedSerial.a |     108(+108) |       0(+0) |       0(+0) |
 | [lib]/CoreEventQueue.a     |     126(+126) |       0(+0) |       0(+0) |
-| [lib]/CoreRFIDReader.a     |     720(+720) |       0(+0) |       0(+0) |
+| [lib]/CoreRFIDReader.a     |     688(+688) |       0(+0) |       0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |       0(+0) |
-| [lib]/RFIDKit.a            |   1066(+1066) |       0(+0) |       8(+8) |
+| [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |       8(+8) |
 | [lib]/c.a                  | 26128(+26128) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a                |   7084(+7084) |       0(+0) |       0(+0) |
 | [lib]/mbed-os-static.a     | 31142(+31142) |   444(+444) | 8138(+8138) |
 | [lib]/misc                 |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |       0(+0) |
-| [lib]/stdc++.a             |   5444(+5444) |       8(+8) |     44(+44) |
+| [lib]/stdc++.a             |   4116(+4116) |       8(+8) |     28(+28) |
 | main.cpp.obj               |     356(+356) |       0(+0) |       0(+0) |
-| Subtotals                  | 72644(+72644) | 2936(+2936) | 8296(+8296) |
-Total Static RAM memory (data + bss): 11232(+11232) bytes
-Total Flash memory (text + data): 75580(+75580) bytes
+| Subtotals                  | 71236(+71236) | 2936(+2936) | 8280(+8280) |
+Total Static RAM memory (data + bss): 11216(+11216) bytes
+Total Flash memory (text + data): 74172(+74172) bytes
 
Flash used: 78884 (3%) / total: 2097152
SRAM used: 11504 (2%) / total: 524288
spike_lk_watchdog_isr (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_watchdog_isr-map.txt	2022-11-17 23:42:05.441406390 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_watchdog_isr-map.txt	2022-11-17 23:42:05.601408563 +0000
@@ -1,20 +1,20 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     122(+122) |       8(+8) |       38(+38) |
+| [fill]                     |     158(+158) |       8(+8) |       38(+38) |
 | [lib]/CoreBufferedSerial.a |       62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |     126(+126) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     624(+624) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     592(+592) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/RFIDKit.a            |   1066(+1066) |       0(+0) |         8(+8) |
+| [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/c.a                  | 26128(+26128) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 31536(+31536) |   444(+444) |   8154(+8154) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a             |   5444(+5444) |       8(+8) |       44(+44) |
+| [lib]/stdc++.a             |   4116(+4116) |       8(+8) |       28(+28) |
 | main.cpp.obj               |   1218(+1218) |       0(+0) |   1734(+1734) |
-| Subtotals                  | 73732(+73732) | 2936(+2936) | 10064(+10064) |
-Total Static RAM memory (data + bss): 13000(+13000) bytes
-Total Flash memory (text + data): 76668(+76668) bytes
+| Subtotals                  | 72388(+72388) | 2936(+2936) | 10048(+10048) |
+Total Static RAM memory (data + bss): 12984(+12984) bytes
+Total Flash memory (text + data): 75324(+75324) bytes
 
Flash used: 80060 (3%) / total: 2097152
SRAM used: 13272 (2%) / total: 524288

@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #1126 (d5f0948) into develop (9e04f87) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d5f0948 differs from pull request most recent head b81290f. Consider uploading reports for the commit b81290f to get more accurate results

@@             Coverage Diff             @@
##           develop    #1126      +/-   ##
===========================================
- Coverage    96.03%   96.02%   -0.02%     
===========================================
  Files          138      138              
  Lines         3256     3243      -13     
===========================================
- Hits          3127     3114      -13     
  Misses         129      129
Impacted Files Coverage Δ
...ers/CoreRFIDReader/source/CoreRFIDReaderCR95HF.cpp 100.00% <100.00%> (ø)
libs/RFIDKit/include/ISO14443A.h 100.00% <100.00%> (ø)
libs/LogKit/include/LogKit.h 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ladislas ladislas force-pushed the ladislas/feature/rfidkit-fix-refactor branch from d5f0948 to b81290f Compare November 17, 2022 23:28
@ladislas ladislas merged commit 2456fc7 into develop Nov 17, 2022
@ladislas ladislas deleted the ladislas/feature/rfidkit-fix-refactor branch November 17, 2022 23:37
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HPezz HPezz HPezz approved these changes

Assignees

@ladislas ladislas

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislas @HPezz