✨ (ble): Add setFileExchangeState characteristic #1130

YannLocatelli · 2022-11-17T18:59:48Z

Need

🚚 (ble): Rename service FileReception to FileExchange #1129

Related issues & PR

codecov · 2022-11-17T19:17:39Z

Codecov Report

Merging #1130 (8c384e1) into develop (c6b7c0b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8c384e1 differs from pull request most recent head 5669b27. Consider uploading reports for the commit 5669b27 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1130      +/-   ##
===========================================
+ Coverage    96.00%   96.02%   +0.01%     
===========================================
  Files          138      138              
  Lines         3254     3267      +13     
===========================================
+ Hits          3124     3137      +13     
  Misses         130      130

Impacted Files	Coverage Δ
libs/BLEKit/include/BLEServiceFileExchange.h	`100.00% <100.00%> (ø)`
libs/VideoKit/source/VideoKit.cpp	`75.00% <0.00%> (-0.37%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2022-11-17T19:20:38Z

File comparision analysis report

🔖 Info

base: develop / c6b7c0b + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
head: yann/feature/ble-add-set-file-exchange-state / 5669b27 + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	169508 (64%)	92636 (35%)	30920 (5%)
os	411112 (26%)	1153560 (73%)	79744 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	410984 (19%) 411112 (19%)	📈 128 (0%)	79624 (15%) 79744 (15%)	📈 120 (0%)
bootloader	✔️	✅	✅	169508 (8%)	ø	30920 (5%)	ø
functional_ut_boost_ut	✔️	✅	✅	394076 (18%)	ø	20456 (3%)	ø
functional_ut_core_imu	✔️	✅	✅	377068 (17%)	ø	20432 (3%)	ø
functional_ut_deep_sleep_log_kit	✔️	✅	✅	352696 (16%)	ø	20408 (3%)	ø
functional_ut_deep_sleep_mbed_hal	✔️	✅	✅	354216 (16%)	ø	20408 (3%)	ø
functional_ut_file_manager	✔️	✅	✅	374536 (17%)	ø	20696 (3%)	ø
functional_ut_io_expander	✔️	✅	✅	359232 (17%)	ø	20424 (3%)	ø
functional_ut_qdac	✔️	✅	✅	360400 (17%)	ø	20424 (3%)	ø
spike_lk_accel_gyro	✔️	✅	✅	71184 (3%)	ø	11808 (2%)	ø
spike_lk_audio	✔️	✅	✅	125076 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	189944 (9%)	ø	48136 (9%)	ø
spike_lk_ble	✔️	❌	❌	228768 (10%) 228960 (10%)	📈 192 (0%)	28200 (5%) 28320 (5%)	📈 120 (0%)
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	144696 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65776 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	192776 (9%)	ø	50960 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	126956 (6%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_core_touch_sensor	✔️	✅	✅	80228 (3%)	ø	12256 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74800 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	139016 (6%)	ø	14416 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	327112 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	174872 (8%)	ø	47904 (9%)	ø
spike_lk_lcd	✔️	✅	✅	162492 (7%)	ø	46632 (8%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63288 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78628 (3%)	ø	11816 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	78884 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	114308 (5%)	ø	14056 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	126092 (6%)	ø	15296 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	80060 (3%)	ø	13272 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	58032 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-11-25 11:52:31.194762256 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-11-25 11:52:31.550766181 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       618(+618) |     18(+18) |     212(+212) |
+| [fill]                     |       634(+634) |     18(+18) |     212(+212) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       638(+638) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1544(+1544) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       596(+596) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       938(+938) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 173224(+173224) |   773(+773) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   62564(+62564) |   548(+548) | 24138(+24138) |
-| Subtotals                  | 368804(+368804) | 3944(+3944) | 75312(+75312) |
-Total Static RAM memory (data + bss): 79256(+79256) bytes
-Total Flash memory (text + data): 372748(+372748) bytes
+| main.cpp.obj               |   62676(+62676) |   548(+548) | 24258(+24258) |
+| Subtotals                  | 368932(+368932) | 3944(+3944) | 75432(+75432) |
+Total Static RAM memory (data + bss): 79376(+79376) bytes
+Total Flash memory (text + data): 372876(+372876) bytes

Flash used: 411112&nbsp;(19%) / total: 2097152
SRAM used: 79744&nbsp;(15%) / total: 524288

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-11-25 11:52:37.674833770 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-11-25 11:52:37.914836429 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       392(+392) |     15(+15) |       82(+82) |
+| [fill]                  |       378(+378) |     15(+15) |       86(+86) |
 | [lib]/BLEKit.a          |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       154(+154) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   42076(+42076) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 141468(+141468) |   709(+709) | 19323(+19323) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9520(+9520) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     4278(+4278) |     92(+92) |   4746(+4746) |
-| Subtotals               | 208004(+208004) | 3408(+3408) | 24480(+24480) |
-Total Static RAM memory (data + bss): 27888(+27888) bytes
-Total Flash memory (text + data): 211412(+211412) bytes
+| main.cpp.obj            |     4484(+4484) |     92(+92) |   4862(+4862) |
+| Subtotals               | 208196(+208196) | 3408(+3408) | 24600(+24600) |
+Total Static RAM memory (data + bss): 28008(+28008) bytes
+Total Flash memory (text + data): 211604(+211604) bytes

Flash used: 228960&nbsp;(10%) / total: 2097152
SRAM used: 28320&nbsp;(5%) / total: 524288

github-actions · 2022-11-17T19:21:20Z

File comparision analysis report

🔖 Info

base: develop / c6b7c0b + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
head: yann/feature/ble-add-set-file-exchange-state / 5669b27 + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	182028 (69%)	80116 (30%)	41616 (7%)
os	452164 (28%)	1112508 (71%)	90960 (17%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	452100 (21%) 452164 (21%)	📈 64 (0%)	90840 (17%) 90960 (17%)	📈 120 (0%)
bootloader	✔️	✅	✅	182028 (8%)	ø	41616 (7%)	ø
functional_ut_boost_ut	✔️	✅	✅	408872 (19%)	ø	30096 (5%)	ø
functional_ut_core_imu	✔️	✅	✅	388848 (18%)	ø	30072 (5%)	ø
functional_ut_deep_sleep_log_kit	✔️	✅	✅	365284 (17%)	ø	30976 (5%)	ø
functional_ut_deep_sleep_mbed_hal	✔️	✅	✅	366488 (17%)	ø	30560 (5%)	ø
functional_ut_file_manager	✔️	✅	✅	386080 (18%)	ø	30344 (5%)	ø
functional_ut_io_expander	✔️	✅	✅	370556 (17%)	ø	30064 (5%)	ø
functional_ut_qdac	✔️	✅	✅	371716 (17%)	ø	30064 (5%)	ø
spike_lk_accel_gyro	✔️	✅	✅	94048 (4%)	ø	22568 (4%)	ø
spike_lk_audio	✔️	✅	✅	135196 (6%)	ø	25144 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	198572 (9%)	ø	58712 (11%)	ø
spike_lk_ble	✔️	❌	❌	236780 (11%) 237196 (11%)	📈 416 (0%)	39016 (7%) 39264 (7%)	📈 248 (0%)
spike_lk_bluetooth	✔️	✅	✅	92364 (4%)	ø	22224 (4%)	ø
spike_lk_cg_animations	✔️	✅	✅	152392 (7%)	ø	57224 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88480 (4%)	ø	24376 (4%)	ø
spike_lk_command_kit	✔️	✅	✅	203036 (9%)	ø	62048 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	138932 (6%)	ø	25136 (4%)	ø
spike_lk_coreled	✔️	✅	✅	88044 (4%)	ø	24264 (4%)	ø
spike_lk_core_touch_sensor	✔️	✅	✅	92884 (4%)	ø	22832 (4%)	ø
spike_lk_event_queue	✔️	✅	✅	84152 (4%)	ø	22904 (4%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	154048 (7%)	ø	25496 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331308 (15%)	ø	38232 (7%)	ø
spike_lk_flash_memory	✔️	✅	✅	86776 (4%)	ø	22216 (4%)	ø
spike_lk_fs	✔️	✅	✅	174168 (8%)	ø	47992 (9%)	ø
spike_lk_lcd	✔️	✅	✅	172332 (8%)	ø	57464 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115772 (5%)	ø	25184 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84776 (4%)	ø	23408 (4%)	ø
spike_lk_motors	✔️	✅	✅	86072 (4%)	ø	22248 (4%)	ø
spike_lk_qdac	✔️	✅	✅	91572 (4%)	ø	22776 (4%)	ø
spike_lk_reinforcer	✔️	✅	✅	112316 (5%)	ø	25184 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84080 (4%)	ø	22184 (4%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87184 (4%)	ø	23280 (4%)	ø
spike_lk_sensors_light	✔️	✅	✅	84072 (4%)	ø	22216 (4%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84824 (4%)	ø	22216 (4%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90400 (4%)	ø	22192 (4%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91672 (4%)	ø	22456 (4%)	ø
spike_lk_serial_number	✔️	✅	✅	136316 (6%)	ø	25056 (4%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82712 (3%)	ø	22232 (4%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	148044 (7%)	ø	26064 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100456 (4%)	ø	23240 (4%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87320 (4%)	ø	24120 (4%)	ø
spike_lk_wifi	✔️	✅	✅	130832 (6%)	ø	25528 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84176 (4%)	ø	23080 (4%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83488 (3%)	ø	22304 (4%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-11-25 11:52:28.205036498 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-11-25 11:52:28.549034149 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       664(+664) |     18(+18) |     233(+233) |
+| [fill]                     |       616(+616) |     18(+18) |     233(+233) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       638(+638) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1544(+1544) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       596(+596) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       924(+924) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 174476(+174476) |   773(+773) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
-| main.cpp.obj               | 102976(+102976) |   548(+548) | 35245(+35245) |
-| Subtotals                  | 409444(+409444) | 3944(+3944) | 86528(+86528) |
-Total Static RAM memory (data + bss): 90472(+90472) bytes
-Total Flash memory (text + data): 413388(+413388) bytes
+| main.cpp.obj               | 103088(+103088) |   548(+548) | 35365(+35365) |
+| Subtotals                  | 409508(+409508) | 3944(+3944) | 86648(+86648) |
+Total Static RAM memory (data + bss): 90592(+90592) bytes
+Total Flash memory (text + data): 413452(+413452) bytes

Flash used: 452164&nbsp;(21%) / total: 2097152
SRAM used: 90960&nbsp;(17%) / total: 524288

spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-11-25 11:52:34.732992302 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-11-25 11:52:34.976990731 +0000
@@ -1,19 +1,19 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       434(+434) |     15(+15) |       78(+78) |
+| [fill]                  |       434(+434) |     15(+15) |       82(+82) |
 | [lib]/BLEKit.a          |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       122(+122) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   40860(+40860) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 145464(+145464) |   709(+709) | 19447(+19447) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9940(+9940) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     7124(+7124) |     92(+92) | 15442(+15442) |
-| Subtotals               | 214484(+214484) | 3408(+3408) | 35296(+35296) |
-Total Static RAM memory (data + bss): 38704(+38704) bytes
-Total Flash memory (text + data): 217892(+217892) bytes
+| main.cpp.obj            |     7508(+7508) |     92(+92) | 15686(+15686) |
+| Subtotals               | 214868(+214868) | 3408(+3408) | 35544(+35544) |
+Total Static RAM memory (data + bss): 38952(+38952) bytes
+Total Flash memory (text + data): 218276(+218276) bytes

Flash used: 237196&nbsp;(11%) / total: 2097152
SRAM used: 39264&nbsp;(7%) / total: 524288

ladislas

LGTM 👍

+ petite proposition dans le log info

spikes/lk_ble/main.cpp

ladislas

LGTM 👍

HPezz

LGTM

sonarcloud · 2022-11-25T11:50:26Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

YannLocatelli added the 01 - type: task Something to do label Nov 17, 2022

YannLocatelli added this to the Future Release milestone Nov 17, 2022

YannLocatelli requested review from ladislas and HPezz November 17, 2022 18:59

YannLocatelli self-assigned this Nov 17, 2022

This was referenced Nov 17, 2022

✨ (rc): Add FileExchange state and actions #1131

Merged

🚸 (update): Update from FileExchange state #1132

Merged

✨ (rc): Add FileExchange state #1067

Closed

YannLocatelli force-pushed the yann/feature/ble-add-set-file-exchange-state branch from aff96c1 to 1aa9487 Compare November 17, 2022 19:13

YannLocatelli force-pushed the yann/feature/rename-file-reception-to-file-exchange branch from 2541af8 to 74a64c8 Compare November 17, 2022 19:14

YannLocatelli marked this pull request as draft November 17, 2022 19:18

YannLocatelli marked this pull request as ready for review November 17, 2022 19:19

YannLocatelli closed this Nov 17, 2022

YannLocatelli reopened this Nov 17, 2022

YannLocatelli force-pushed the yann/feature/rename-file-reception-to-file-exchange branch from 74a64c8 to 1545967 Compare November 18, 2022 10:25

YannLocatelli force-pushed the yann/feature/ble-add-set-file-exchange-state branch from 1aa9487 to 396788d Compare November 18, 2022 10:28

ladislas approved these changes Nov 18, 2022

View reviewed changes

spikes/lk_ble/main.cpp Outdated Show resolved Hide resolved

HPezz approved these changes Nov 21, 2022

View reviewed changes

YannLocatelli mentioned this pull request Nov 23, 2022

Robot State Machine - Add file reception state #1055

Closed

3 tasks

ladislas force-pushed the yann/feature/rename-file-reception-to-file-exchange branch from 1545967 to a1b36e8 Compare November 23, 2022 16:07

Base automatically changed from yann/feature/rename-file-reception-to-file-exchange to develop November 23, 2022 19:00

YannLocatelli force-pushed the yann/feature/ble-add-set-file-exchange-state branch from 396788d to 8c384e1 Compare November 24, 2022 14:49

ladislas approved these changes Nov 25, 2022

View reviewed changes

HPezz approved these changes Nov 25, 2022

View reviewed changes

✨ (ble): Add setFileExchangeState characteristic

5669b27

YannLocatelli force-pushed the yann/feature/ble-add-set-file-exchange-state branch from 8c384e1 to 5669b27 Compare November 25, 2022 11:39

ladislas merged commit 2872246 into develop Nov 25, 2022

ladislas deleted the yann/feature/ble-add-set-file-exchange-state branch November 25, 2022 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ (ble): Add setFileExchangeState characteristic #1130

✨ (ble): Add setFileExchangeState characteristic #1130

YannLocatelli commented Nov 17, 2022 •

edited

Loading

codecov bot commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading

ladislas left a comment •

edited

Loading

ladislas left a comment

HPezz left a comment

sonarcloud bot commented Nov 25, 2022

✨ (ble): Add setFileExchangeState characteristic #1130

✨ (ble): Add setFileExchangeState characteristic #1130

Conversation

YannLocatelli commented Nov 17, 2022 • edited Loading

Need

Related issues & PR

codecov bot commented Nov 17, 2022 • edited Loading

Codecov Report

github-actions bot commented Nov 17, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Nov 17, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

ladislas left a comment • edited Loading

Choose a reason for hiding this comment

ladislas left a comment

Choose a reason for hiding this comment

HPezz left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 25, 2022

YannLocatelli commented Nov 17, 2022 •

edited

Loading

codecov bot commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading

github-actions bot commented Nov 17, 2022 •

edited

Loading

ladislas left a comment •

edited

Loading