Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 (clang-tidy): Fix Inside a lambda, '__FUNCTION__' expands to the name of the function call operator #1141

Merged
merged 1 commit into from
Nov 18, 2022
Merged

🚨 (clang-tidy): Fix Inside a lambda, '__FUNCTION__' expands to the name of the function call operator #1141

merged 1 commit into from
Nov 18, 2022

Conversation

ladislas
Copy link
Member

  • remove no lint next lines for cppcoreguidelines-macro-usage

Variadic macro 'log_xx' used; consider using a 'constexpr' variadic template function

@ladislas
🚨 (clang-tidy): Fix Inside a lambda, '__FUNCTION__' expands to the na…
b99f015 
…me of the function call operator

+ remove no lint next lines for cppcoreguidelines-macro-usage

Variadic macro 'log_xx' used; consider using a 'constexpr' variadic template function
@ladislas ladislas self-assigned this Nov 18, 2022
@ladislas ladislas added the 01 - type: task Something to do label Nov 18, 2022
@ladislas ladislas added this to the Future Release milestone Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1141 (b99f015) into develop (b36ecad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1141   +/-   ##
========================================
  Coverage    96.00%   96.00%           
========================================
  Files          138      138           
  Lines         3253     3253           
========================================
  Hits          3123     3123           
  Misses         130      130
Impacted Files Coverage Δ
libs/LogKit/include/LogKit.h 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182028 (69%) 80116 (30%) 37520 (7%)
os 452036 (28%) 1112636 (71%) 86744 (16%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 452036 (21%) ø 86744 (16%) ø
bootloader ✔️ ✅ ✅ 182028 (8%) ø 37520 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 409000 (19%) ø 27152 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 365092 (17%) ø 27104 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 366772 (17%) ø 27104 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 384524 (18%) ø 27400 (5%) ø
functional_ut_imu ✔️ ✅ ✅ 380964 (18%) ø 27120 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 370940 (17%) ø 27120 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 372108 (17%) ø 27120 (5%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 94048 (4%) ø 18472 (3%) ø
spike_lk_audio ✔️ ✅ ✅ 135196 (6%) ø 21048 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198508 (9%) ø 54616 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 236780 (11%) ø 34920 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92364 (4%) ø 18128 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152392 (7%) ø 53128 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88480 (4%) ø 20280 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 203036 (9%) ø 57952 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 138932 (6%) ø 21040 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88044 (4%) ø 20168 (3%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 92884 (4%) ø 18736 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84152 (4%) ø 18808 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 154048 (7%) ø 21400 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331308 (15%) ø 34136 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86776 (4%) ø 18120 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 174168 (8%) ø 47992 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 172268 (8%) ø 53368 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115772 (5%) ø 21088 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84776 (4%) ø 19312 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86072 (4%) ø 18152 (3%) ø
spike_lk_qdac ✔️ ✅ ✅ 91572 (4%) ø 18680 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112316 (5%) ø 21088 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84080 (4%) ø 18088 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87184 (4%) ø 19184 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84072 (4%) ø 18120 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84824 (4%) ø 18120 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90400 (4%) ø 18096 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91672 (4%) ø 18360 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 136316 (6%) ø 20960 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82712 (3%) ø 18136 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 148044 (7%) ø 21968 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100456 (4%) ø 19144 (3%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87320 (4%) ø 20024 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130832 (6%) ø 21432 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84176 (4%) ø 18984 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83488 (3%) ø 18208 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169508 (64%) 92636 (35%) 30920 (5%)
os 410984 (26%) 1153688 (73%) 79624 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 410984 (19%) ø 79624 (15%) ø
bootloader ✔️ ✅ ✅ 169508 (8%) ø 30920 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 393052 (18%) ø 20424 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 352040 (16%) ø 20376 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 353624 (16%) ø 20376 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 371748 (17%) ø 20664 (3%) ø
functional_ut_imu ✔️ ✅ ✅ 368472 (17%) ø 20392 (3%) ø
functional_ut_io_expander ✔️ ✅ ✅ 358368 (17%) ø 20392 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 359552 (17%) ø 20392 (3%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 71184 (3%) ø 11808 (2%) ø
spike_lk_audio ✔️ ✅ ✅ 125076 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 189944 (9%) ø 48136 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 228768 (10%) ø 28200 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144696 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65776 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 192712 (9%) ø 50960 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 126956 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 80228 (3%) ø 12256 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139016 (6%) ø 14416 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 327112 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 174808 (8%) ø 47904 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 162428 (7%) ø 46632 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63288 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78628 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 78884 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 114308 (5%) ø 14056 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 126092 (6%) ø 15296 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 80060 (3%) ø 13272 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ladislas ladislas merged commit 3914acf into develop Nov 18, 2022
@ladislas ladislas deleted the ladislas/feature/logkit-fix-macro-lambda-filename-warning branch November 18, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ladislas ladislas

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.
1 participant
@ladislas