⚡ (power): CoreMotor - suspend/resume pwm when needed to allow deep sleep #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1167 +/- ##
========================================
Coverage 95.97% 95.98%
========================================
Files 138 138
Lines 3308 3311 +3
========================================
+ Hits 3175 3178 +3
Misses 133 133
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
ladislas
force-pushed
the
ladislas/feature/deep-sleep-core-pwm
branch
2 times, most recently
from
828e9cf
to
fe49526
Compare
ladislas
force-pushed
the
ladislas/feature/deep-sleep-core-motor
branch
from
0d323ec
to
d03a3de
Compare
ladislas
force-pushed
the
ladislas/feature/deep-sleep-core-pwm
branch
from
fe49526
to
249ddb4
Compare
ladislas
force-pushed
the
ladislas/feature/deep-sleep-core-motor
branch
from
d03a3de
to
dfdea0a
Compare
ladislas
force-pushed
the
ladislas/feature/deep-sleep-core-pwm
branch
4 times, most recently
from
2cce29d
to
2b3289a
Compare
Base automatically changed from
ladislas/feature/deep-sleep-core-pwm
to
develop
November 28, 2022 11:22
ladislas
force-pushed
the
ladislas/feature/deep-sleep-core-motor
branch
from
dfdea0a
to
e7822a7
Compare
CorePWm::suspend() should be called when instantiating CoreMotor
YannLocatelli
approved these changes
Nov 29, 2022
| }; | ||
| }; | ||
|
|
||
| scenario("motor spin, stop, spin, stop") = [] { |
There was a problem hiding this comment.
It happens 3 times so,
Suggested change
| scenario("motor spin, stop, spin, stop") = [] { | |
| scenario("motor spin, stop, spin, stop, spin, stop") = [] { |
or
Suggested change
| scenario("motor spin, stop, spin, stop") = [] { | |
| scenario("motor spin, stop three times") = [] { |
ladislas
force-pushed
the
ladislas/feature/deep-sleep-core-motor
branch
from
e15564b
to
c58bbd2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related story/pr: #1101