-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hugo/feature/Change animation blinkOnCharge #1218
hugo/feature/Change animation blinkOnCharge #1218
Conversation
HPezz
commented
Dec 15, 2022
- 🚸 (MotionKit): Improve smart reinforcer performance
- ♻️ (MotionKit): Add timeout to rotate() function
- ♻️ (libs): Update Motionkit calls
- 🚸 (BlinkOnCharge): Improve animation
- 🚸 (BehaviorKit): Trigger back BlinkOnCharge after BleConnection
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1218 +/- ##
========================================
Coverage 96.13% 96.13%
========================================
Files 146 146
Lines 3570 3575 +5
========================================
+ Hits 3432 3437 +5
Misses 138 138
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides stage naming 👍
21d767a
to
1f5737d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a charge notion in bleConnection is not good, and I just noticed that tests mention a condition on state connection or not: charging
State machine is composite, in the ideology to differentiate connection and robot states. So there are kind of not related.
Moreover Behaviors should not be aware of the state.
--
I don't have solution yet, I need some time to think about it.
1f5737d
to
3cf8575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typo + missing case
3cf8575
to
f6ba849
Compare
2cabce6
to
2d3b6b4
Compare
2d3b6b4
to
e28e23f
Compare
e28e23f
to
8c04035
Compare
Kudos, SonarCloud Quality Gate passed! |