♻️ (behaviorkit): Separate bleConnection into bleConnectionWithoutVideo and bleConnectionWithVideo #1251

YannLocatelli · 2023-01-13T12:58:31Z

Requirements

🚚 (behavior): Rename misleading bleConnection tests #1221

codecov · 2023-01-13T13:10:04Z

Codecov Report

Merging #1251 (50d98bc) into develop (e6c3a8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1251   +/-   ##
========================================
  Coverage    96.19%   96.19%           
========================================
  Files          146      146           
  Lines         3601     3603    +2     
========================================
+ Hits          3464     3466    +2     
  Misses         137      137

Impacted Files	Coverage Δ
libs/BehaviorKit/include/BehaviorKit.h	`100.00% <ø> (ø)`
libs/BehaviorKit/source/BehaviorKit.cpp	`100.00% <100.00%> (ø)`
libs/RobotKit/include/RobotController.h	`94.48% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2023-01-13T13:14:07Z

File comparision analysis report

🔖 Info

base: develop / e6c3a8f + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
head: yann/refactor/behaviorkit/refactor-bleconnection / 50d98bc + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (base/head)	Fash Used Δ	Flash Available (base/head)	Static RAM (base/head)	Static RAM Δ
bootloader	182804 (69%)	ø	79340 (30%) 79340 (30%)	41648 (7%)	ø
os	479572 (30%)	ø	1085100 (69%) 1085100 (69%)	93680 (17%)	ø

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	479572 (22%)	ø	93680 (17%)	ø
bootloader	✔️	✅	✅	182804 (8%)	ø	41648 (7%)	ø
functional_ut_boost_ut	✔️	✅	✅	409212 (19%)	ø	30608 (5%)	ø
functional_ut_core_imu	✔️	✅	✅	389196 (18%)	ø	30584 (5%)	ø
functional_ut_deep_sleep_core_buffered_serial	✔️	✅	✅	368140 (17%)	ø	30560 (5%)	ø
functional_ut_deep_sleep_core_motor	✔️	✅	✅	376076 (17%)	ø	30632 (5%)	ø
functional_ut_deep_sleep_core_pwm	✔️	✅	✅	378292 (18%)	ø	30632 (5%)	ø
functional_ut_deep_sleep_log_kit	✔️	✅	✅	365204 (17%)	ø	30976 (5%)	ø
functional_ut_deep_sleep_mbed_hal	✔️	✅	✅	366648 (17%)	ø	30560 (5%)	ø
functional_ut_file_manager	✔️	✅	✅	386684 (18%)	ø	30856 (5%)	ø
functional_ut_firmware_kit	✔️	✅	✅	378068 (18%)	ø	30840 (5%)	ø
functional_ut_imu_kit	✔️	✅	✅	391388 (18%)	ø	30576 (5%)	ø
functional_ut_io_expander	✔️	✅	✅	370896 (17%)	ø	30576 (5%)	ø
functional_ut_qdac	✔️	✅	✅	372064 (17%)	ø	30576 (5%)	ø
spike_lk_accel_gyro	✔️	✅	✅	94048 (4%)	ø	22568 (4%)	ø
spike_lk_audio	✔️	✅	✅	137044 (6%)	ø	25176 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	197564 (9%)	ø	58656 (11%)	ø
spike_lk_ble	✔️	✅	✅	237916 (11%)	ø	39416 (7%)	ø
spike_lk_bluetooth	✔️	✅	✅	92364 (4%)	ø	22224 (4%)	ø
spike_lk_cg_animations	✔️	✅	✅	153608 (7%)	ø	57224 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88480 (4%)	ø	24376 (4%)	ø
spike_lk_command_kit	✔️	✅	✅	219508 (10%)	ø	63120 (12%)	ø
spike_lk_config_kit	✔️	✅	✅	139244 (6%)	ø	25136 (4%)	ø
spike_lk_coreled	✔️	✅	✅	88044 (4%)	ø	24264 (4%)	ø
spike_lk_core_touch_sensor	✔️	✅	✅	92884 (4%)	ø	22832 (4%)	ø
spike_lk_event_queue	✔️	✅	✅	84152 (4%)	ø	22904 (4%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	154368 (7%)	ø	25520 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	339748 (16%)	ø	38448 (7%)	ø
spike_lk_flash_memory	✔️	✅	✅	86776 (4%)	ø	22216 (4%)	ø
spike_lk_fs	✔️	✅	✅	174440 (8%)	ø	47992 (9%)	ø
spike_lk_imu_kit	✔️	✅	✅	97920 (4%)	ø	22896 (4%)	ø
spike_lk_lcd	✔️	✅	✅	172652 (8%)	ø	57496 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115140 (5%)	ø	25104 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84776 (4%)	ø	23408 (4%)	ø
spike_lk_motion_kit	✔️	✅	✅	106736 (5%)	ø	24840 (4%)	ø
spike_lk_motors	✔️	✅	✅	86336 (4%)	ø	22248 (4%)	ø
spike_lk_qdac	✔️	✅	✅	91572 (4%)	ø	22776 (4%)	ø
spike_lk_reinforcer	✔️	✅	✅	215044 (10%)	ø	59800 (11%)	ø
spike_lk_rfid	✔️	✅	✅	84088 (4%)	ø	22184 (4%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87184 (4%)	ø	23280 (4%)	ø
spike_lk_sensors_light	✔️	✅	✅	84072 (4%)	ø	22216 (4%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84824 (4%)	ø	22216 (4%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90400 (4%)	ø	22192 (4%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91672 (4%)	ø	22456 (4%)	ø
spike_lk_serial_number	✔️	✅	✅	144900 (6%)	ø	25256 (4%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82712 (3%)	ø	22232 (4%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	156876 (7%)	ø	26288 (5%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100456 (4%)	ø	23240 (4%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87392 (4%)	ø	24120 (4%)	ø
spike_lk_wifi	✔️	✅	✅	130832 (6%)	ø	25528 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84176 (4%)	ø	23080 (4%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83488 (3%)	ø	22304 (4%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2023-01-13 13:56:44.121050545 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2023-01-13 13:56:44.493054242 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       670(+670) |     18(+18) |     247(+247) |
+| [fill]                     |       662(+662) |     18(+18) |     247(+247) |
 | [lib]/ActivityKit.a        |   10590(+10590) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1444(+1444) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
-| [lib]/BehaviorKit.a        |     1940(+1940) |   460(+460) |         0(+0) |
+| [lib]/BehaviorKit.a        |     1952(+1952) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       838(+838) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       806(+806) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 181108(+181108) |   773(+773) | 19755(+19755) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10716(+10716) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               | 121946(+121946) |   108(+108) | 37601(+37601) |
+| main.cpp.obj               | 121942(+121942) |   108(+108) | 37601(+37601) |
 | Subtotals                  | 435044(+435044) | 4424(+4424) | 88928(+88928) |
 Total Static RAM memory (data + bss): 93352(+93352) bytes
 Total Flash memory (text + data): 439468(+439468) bytes

github-actions · 2023-01-13T13:14:53Z

File comparision analysis report

🔖 Info

base: develop / e6c3a8f + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
head: yann/refactor/behaviorkit/refactor-bleconnection / 50d98bc + mbed-os-6.15.1+fixes+gcc-11-support + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (base/head)	Fash Used Δ	Flash Available (base/head)	Static RAM (base/head)	Static RAM Δ
bootloader	170348 (64%)	ø	91796 (35%) 91796 (35%)	30952 (5%)	ø
os	428088 (27%)	ø	1136584 (72%) 1136584 (72%)	82464 (15%)	ø

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	428088 (20%)	ø	82464 (15%)	ø
bootloader	✔️	✅	✅	170348 (8%)	ø	30952 (5%)	ø
functional_ut_boost_ut	✔️	✅	✅	394076 (18%)	ø	20456 (3%)	ø
functional_ut_core_imu	✔️	✅	✅	377068 (17%)	ø	20432 (3%)	ø
functional_ut_deep_sleep_core_buffered_serial	✔️	✅	✅	360236 (17%)	ø	20440 (3%)	ø
functional_ut_deep_sleep_core_motor	✔️	✅	✅	364476 (17%)	ø	20480 (3%)	ø
functional_ut_deep_sleep_core_pwm	✔️	✅	✅	366612 (17%)	ø	20480 (3%)	ø
functional_ut_deep_sleep_log_kit	✔️	✅	✅	352504 (16%)	ø	20408 (3%)	ø
functional_ut_deep_sleep_mbed_hal	✔️	✅	✅	354216 (16%)	ø	20408 (3%)	ø
functional_ut_file_manager	✔️	✅	✅	374864 (17%)	ø	20696 (3%)	ø
functional_ut_firmware_kit	✔️	✅	✅	366540 (17%)	ø	20688 (3%)	ø
functional_ut_imu_kit	✔️	✅	✅	382560 (18%)	ø	20424 (3%)	ø
functional_ut_io_expander	✔️	✅	✅	359232 (17%)	ø	20424 (3%)	ø
functional_ut_qdac	✔️	✅	✅	360400 (17%)	ø	20424 (3%)	ø
spike_lk_accel_gyro	✔️	✅	✅	71184 (3%)	ø	11808 (2%)	ø
spike_lk_audio	✔️	✅	✅	126924 (6%)	ø	14600 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	189000 (9%)	ø	48080 (9%)	ø
spike_lk_ble	✔️	✅	✅	229600 (10%)	ø	28472 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	145848 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65776 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	209184 (9%)	ø	52032 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	127268 (6%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_core_touch_sensor	✔️	✅	✅	80228 (3%)	ø	12256 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74800 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	139336 (6%)	ø	14440 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	335792 (16%)	ø	27792 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	175144 (8%)	ø	47904 (9%)	ø
spike_lk_imu_kit	✔️	✅	✅	87700 (4%)	ø	12176 (2%)	ø
spike_lk_lcd	✔️	✅	✅	162732 (7%)	ø	46664 (8%)	ø
spike_lk_led_kit	✔️	✅	✅	103360 (4%)	ø	14528 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63288 (3%)	ø	12256 (2%)	ø
spike_lk_motion_kit	✔️	✅	✅	101764 (4%)	ø	14288 (2%)	ø
spike_lk_motors	✔️	✅	✅	62864 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78628 (3%)	ø	11816 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	206416 (9%)	ø	49224 (9%)	ø
spike_lk_rfid	✔️	✅	✅	78956 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	133020 (6%)	ø	14304 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	145100 (6%)	ø	15584 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	80068 (3%)	ø	13272 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	58032 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-13 13:56:31.648049983 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-13 13:56:32.084053978 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       672(+672) |     18(+18) |     226(+226) |
+| [fill]                     |       664(+664) |     18(+18) |     226(+226) |
 | [lib]/ActivityKit.a        |   10590(+10590) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1444(+1444) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
-| [lib]/BehaviorKit.a        |     1940(+1940) |   460(+460) |         0(+0) |
+| [lib]/BehaviorKit.a        |     1952(+1952) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       838(+838) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       820(+820) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 179856(+179856) |   773(+773) | 19667(+19667) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10668(+10668) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               |   71118(+71118) |   108(+108) | 26494(+26494) |
+| main.cpp.obj               |   71114(+71114) |   108(+108) | 26494(+26494) |
 | Subtotals                  | 384036(+384036) | 4424(+4424) | 77712(+77712) |
 Total Static RAM memory (data + bss): 82136(+82136) bytes
 Total Flash memory (text + data): 388460(+388460) bytes

…eo and bleConnectionWithVideo

sonarcloud · 2023-01-13T13:56:09Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

ladislas

LGTM 👍

YannLocatelli added the 01 - type: task Something to do label Jan 13, 2023

YannLocatelli added this to the Future Release milestone Jan 13, 2023

YannLocatelli requested review from ladislas and HPezz January 13, 2023 12:58

YannLocatelli self-assigned this Jan 13, 2023

YannLocatelli linked an issue Jan 13, 2023 that may be closed by this pull request

[Task] - ♻️ (BehaviorKit) - Separate bleConnection into bleConnectionWithVideo and bleConnectionWithoutVideo #1250

Closed

Base automatically changed from yann/rename/behaviokit/ble-connection-test to develop January 13, 2023 13:10

♻️ (behaviorkit): Separate bleConnection into bleConnectionWithoutVid…

50d98bc

…eo and bleConnectionWithVideo

YannLocatelli force-pushed the yann/refactor/behaviorkit/refactor-bleconnection branch from 5700858 to 50d98bc Compare January 13, 2023 13:40

ladislas approved these changes Jan 13, 2023

View reviewed changes

ladislas merged commit aaa8c31 into develop Jan 13, 2023

ladislas deleted the yann/refactor/behaviorkit/refactor-bleconnection branch January 13, 2023 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

♻️ (behaviorkit): Separate bleConnection into bleConnectionWithoutVideo and bleConnectionWithVideo #1251

♻️ (behaviorkit): Separate bleConnection into bleConnectionWithoutVideo and bleConnectionWithVideo #1251

YannLocatelli commented Jan 13, 2023 •

edited

Loading

codecov bot commented Jan 13, 2023 •

edited

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading

sonarcloud bot commented Jan 13, 2023

ladislas left a comment

♻️ (behaviorkit): Separate bleConnection into bleConnectionWithoutVideo and bleConnectionWithVideo #1251

♻️ (behaviorkit): Separate bleConnection into bleConnectionWithoutVideo and bleConnectionWithVideo #1251

Conversation

YannLocatelli commented Jan 13, 2023 • edited Loading

Requirements

codecov bot commented Jan 13, 2023 • edited Loading

Codecov Report

github-actions bot commented Jan 13, 2023 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Jan 13, 2023 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

sonarcloud bot commented Jan 13, 2023

ladislas left a comment

Choose a reason for hiding this comment

YannLocatelli commented Jan 13, 2023 •

edited

Loading

codecov bot commented Jan 13, 2023 •

edited

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading

github-actions bot commented Jan 13, 2023 •

edited

Loading