Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Use std::function instead of mbed::Callback #1255

Merged
merged 6 commits into from
Jan 18, 2023
Merged

♻️ Use std::function instead of mbed::Callback #1255

merged 6 commits into from
Jan 18, 2023

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Jan 13, 2023 •
edited
Loading

Validations

  • BLE
  • Battery - onChargeDidStart
  • Battery - onChargeDidStop
  • RFID

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Jan 13, 2023
@YannLocatelli YannLocatelli added this to the Future Release milestone Jan 13, 2023
@YannLocatelli YannLocatelli self-assigned this Jan 13, 2023
@YannLocatelli YannLocatelli linked an issue Jan 13, 2023 that may be closed by this pull request
BatteryKit - Replace mbed::Callback by std::function #554
Closed
@YannLocatelli YannLocatelli force-pushed the yann/refactor/use-std-function-instead-of-mbed-callback branch from eb7d47a to 88b4d88 Compare January 13, 2023 21:54
@github-actions
Copy link

File comparision analysis report

🔖 Info

Target Flash Used (base/head) Fash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 182804 (69%)
182996 (69%)		 📈
+192 (+0%)		 79340 (30%)
79148 (30%)		 41648 (7%)
41680 (7%)		 📈
+32 (+0%)
os 495284 (31%)
495604 (31%)		 📈
+320 (+0%)		 1069388 (68%)
1069068 (68%)		 94280 (17%)
94328 (17%)		 📈
+48 (+0%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 495284 (23%)
495604 (23%)		 📈
+320 (+0%)		 94280 (17%)
94328 (17%)		 📈
+48 (+0%)
bootloader ✔️ ❌ ❌ 182804 (8%)
182996 (8%)		 📈
+192 (+0%)		 41648 (7%)
41680 (7%)		 📈
+32 (+0%)
functional_ut_boost_ut ✔️ ✅ ✅ 409212 (19%) ø 30608 (5%) ø
functional_ut_core_imu ✔️ ✅ ✅ 389196 (18%) ø 30584 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ❌ ❌ 368140 (17%)
368204 (17%)		 📈
+64 (+0%)		 30560 (5%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 376076 (17%) ø 30632 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 378292 (18%) ø 30632 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 365204 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 366648 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 386684 (18%) ø 30856 (5%) ø
functional_ut_firmware_kit ✔️ ✅ ✅ 378068 (18%) ø 30840 (5%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 391388 (18%) ø 30576 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 370896 (17%) ø 30576 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 372064 (17%) ø 30576 (5%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 94048 (4%) ø 22568 (4%) ø
spike_lk_audio ✔️ ✅ ✅ 137044 (6%) ø 25176 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 197564 (9%) ø 58656 (11%) ø
spike_lk_ble ✔️ ❌ ❌ 237916 (11%) ø 39416 (7%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 153608 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88480 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ ✅ ✅ 219508 (10%) ø 63120 (12%) ø
spike_lk_config_kit ✔️ ✅ ✅ 139244 (6%) ø 25136 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88044 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 92884 (4%) ø 22832 (4%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 154368 (7%) ø 25520 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 339748 (16%) ø 38448 (7%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ ✅ ✅ 174440 (8%) ø 47992 (9%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 97920 (4%) ø 22896 (4%) ø
spike_lk_lcd ✔️ ❌ ✅ 172652 (8%) ø 57496 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115140 (5%) ø 25104 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84776 (4%) ø 23408 (4%) ø
spike_lk_motion_kit ✔️ ❌ ❌ 106736 (5%)
106928 (5%)		 📈
+192 (+0%)		 24840 (4%)
24856 (4%)		 📈
+16 (+0%)
spike_lk_motors ✔️ ❌ ✅ 86336 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ ✅ ✅ 91572 (4%) ø 22776 (4%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 215044 (10%) ø 59800 (11%) ø
spike_lk_rfid ✔️ ❌ ❌ 84088 (4%)
84216 (4%)		 📈
+128 (+0%)		 22184 (4%) ø
spike_lk_sensors_battery ✔️ ❌ ❌ 87184 (4%)
87376 (4%)		 📈
+192 (+0%)		 23280 (4%)
23312 (4%)		 📈
+32 (+0%)
spike_lk_sensors_light ✔️ ✅ ✅ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90400 (4%) ø 22192 (4%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91672 (4%) ø 22456 (4%) ø
spike_lk_serial_number ✔️ ✅ ✅ 144900 (6%) ø 25256 (4%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82712 (3%) ø 22232 (4%) ø
spike_lk_touch_sensor_kit ✔️ ✅ ✅ 96452 (4%) ø 23400 (4%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 156876 (7%) ø 26288 (5%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ ❌ ❌ 87392 (4%)
87520 (4%)		 📈
+128 (+0%)		 24120 (4%)
24136 (4%)		 📈
+16 (+0%)
spike_lk_wifi ✔️ ✅ ✅ 130832 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2023-01-13 22:06:32.282831615 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2023-01-13 22:06:32.650831512 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       608(+608) |     18(+18) |     259(+259) |
+| [fill]                     |       670(+670) |     18(+18) |     259(+259) |
 | [lib]/ActivityKit.a        |   10590(+10590) |       0(+0) |         0(+0) |
-| [lib]/BLEKit.a             |     1444(+1444) |       0(+0) |         0(+0) |
+| [lib]/BLEKit.a             |     1476(+1476) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1952(+1952) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
-| [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
-| [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
+| [lib]/CoreBattery.a        |       544(+544) |       0(+0) |         0(+0) |
+| [lib]/CoreBufferedSerial.a |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
-| [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
+| [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |       580(+580) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       838(+838) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       806(+806) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 181108(+181108) |   773(+773) | 19755(+19755) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10716(+10716) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               | 137100(+137100) |   108(+108) | 38189(+38189) |
-| Subtotals                  | 450148(+450148) | 4424(+4424) | 89528(+89528) |
-Total Static RAM memory (data + bss): 93952(+93952) bytes
-Total Flash memory (text + data): 454572(+454572) bytes
+| main.cpp.obj               | 137184(+137184) |   108(+108) | 38237(+38237) |
+| Subtotals                  | 450468(+450468) | 4424(+4424) | 89576(+89576) |
+Total Static RAM memory (data + bss): 94000(+94000) bytes
+Total Flash memory (text + data): 454892(+454892) bytes
 
Flash used: 495604 (23%) / total: 2097152
SRAM used: 94328 (17%) / total: 524288
bootloader (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/bootloader-map.txt	2023-01-13 22:06:32.890831443 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/bootloader-map.txt	2023-01-13 22:06:33.094831384 +0000
@@ -1,28 +1,28 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
 | [fill]                  |       194(+194) |       8(+8) |       68(+68) |
 | [lib]/ConfigKit.a       |       284(+284) |       0(+0) |         0(+0) |
-| [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
+| [lib]/CoreBattery.a     |       648(+648) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1252(+1252) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     6022(+6022) |     16(+16) | 13816(+13816) |
 | [lib]/c.a               |   42144(+42144) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   83570(+83570) |   528(+528) | 11127(+11127) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   11484(+11484) |     16(+16) |     204(+204) |
 | default_bd.cpp.obj      |       242(+242) |       0(+0) |     568(+568) |
-| main.cpp.obj            |     7008(+7008) |     24(+24) | 12260(+12260) |
+| main.cpp.obj            |     7024(+7024) |     24(+24) | 12292(+12292) |
 | signing_keys.c.obj      |           0(+0) |       0(+0) |         0(+0) |
-| Subtotals               | 162200(+162200) | 3168(+3168) | 38168(+38168) |
-Total Static RAM memory (data + bss): 41336(+41336) bytes
-Total Flash memory (text + data): 165368(+165368) bytes
+| Subtotals               | 162392(+162392) | 3168(+3168) | 38200(+38200) |
+Total Static RAM memory (data + bss): 41368(+41368) bytes
+Total Flash memory (text + data): 165560(+165560) bytes
 
Flash used: 182996 (8%) / total: 2097152
SRAM used: 41680 (7%) / total: 524288
functional_ut_deep_sleep_core_buffered_serial (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/functional_ut_deep_sleep_core_buffered_serial-map.txt	2023-01-13 22:06:34.606830947 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/functional_ut_deep_sleep_core_buffered_serial-map.txt	2023-01-13 22:06:34.882830867 +0000
@@ -1,18 +1,18 @@
 | Module                             |           .text |       .data |          .bss |
 |------------------------------------|-----------------|-------------|---------------|
-| [fill]                             |       204(+204) |     16(+16) |       43(+43) |
-| [lib]/CoreBufferedSerial.a         |       124(+124) |       0(+0) |         0(+0) |
+| [fill]                             |       162(+162) |     16(+16) |       43(+43) |
+| [lib]/CoreBufferedSerial.a         |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a            |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/c.a                          |   72552(+72552) | 2574(+2574) |       97(+97) |
 | [lib]/gcc.a                        |     7416(+7416) |       0(+0) |         0(+0) |
 | [lib]/m.a                          |       372(+372) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a             |   54730(+54730) |   460(+460) | 10317(+10317) |
 | [lib]/misc                         |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a                      |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a                     | 174824(+174824) |   145(+145) |   5720(+5720) |
 | __/__                              |     3988(+3988) |       1(+1) | 10841(+10841) |
-| suite_core_buffered_serial.cpp.obj |     7262(+7262) |       0(+0) |         2(+2) |
-| Subtotals                          | 321700(+321700) | 3200(+3200) | 27048(+27048) |
+| suite_core_buffered_serial.cpp.obj |     7296(+7296) |       0(+0) |         2(+2) |
+| Subtotals                          | 321764(+321764) | 3200(+3200) | 27048(+27048) |
 Total Static RAM memory (data + bss): 30248(+30248) bytes
-Total Flash memory (text + data): 324900(+324900) bytes
+Total Flash memory (text + data): 324964(+324964) bytes
 
Flash used: 368204 (17%) / total: 2097152
SRAM used: 30560 (5%) / total: 524288
spike_lk_ble (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2023-01-13 22:06:41.766828904 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2023-01-13 22:06:42.010828838 +0000
@@ -1,19 +1,19 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       384(+384) |     15(+15) |       78(+78) |
-| [lib]/BLEKit.a          |     1462(+1462) |       0(+0) |         0(+0) |
-| [lib]/CoreEventQueue.a  |       122(+122) |       0(+0) |         0(+0) |
+| [fill]                  |       424(+424) |     15(+15) |       78(+78) |
+| [lib]/BLEKit.a          |     1500(+1500) |       0(+0) |         0(+0) |
+| [lib]/CoreEventQueue.a  |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1714(+1714) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   40860(+40860) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 145464(+145464) |   709(+709) | 19447(+19447) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9940(+9940) |     16(+16) |     204(+204) |
 | main.cpp.obj            |     7890(+7890) |     92(+92) | 15842(+15842) |
 | Subtotals               | 215572(+215572) | 3408(+3408) | 35696(+35696) |
 Total Static RAM memory (data + bss): 39104(+39104) bytes
 Total Flash memory (text + data): 218980(+218980) bytes
 





spike_lk_motion_kit (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_motion_kit-map.txt	2023-01-13 22:06:48.618827061 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_motion_kit-map.txt	2023-01-13 22:06:48.790827021 +0000
@@ -1,31 +1,31 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     152(+152) |       8(+8) |       40(+40) |
-| [lib]/CoreBufferedSerial.a |       78(+78) |       0(+0) |         0(+0) |
+| [fill]                     |     190(+190) |       8(+8) |       40(+40) |
+| [lib]/CoreBufferedSerial.a |     196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |     138(+138) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |       36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |   5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |     176(+176) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |       60(+60) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     592(+592) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     616(+616) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |     204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |     348(+348) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |   1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/MotionKit.a          |     884(+884) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/Utils.a              |       48(+48) |       0(+0) |         0(+0) |
 | [lib]/c.a                  | 25048(+25048) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |   1888(+1888) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 41232(+41232) |   444(+444) |   8322(+8322) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj               |   4156(+4156) |       0(+0) | 13116(+13116) |
-| Subtotals                  | 95508(+95508) | 2936(+2936) | 21616(+21616) |
-Total Static RAM memory (data + bss): 24552(+24552) bytes
-Total Flash memory (text + data): 98444(+98444) bytes
+| main.cpp.obj               |   4168(+4168) |       0(+0) | 13132(+13132) |
+| Subtotals                  | 95700(+95700) | 2936(+2936) | 21632(+21632) |
+Total Static RAM memory (data + bss): 24568(+24568) bytes
+Total Flash memory (text + data): 98636(+98636) bytes
 


Flash used: 106928 (5%) / total: 2097152
SRAM used: 24856 (4%) / total: 524288





spike_lk_rfid (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_rfid-map.txt	2023-01-13 22:06:50.210826690 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_rfid-map.txt	2023-01-13 22:06:50.374826652 +0000
@@ -1,21 +1,21 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     150(+150) |       8(+8) |       28(+28) |
-| [lib]/CoreBufferedSerial.a |     124(+124) |       0(+0) |         0(+0) |
+| [fill]                     |     124(+124) |       8(+8) |       28(+28) |
+| [lib]/CoreBufferedSerial.a |     250(+250) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     670(+670) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     694(+694) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/c.a                  | 25048(+25048) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 31650(+31650) |   444(+444) |   8226(+8226) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj               |   2736(+2736) |       0(+0) | 10568(+10568) |
-| Subtotals                  | 74772(+74772) | 2936(+2936) | 18960(+18960) |
+| main.cpp.obj               |   2740(+2740) |       0(+0) | 10568(+10568) |
+| Subtotals                  | 74900(+74900) | 2936(+2936) | 18960(+18960) |
 Total Static RAM memory (data + bss): 21896(+21896) bytes
-Total Flash memory (text + data): 77708(+77708) bytes
+Total Flash memory (text + data): 77836(+77836) bytes
 


Flash used: 84216 (4%) / total: 2097152
SRAM used: 22184 (4%) / total: 524288





spike_lk_sensors_battery (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_sensors_battery-map.txt	2023-01-13 22:06:50.574826605 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_sensors_battery-map.txt	2023-01-13 22:06:50.734826568 +0000
@@ -1,19 +1,19 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     174(+174) |       8(+8) |       30(+30) |
+| [fill]                  |     146(+146) |       8(+8) |       30(+30) |
 | [lib]/BatteryKit.a      |     360(+360) |       0(+0) |         0(+0) |
-| [lib]/CoreBattery.a     |     472(+472) |       0(+0) |         0(+0) |
+| [lib]/CoreBattery.a     |     648(+648) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 24948(+24948) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 34526(+34526) |   444(+444) |   8804(+8804) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   3278(+3278) |       0(+0) | 11092(+11092) |
-| Subtotals               | 77012(+77012) | 2936(+2936) | 20056(+20056) |
-Total Static RAM memory (data + bss): 22992(+22992) bytes
-Total Flash memory (text + data): 79948(+79948) bytes
+| main.cpp.obj            |   3322(+3322) |       0(+0) | 11124(+11124) |
+| Subtotals               | 77204(+77204) | 2936(+2936) | 20088(+20088) |
+Total Static RAM memory (data + bss): 23024(+23024) bytes
+Total Flash memory (text + data): 80140(+80140) bytes
 


Flash used: 87376 (4%) / total: 2097152
SRAM used: 23312 (4%) / total: 524288





spike_lk_watchdog_isr (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_watchdog_isr-map.txt	2023-01-13 22:06:54.338825728 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_watchdog_isr-map.txt	2023-01-13 22:06:54.502825690 +0000
@@ -1,21 +1,21 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     172(+172) |       8(+8) |       62(+62) |
-| [lib]/CoreBufferedSerial.a |       78(+78) |       0(+0) |         0(+0) |
+| [fill]                     |     146(+146) |       8(+8) |       62(+62) |
+| [lib]/CoreBufferedSerial.a |     196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     592(+592) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     616(+616) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/c.a                  | 25048(+25048) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 32840(+32840) |   444(+444) |   8242(+8242) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj               |   4592(+4592) |       0(+0) | 12454(+12454) |
-| Subtotals                  | 77716(+77716) | 2936(+2936) | 20896(+20896) |
-Total Static RAM memory (data + bss): 23832(+23832) bytes
-Total Flash memory (text + data): 80652(+80652) bytes
+| main.cpp.obj               |   4604(+4604) |       0(+0) | 12470(+12470) |
+| Subtotals                  | 77844(+77844) | 2936(+2936) | 20912(+20912) |
+Total Static RAM memory (data + bss): 23848(+23848) bytes
+Total Flash memory (text + data): 80780(+80780) bytes
 


Flash used: 87520 (4%) / total: 2097152
SRAM used: 24136 (4%) / total: 524288






      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @github-actions





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  


  

    

  





      


        


  
    

      
          
File comparision analysis report


🔖 Info







Target
Flash Used (base/head)
Fash Used Δ
Flash Available (base/head)
Static RAM (base/head)
Static RAM Δ






bootloader
170348 (64%)
170712 (65%)		
📈
+364 (+0%)		
91796 (35%)
91432 (34%)		
30952 (5%)
30984 (5%)		
📈
+32 (+0%)		




os
434312 (27%)
434568 (27%)		
📈
+256 (+0%)		
1130360 (72%)
1130104 (72%)		
83064 (15%)
83112 (15%)		
📈
+48 (+0%)		







Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |





📝 Summary



Click to show summary

    

  • ✔️ - existing target
    • 

  • ✨ - new target
    • 

  • ⚰️ - deleted target
    • 

  • ✅ - files are the same
    • 

  • ❌ - files are different
    • 







Target
Status
.bin
.map
Total Flash (base/head)
Total Flash Δ
Static RAM (base/head)
Static RAM Δ






LekaOS
✔️
❌
❌
434312 (20%)
434568 (20%)		
📈
+256 (+0%)		
83064 (15%)
83112 (15%)		
📈
+48 (+0%)		




bootloader
✔️
❌
❌
170348 (8%)
170712 (8%)		
📈
+364 (+0%)		
30952 (5%)
30984 (5%)		
📈
+32 (+0%)		




functional_ut_boost_ut
✔️
✅
✅
394076 (18%)
ø
20456 (3%)
ø




functional_ut_core_imu
✔️
✅
✅
377068 (17%)
ø
20432 (3%)
ø




functional_ut_deep_sleep_core_buffered_serial
✔️
❌
❌
360236 (17%)
360536 (17%)		
📈
+300 (+0%)		
20440 (3%)
ø




functional_ut_deep_sleep_core_motor
✔️
✅
✅
364476 (17%)
ø
20480 (3%)
ø




functional_ut_deep_sleep_core_pwm
✔️
✅
✅
366612 (17%)
ø
20480 (3%)
ø




functional_ut_deep_sleep_log_kit
✔️
✅
✅
352504 (16%)
ø
20408 (3%)
ø




functional_ut_deep_sleep_mbed_hal
✔️
✅
✅
354216 (16%)
ø
20408 (3%)
ø




functional_ut_file_manager
✔️
✅
✅
374864 (17%)
ø
20696 (3%)
ø




functional_ut_firmware_kit
✔️
✅
✅
366540 (17%)
ø
20688 (3%)
ø




functional_ut_imu_kit
✔️
✅
✅
382560 (18%)
ø
20424 (3%)
ø




functional_ut_io_expander
✔️
✅
✅
359232 (17%)
ø
20424 (3%)
ø




functional_ut_qdac
✔️
✅
✅
360400 (17%)
ø
20424 (3%)
ø




spike_lk_accel_gyro
✔️
✅
✅
71184 (3%)
ø
11808 (2%)
ø




spike_lk_audio
✔️
✅
✅
126924 (6%)
ø
14600 (2%)
ø




spike_lk_behavior_kit
✔️
✅
✅
189000 (9%)
ø
48080 (9%)
ø




spike_lk_ble
✔️
❌
❌
229600 (10%)
229536 (10%)		
📉
-64 (0%)		
28472 (5%)
ø




spike_lk_bluetooth
✔️
✅
✅
82948 (3%)
ø
11544 (2%)
ø




spike_lk_cg_animations
✔️
✅
✅
145848 (6%)
ø
46528 (8%)
ø




spike_lk_color_kit
✔️
✅
✅
65776 (3%)
ø
13744 (2%)
ø




spike_lk_command_kit
✔️
✅
✅
209184 (9%)
ø
52032 (9%)
ø




spike_lk_config_kit
✔️
✅
✅
127268 (6%)
ø
14312 (2%)
ø




spike_lk_coreled
✔️
✅
✅
76164 (3%)
ø
13688 (2%)
ø




spike_lk_core_touch_sensor
✔️
✅
✅
80228 (3%)
ø
12256 (2%)
ø




spike_lk_event_queue
✔️
✅
✅
74800 (3%)
ø
12072 (2%)
ø




spike_lk_file_manager_kit
✔️
✅
✅
139336 (6%)
ø
14440 (2%)
ø




spike_lk_file_reception
✔️
✅
✅
335792 (16%)
ø
27792 (5%)
ø




spike_lk_flash_memory
✔️
✅
✅
63880 (3%)
ø
11448 (2%)
ø




spike_lk_fs
✔️
✅
✅
175144 (8%)
ø
47904 (9%)
ø




spike_lk_imu_kit
✔️
✅
✅
87700 (4%)
ø
12176 (2%)
ø




spike_lk_lcd
✔️
✅
✅
162732 (7%)
ø
46664 (8%)
ø




spike_lk_led_kit
✔️
✅
✅
103360 (4%)
ø
14528 (2%)
ø




spike_lk_log_kit
✔️
✅
✅
63288 (3%)
ø
12256 (2%)
ø




spike_lk_motion_kit
✔️
❌
❌
101764 (4%)
101892 (4%)		
📈
+128 (+0%)		
14288 (2%)
14304 (2%)		
📈
+16 (+0%)		




spike_lk_motors
✔️
✅
✅
62864 (2%)
ø
11488 (2%)
ø




spike_lk_qdac
✔️
✅
✅
78628 (3%)
ø
11816 (2%)
ø




spike_lk_reinforcer
✔️
✅
✅
206416 (9%)
ø
49224 (9%)
ø




spike_lk_rfid
✔️
❌
❌
78956 (3%)
79084 (3%)		
📈
+128 (+0%)		
11504 (2%)
ø




spike_lk_sensors_battery
✔️
❌
❌
78196 (3%)
78388 (3%)		
📈
+192 (+0%)		
12568 (2%)
12600 (2%)		
📈
+32 (+0%)		




spike_lk_sensors_light
✔️
✅
✅
60056 (2%)
ø
11440 (2%)
ø




spike_lk_sensors_microphone
✔️
✅
✅
72496 (3%)
ø
11504 (2%)
ø




spike_lk_sensors_temperature_humidity
✔️
✅
✅
67048 (3%)
ø
11424 (2%)
ø




spike_lk_sensors_touch
✔️
✅
✅
68600 (3%)
ø
11432 (2%)
ø




spike_lk_serial_number
✔️
✅
✅
133020 (6%)
ø
14304 (2%)
ø




spike_lk_ticker_timeout
✔️
✅
✅
69052 (3%)
ø
11632 (2%)
ø




spike_lk_touch_sensor_kit
✔️
✅
✅
87680 (4%)
ø
12832 (2%)
ø




spike_lk_update_process_app_base
✔️
✅
✅
145100 (6%)
ø
15584 (2%)
ø




spike_lk_update_process_app_update
✔️
✅
✅
77632 (3%)
ø
12352 (2%)
ø




spike_lk_watchdog_isr
✔️
❌
❌
80068 (3%)
80196 (3%)		
📈
+128 (+0%)		
13272 (2%)
13288 (2%)		
📈
+16 (+0%)		




spike_lk_wifi
✔️
✅
✅
116392 (5%)
ø
14808 (2%)
ø




spike_mbed_blinky
✔️
✅
✅
58032 (2%)
ø
11400 (2%)
ø




spike_mbed_watchdog_ticker_vs_thread
✔️
✅
✅
63208 (3%)
ø
12448 (2%)
ø




spike_stl_cxxsupport
✔️
✅
✅
58456 (2%)
ø
11400 (2%)
ø








🗺️ Map files diff output



Click to show diff list


LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-13 22:06:36.919137530 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-13 22:06:37.287143515 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       682(+682) |     18(+18) |     238(+238) |
+| [fill]                     |       676(+676) |     18(+18) |     238(+238) |
 | [lib]/ActivityKit.a        |   10590(+10590) |       0(+0) |         0(+0) |
-| [lib]/BLEKit.a             |     1444(+1444) |       0(+0) |         0(+0) |
+| [lib]/BLEKit.a             |     1476(+1476) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1952(+1952) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
-| [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
-| [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
+| [lib]/CoreBattery.a        |       544(+544) |       0(+0) |         0(+0) |
+| [lib]/CoreBufferedSerial.a |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
-| [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
+| [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |       580(+580) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       838(+838) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       820(+820) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 179856(+179856) |   773(+773) | 19667(+19667) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10668(+10668) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               |   76856(+76856) |   108(+108) | 27082(+27082) |
-| Subtotals                  | 389796(+389796) | 4424(+4424) | 78312(+78312) |
-Total Static RAM memory (data + bss): 82736(+82736) bytes
-Total Flash memory (text + data): 394220(+394220) bytes
+| main.cpp.obj               |   76944(+76944) |   108(+108) | 27130(+27130) |
+| Subtotals                  | 390052(+390052) | 4424(+4424) | 78360(+78360) |
+Total Static RAM memory (data + bss): 82784(+82784) bytes
+Total Flash memory (text + data): 394476(+394476) bytes
 


Flash used: 434568 (20%) / total: 2097152
SRAM used: 83112 (15%) / total: 524288





bootloader (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/bootloader-map.txt	2023-01-13 22:06:37.523147353 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/bootloader-map.txt	2023-01-13 22:06:37.719150541 +0000
@@ -1,26 +1,26 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       232(+232) |       8(+8) |       65(+65) |
+| [fill]                  |       190(+190) |       8(+8) |       65(+65) |
 | [lib]/ConfigKit.a       |       284(+284) |       0(+0) |         0(+0) |
-| [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
+| [lib]/CoreBattery.a     |       648(+648) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1252(+1252) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     6022(+6022) |     16(+16) | 13816(+13816) |
 | [lib]/c.a               |   43360(+43360) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   74998(+74998) |   528(+528) | 11003(+11003) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a          |   10976(+10976) |     16(+16) |     204(+204) |
+| [lib]/stdc++.a          |   11064(+11064) |     16(+16) |     204(+204) |
 | default_bd.cpp.obj      |       242(+242) |       0(+0) |     568(+568) |
-| main.cpp.obj            |     4498(+4498) |     24(+24) |   1691(+1691) |
+| main.cpp.obj            |     4532(+4532) |     24(+24) |   1723(+1723) |
 | signing_keys.c.obj      |           0(+0) |       0(+0) |         0(+0) |
-| Subtotals               | 151496(+151496) | 3168(+3168) | 27472(+27472) |
-Total Static RAM memory (data + bss): 30640(+30640) bytes
-Total Flash memory (text + data): 154664(+154664) bytes
+| Subtotals               | 151752(+151752) | 3168(+3168) | 27504(+27504) |
+Total Static RAM memory (data + bss): 30672(+30672) bytes
+Total Flash memory (text + data): 154920(+154920) bytes
 


Flash used: 170712 (8%) / total: 2097152
SRAM used: 30984 (5%) / total: 524288





functional_ut_deep_sleep_core_buffered_serial (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/functional_ut_deep_sleep_core_buffered_serial-map.txt	2023-01-13 22:06:39.215174871 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/functional_ut_deep_sleep_core_buffered_serial-map.txt	2023-01-13 22:06:39.487179295 +0000
@@ -1,16 +1,16 @@
 | Module                             |           .text |       .data |          .bss |
 |------------------------------------|-----------------|-------------|---------------|
-| [fill]                             |       202(+202) |     16(+16) |       35(+35) |
-| [lib]/CoreBufferedSerial.a         |       124(+124) |       0(+0) |         0(+0) |
+| [fill]                             |       174(+174) |     16(+16) |       35(+35) |
+| [lib]/CoreBufferedSerial.a         |       214(+214) |       0(+0) |         0(+0) |
 | [lib]/c.a                          |   73780(+73780) | 2574(+2574) |       97(+97) |
 | [lib]/gcc.a                        |     7416(+7416) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a             |   50474(+50474) |   460(+460) | 10229(+10229) |
 | [lib]/misc                         |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a                      |         32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a                     | 174168(+174168) |   145(+145) |   5720(+5720) |
+| [lib]/stdc++.a                     | 174256(+174256) |   145(+145) |   5720(+5720) |
 | __/__                              |     1938(+1938) |       1(+1) |     817(+817) |
-| suite_core_buffered_serial.cpp.obj |     6778(+6778) |       0(+0) |         2(+2) |
-| Subtotals                          | 315100(+315100) | 3200(+3200) | 16928(+16928) |
+| suite_core_buffered_serial.cpp.obj |     6820(+6820) |       0(+0) |         2(+2) |
+| Subtotals                          | 315292(+315292) | 3200(+3200) | 16928(+16928) |
 Total Static RAM memory (data + bss): 20128(+20128) bytes
-Total Flash memory (text + data): 318300(+318300) bytes
+Total Flash memory (text + data): 318492(+318492) bytes
 


Flash used: 360536 (17%) / total: 2097152
SRAM used: 20440 (3%) / total: 524288





spike_lk_ble (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2023-01-13 22:06:46.187295185 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2023-01-13 22:06:46.427299412 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       402(+402) |     15(+15) |       82(+82) |
-| [lib]/BLEKit.a          |     1444(+1444) |       0(+0) |         0(+0) |
-| [lib]/CoreEventQueue.a  |       154(+154) |       0(+0) |         0(+0) |
+| [fill]                  |       378(+378) |     15(+15) |       82(+82) |
+| [lib]/BLEKit.a          |     1482(+1482) |       0(+0) |         0(+0) |
+| [lib]/CoreEventQueue.a  |         76(+76) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1714(+1714) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   42076(+42076) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 141468(+141468) |   709(+709) | 19323(+19323) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9520(+9520) |     16(+16) |     204(+204) |
 | main.cpp.obj            |     4746(+4746) |     92(+92) |   5018(+5018) |
-| Subtotals               | 208836(+208836) | 3408(+3408) | 24752(+24752) |
+| Subtotals               | 208772(+208772) | 3408(+3408) | 24752(+24752) |
 Total Static RAM memory (data + bss): 28160(+28160) bytes
-Total Flash memory (text + data): 212244(+212244) bytes
+Total Flash memory (text + data): 212180(+212180) bytes
 


Flash used: 229536 (10%) / total: 2097152
SRAM used: 28472 (5%) / total: 524288





spike_lk_motion_kit (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_motion_kit-map.txt	2023-01-13 22:06:52.719417500 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_motion_kit-map.txt	2023-01-13 22:06:52.883420714 +0000
@@ -1,30 +1,30 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     174(+174) |       8(+8) |       32(+32) |
-| [lib]/CoreBufferedSerial.a |       78(+78) |       0(+0) |         0(+0) |
+| [fill]                     |     148(+148) |       8(+8) |       32(+32) |
+| [lib]/CoreBufferedSerial.a |     196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |     138(+138) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |     126(+126) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |       36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |   5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |     176(+176) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |       60(+60) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     592(+592) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     616(+616) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |     204(+204) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |     348(+348) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |   1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/MotionKit.a          |     884(+884) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/Utils.a              |       48(+48) |       0(+0) |         0(+0) |
 | [lib]/c.a                  | 26128(+26128) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |   1528(+1528) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 40776(+40776) |   444(+444) |   8234(+8234) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj               |   1874(+1874) |       0(+0) |   2676(+2676) |
-| Subtotals                  | 92228(+92228) | 2936(+2936) | 11064(+11064) |
-Total Static RAM memory (data + bss): 14000(+14000) bytes
-Total Flash memory (text + data): 95164(+95164) bytes
+| main.cpp.obj               |   1886(+1886) |       0(+0) |   2692(+2692) |
+| Subtotals                  | 92356(+92356) | 2936(+2936) | 11080(+11080) |
+Total Static RAM memory (data + bss): 14016(+14016) bytes
+Total Flash memory (text + data): 95292(+95292) bytes
 


Flash used: 101892 (4%) / total: 2097152
SRAM used: 14304 (2%) / total: 524288





spike_lk_rfid (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_rfid-map.txt	2023-01-13 22:06:54.219446901 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_rfid-map.txt	2023-01-13 22:06:54.375449959 +0000
@@ -1,19 +1,19 @@
 | Module                     |         .text |       .data |        .bss |
 |----------------------------|---------------|-------------|-------------|
-| [fill]                     |     176(+176) |       8(+8) |     20(+20) |
-| [lib]/CoreBufferedSerial.a |     124(+124) |       0(+0) |       0(+0) |
+| [fill]                     |     150(+150) |       8(+8) |     20(+20) |
+| [lib]/CoreBufferedSerial.a |     250(+250) |       0(+0) |       0(+0) |
 | [lib]/CoreEventQueue.a     |     126(+126) |       0(+0) |       0(+0) |
-| [lib]/CoreRFIDReader.a     |     688(+688) |       0(+0) |       0(+0) |
+| [lib]/CoreRFIDReader.a     |     712(+712) |       0(+0) |       0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |       0(+0) |
 | [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |       8(+8) |
 | [lib]/c.a                  | 26128(+26128) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a                |   7084(+7084) |       0(+0) |       0(+0) |
 | [lib]/mbed-os-static.a     | 31142(+31142) |   444(+444) | 8138(+8138) |
 | [lib]/misc                 |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |       0(+0) |
 | [lib]/stdc++.a             |   4116(+4116) |       8(+8) |     28(+28) |
-| main.cpp.obj               |     356(+356) |       0(+0) |       0(+0) |
-| Subtotals                  | 71300(+71300) | 2936(+2936) | 8280(+8280) |
+| main.cpp.obj               |     360(+360) |       0(+0) |       0(+0) |
+| Subtotals                  | 71428(+71428) | 2936(+2936) | 8280(+8280) |
 Total Static RAM memory (data + bss): 11216(+11216) bytes
-Total Flash memory (text + data): 74236(+74236) bytes
+Total Flash memory (text + data): 74364(+74364) bytes
 


Flash used: 79084 (3%) / total: 2097152
SRAM used: 11504 (2%) / total: 524288





spike_lk_sensors_battery (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_sensors_battery-map.txt	2023-01-13 22:06:54.563453644 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_sensors_battery-map.txt	2023-01-13 22:06:54.719456702 +0000
@@ -1,17 +1,17 @@
 | Module                 |         .text |       .data |        .bss |
 |------------------------|---------------|-------------|-------------|
-| [fill]                 |     162(+162) |       8(+8) |     30(+30) |
+| [fill]                 |     138(+138) |       8(+8) |     30(+30) |
 | [lib]/BatteryKit.a     |     360(+360) |       0(+0) |       0(+0) |
-| [lib]/CoreBattery.a    |     472(+472) |       0(+0) |       0(+0) |
+| [lib]/CoreBattery.a    |     648(+648) |       0(+0) |       0(+0) |
 | [lib]/CoreEventQueue.a |     126(+126) |       0(+0) |       0(+0) |
 | [lib]/c.a              | 26028(+26028) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a            |   7084(+7084) |       0(+0) |       0(+0) |
 | [lib]/mbed-os-static.a | 30530(+30530) |   444(+444) | 8676(+8676) |
 | [lib]/misc             |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |       0(+0) |
 | [lib]/stdc++.a         |   4116(+4116) |       8(+8) |     28(+28) |
-| main.cpp.obj           |     858(+858) |       0(+0) |   524(+524) |
-| Subtotals              | 69956(+69956) | 2936(+2936) | 9344(+9344) |
-Total Static RAM memory (data + bss): 12280(+12280) bytes
-Total Flash memory (text + data): 72892(+72892) bytes
+| main.cpp.obj           |     898(+898) |       0(+0) |   556(+556) |
+| Subtotals              | 70148(+70148) | 2936(+2936) | 9376(+9376) |
+Total Static RAM memory (data + bss): 12312(+12312) bytes
+Total Flash memory (text + data): 73084(+73084) bytes
 


Flash used: 78388 (3%) / total: 2097152
SRAM used: 12600 (2%) / total: 524288





spike_lk_watchdog_isr (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_watchdog_isr-map.txt	2023-01-13 22:06:58.071522051 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_watchdog_isr-map.txt	2023-01-13 22:06:58.227525403 +0000
@@ -1,20 +1,20 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     142(+142) |       8(+8) |       38(+38) |
-| [lib]/CoreBufferedSerial.a |       78(+78) |       0(+0) |         0(+0) |
+| [fill]                     |     116(+116) |       8(+8) |       38(+38) |
+| [lib]/CoreBufferedSerial.a |     196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |     126(+126) |       0(+0) |         0(+0) |
-| [lib]/CoreRFIDReader.a     |     592(+592) |       0(+0) |         0(+0) |
+| [lib]/CoreRFIDReader.a     |     616(+616) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |   1046(+1046) |       0(+0) |         8(+8) |
 | [lib]/c.a                  | 26128(+26128) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 31536(+31536) |   444(+444) |   8154(+8154) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj               |   1218(+1218) |       0(+0) |   1734(+1734) |
-| Subtotals                  | 72388(+72388) | 2936(+2936) | 10048(+10048) |
-Total Static RAM memory (data + bss): 12984(+12984) bytes
-Total Flash memory (text + data): 75324(+75324) bytes
+| main.cpp.obj               |   1230(+1230) |       0(+0) |   1750(+1750) |
+| Subtotals                  | 72516(+72516) | 2936(+2936) | 10064(+10064) |
+Total Static RAM memory (data + bss): 13000(+13000) bytes
+Total Flash memory (text + data): 75452(+75452) bytes
 


Flash used: 80196 (3%) / total: 2097152
SRAM used: 13288 (2%) / total: 524288






      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @sonarcloud





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  


  

    

      

      
            sonarcloud
  bot

      

      

      commented


        Jan 13, 2023


      
    


  





      


        


  
    

      
          
Kudos, SonarCloud Quality Gate passed!    Quality Gate passed


Bug A 0 Bugs

Vulnerability A 0 Vulnerabilities

Security Hotspot A 0 Security Hotspots

Code Smell A 0 Code Smells


100.0% 100.0% Coverage

0.0% 0.0% Duplication

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @codecov





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      



      

  


  

    

      

      
            codecov
  bot

      

      

      commented


        Jan 13, 2023


      
    


  





      


        


  
    

      
          
Codecov Report




Merging #1255 (88b4d88) into develop (b955a64) will increase coverage by 0.00%.

The diff coverage is 100.00%.




@@           Coverage Diff            @@
##           develop    #1255   +/-   ##
========================================
  Coverage    96.20%   96.20%           
========================================
  Files          148      148           
  Lines         3713     3715    +2     
========================================
+ Hits          3572     3574    +2     
  Misses         141      141           






Impacted Files
Coverage Δ







drivers/CoreBattery/include/CoreBattery.h
100.00% <ø> (ø)





...rs/CoreBufferedSerial/include/CoreBufferedSerial.h
100.00% <ø> (ø)





drivers/CoreEventQueue/include/CoreEventQueue.h
100.00% <ø> (ø)





libs/BatteryKit/include/BatteryKit.h
100.00% <ø> (ø)





drivers/CoreBattery/source/CoreBattery.cpp
100.00% <100.00%> (ø)





libs/BLEKit/source/BLEKit.cpp
100.00% <100.00%> (ø)





libs/BatteryKit/source/BatteryKit.cpp
100.00% <100.00%> (ø)







📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        

  

      

  ladislas
  

  
          

            
                  ladislas
  

            

            requested changes


            
                
                  Jan 14, 2023
                
            
            
          


          



              
    View reviewed changes
  


          





          

  
  
  
              

                        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
  Member


      

  


  

    

      @ladislas

      
            ladislas
  

      

      

      left a comment




      
    


  



                    

                        

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
thanks for this PR! good to see mbed::callback going away in a lot of places :)


I've added a few suggestions where I think that mbed::callback can be completely removed and replaced by simple lambdas.

    

  
  




                      

                    
  

    
  
    
    

  

  




                        

                      
                    








      

  
  
  
            
    

          

        
              drivers/CoreBattery/source/CoreBattery.cpp

        
          Show resolved
          Hide resolved
      


    
        
          
  
    
    

        





  
    

          

        
              drivers/CoreBattery/source/CoreBattery.cpp

        
          Show resolved
          Hide resolved
      


    
        
          
  
    
    

        





  
    

          

        
              drivers/CoreBufferedSerial/source/CoreBufferedSerial.cpp

        
          Show resolved
          Hide resolved
      


    
        
          
  
    
    

        





  
    

          

        
              libs/BLEKit/source/BLEKit.cpp

        
          Show resolved
          Hide resolved
      


    
        
          
  
    
    

        











  








      

  
          

  
  

  
      @YannLocatelli
  YannLocatelli


        marked this pull request as ready for review

    
      January 16, 2023 10:22
    
    




  





      

  
        

  

      

  HPezz
  

  
          

            
                  HPezz
  

            

            reviewed


            
                
                  Jan 18, 2023
                
            
            
          


          



              
    View reviewed changes
  


          





          

  
  
  
              

                        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

      

  
    Contributor


      

  


  

    

      @HPezz

      
            HPezz
  

      

      

      left a comment




      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  



                    

                        

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Nice 👍


    

  •  Validated on robot
    • 


    

  
  




                      

                    
  

    
  
    
    

  

  




                        

                      
                    








      

  
  
  




  








      

  
        





      

  
          

  

    
  

  



        @ladislas
  ladislas



        merged commit ccc3871
      into

      
  
    develop
  


    Jan 18, 2023

  







  

  
  

  
      @ladislas
  ladislas


    
    deleted the
    
      
        yann/refactor/use-std-function-instead-of-mbed-callback
    
    branch

    
      January 18, 2023 17:49
    
    













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


        

          

  
    @HPezz
  
    HPezz



          
            
              
            
          
          HPezz left review comments

        

        

          

  
    @ladislas
  
    ladislas



          
            
              
            
          
          ladislas approved these changes

        


      






    

  


      
  

    Assignees
  



        

      

        

  
    @YannLocatelli
  
    YannLocatelli
    

      








      


  


  

    Labels
  



    

      

    01 - type: task

  Something to do








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    Future Release
  





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.


  
    
            
        BatteryKit - Replace mbed::Callback by std::function


  


    
  




        
      

    

  
      

  

    

      3 participants
    

    

        
          @YannLocatelli 
        
          @ladislas 
        
          @HPezz