Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (cert): Investigation Day 2 #126

Merged
merged 6 commits into from
Feb 12, 2021
Merged

Conversation

YannLocatelli
Copy link
Member

Copy of emc_lcd_leds_motors


void Bluetooth::start()
{
printf("Bluetooth example\n\n");
char text[max_buffer_size] = {0};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable text is assigned a value that is never used.


void Bluetooth::start()
{
printf("Bluetooth example\n\n");
char text[max_buffer_size] = {0};
uint16_t text_length;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable: text_length

@YannLocatelli YannLocatelli force-pushed the yann/feature/investigation-day-2 branch from f2fa091 to 7c55702 Compare February 2, 2021 21:10
@YannLocatelli YannLocatelli changed the title Investigation Day 2 ✨ (cert): Investigation Day 2 Feb 11, 2021
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- quand on intégrera tout ça en vrai drivers/libraries il faudra pas oublier de update les spikes et tests

- Converse via bluetooth on computer
- Use sound by enabling equalizer
- Choice on command
- Get answer
- Calibration of sensors seperated
- updateSensorsStatus now returns value
✨ (cert): Add cert2 from emc_lcd_leds_mot

✨ (cert): Battery and Still alive message
- Add batteries level
- Duration with hours and minutes

✨ (cert): Add BLE
- BLE Beacon, named LekaBeacon
- Add delay of 10s to check ble mac address
- Add std:: before chrono due to ambiguous use

✨ (cert): Add Audio
- Play wav file on haptic actuator
- Need to speed up SD frequency (25000000Hz)

✨ (cert) Add bluetooth in main loop
- Message via bluetooth
- Can play audio via bluetooth

✨ (cert): Add RFID main loop
- Remove a printf in RFID lib

✨ (cert): Add Touch main loop

✨ (cert): Choice of features
- Use of #define for features and #if/#endif to apply
- Use example bluetooth echo via com
@codeclimate
Copy link

codeclimate bot commented Feb 12, 2021

Code Climate has analyzed commit db2ac04 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@YannLocatelli
Copy link
Member Author

YannLocatelli commented Feb 12, 2021

  • Les commits ✨ (libs) ont été remis en premiers
  • Les commits ✨ (cert) ont été squash, ils ne sont liés qu'au programme de la journée d'investigation, tous dans le dossier emc_ble_bt_lcd_led_motors
  • Rebase par rapport à 0278498
  • Le tout a été vérifié sur le robot, tout fonctionne comme lors de la journée ✅

@ladislas ladislas merged commit a115d42 into develop Feb 12, 2021
@ladislas ladislas deleted the yann/feature/investigation-day-2 branch February 12, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants