Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ladislas/feature/generate directory strcture as namespace #1266

Merged

Conversation

ladislas
Copy link
Member

  • 🔨 (fs): Add script to translate fs structure to namespaces
  • ♻️ (BehaviorKit): Replace img/vid paths w/ namespaces

@ladislas ladislas self-assigned this Jan 23, 2023
@ladislas ladislas added the 01 - type: task Something to do label Jan 23, 2023
@ladislas ladislas added this to the Future Release milestone Jan 23, 2023
@ladislas ladislas force-pushed the ladislas/feature/generate-directory-strcture-as-namespace branch 2 times, most recently from 7b3365e to 3a007dd Compare January 23, 2023 14:08
@github-actions
Copy link

github-actions bot commented Jan 23, 2023

Version comparison

- Version Same as filename Same as os_version
os 1.3.0+1674498403 ✔️ ✔️
firmware
(os + bootloader)
1.3.0+1674498403 ✔️ ✔️

@ladislas ladislas force-pushed the ladislas/feature/generate-directory-strcture-as-namespace branch from 3a007dd to b854e16 Compare January 23, 2023 14:21
@github-actions
Copy link

github-actions bot commented Jan 23, 2023

File comparision analysis report

🔖 Info

Target Flash Used (base/head) Fash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 183068 (69%) ø 79076 (30%)
79076 (30%)
41664 (7%) ø
os 495884 (31%) ø 1068788 (68%)
1068788 (68%)
94328 (17%) ø
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 495884 (23%) ø 94328 (17%) ø
bootloader ✔️ 183068 (8%) ø 41664 (7%) ø
functional_ut_boost_ut ✔️ 409276 (19%) ø 30608 (5%) ø
functional_ut_core_imu ✔️ 389476 (18%) ø 30584 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 368332 (17%) ø 30560 (5%) ø
functional_ut_deep_sleep_core_motor ✔️ 376140 (17%) ø 30632 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ 378356 (18%) ø 30632 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ 365268 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 366712 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ 386812 (18%) ø 30856 (5%) ø
functional_ut_firmware_kit ✔️ 378420 (18%) ø 30840 (5%) ø
functional_ut_imu_kit ✔️ 391668 (18%) ø 30576 (5%) ø
functional_ut_io_expander ✔️ 371176 (17%) ø 30576 (5%) ø
functional_ut_qdac ✔️ 372344 (17%) ø 30576 (5%) ø
spike_lk_accel_gyro ✔️ 94264 (4%) ø 22560 (4%) ø
spike_lk_audio ✔️ 137172 (6%) ø 25176 (4%) ø
spike_lk_behavior_kit ✔️ 198204 (9%) ø 58656 (11%) ø
spike_lk_ble ✔️ 237980 (11%) ø 39416 (7%) ø
spike_lk_bluetooth ✔️ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ 153672 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ 88544 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ 219788 (10%) ø 63112 (12%) ø
spike_lk_config_kit ✔️ 139228 (6%) ø 25192 (4%) ø
spike_lk_coreled ✔️ 88108 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ 93164 (4%) ø 22824 (4%) ø
spike_lk_event_queue ✔️ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ 154432 (7%) ø 25520 (4%) ø
spike_lk_file_reception ✔️ 339964 (16%) ø 38448 (7%) ø
spike_lk_flash_memory ✔️ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ 174568 (8%) ø 47992 (9%) ø
spike_lk_imu_kit ✔️ 98144 (4%) ø 22888 (4%) ø
spike_lk_lcd ✔️ 172716 (8%) ø 57496 (10%) ø
spike_lk_led_kit ✔️ 115204 (5%) ø 25104 (4%) ø
spike_lk_log_kit ✔️ 84776 (4%) ø 23408 (4%) ø
spike_lk_motion_kit ✔️ 107144 (5%) ø 24840 (4%) ø
spike_lk_motors ✔️ 86336 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ 91796 (4%) ø 22768 (4%) ø
spike_lk_reinforcer ✔️ 215324 (10%) ø 59784 (11%) ø
spike_lk_rfid ✔️ 84216 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ 87376 (4%) ø 23312 (4%) ø
spike_lk_sensors_light ✔️ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ 90616 (4%) ø 22192 (4%) ø
spike_lk_serial_number ✔️ 145028 (6%) ø 25256 (4%) ø
spike_lk_ticker_timeout ✔️ 82712 (3%) ø 22232 (4%) ø
spike_lk_touch_sensor_kit ✔️ 96668 (4%) ø 23392 (4%) ø
spike_lk_update_process_app_base ✔️ 157244 (7%) ø 26288 (5%) ø
spike_lk_update_process_app_update ✔️ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ 87520 (4%) ø 24136 (4%) ø
spike_lk_wifi ✔️ 130984 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Jan 23, 2023

File comparision analysis report

🔖 Info

Target Flash Used (base/head) Fash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 170784 (65%) ø 91360 (34%)
91360 (34%)
30968 (5%) ø
os 435024 (27%)
434912 (27%)
📉
-112 (0%)
1129648 (72%)
1129760 (72%)
83112 (15%) ø
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 435024 (20%)
434912 (20%)
📉
-112 (0%)
83112 (15%) ø
bootloader ✔️ 170784 (8%) ø 30968 (5%) ø
functional_ut_boost_ut ✔️ 394140 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ 377348 (17%) ø 20432 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 360600 (17%) ø 20440 (3%) ø
functional_ut_deep_sleep_core_motor ✔️ 364540 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ 366676 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ 352568 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 354344 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ 374928 (17%) ø 20696 (3%) ø
functional_ut_firmware_kit ✔️ 366972 (17%) ø 20688 (3%) ø
functional_ut_imu_kit ✔️ 382840 (18%) ø 20424 (3%) ø
functional_ut_io_expander ✔️ 359576 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ 360744 (17%) ø 20424 (3%) ø
spike_lk_accel_gyro ✔️ 71408 (3%) ø 11800 (2%) ø
spike_lk_audio ✔️ 126988 (6%) ø 14600 (2%) ø
spike_lk_behavior_kit ✔️ 189064 (9%)
189656 (9%)
📈
+592 (+0%)
48080 (9%) ø
spike_lk_ble ✔️ 229600 (10%) ø 28472 (5%) ø
spike_lk_bluetooth ✔️ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ 145976 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ 65840 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ 209528 (9%) ø 52024 (9%) ø
spike_lk_config_kit ✔️ 127284 (6%) ø 14368 (2%) ø
spike_lk_coreled ✔️ 76292 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ 80508 (3%) ø 12248 (2%) ø
spike_lk_event_queue ✔️ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ 139400 (6%) ø 14440 (2%) ø
spike_lk_file_reception ✔️ 336000 (16%) ø 27792 (5%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ 175208 (8%) ø 47904 (9%) ø
spike_lk_imu_kit ✔️ 87980 (4%) ø 12168 (2%) ø
spike_lk_lcd ✔️ 162796 (7%) ø 46664 (8%) ø
spike_lk_led_kit ✔️ 103424 (4%) ø 14528 (2%) ø
spike_lk_log_kit ✔️ 63288 (3%) ø 12256 (2%) ø
spike_lk_motion_kit ✔️ 102172 (4%) ø 14288 (2%) ø
spike_lk_motors ✔️ 62864 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ 78852 (3%) ø 11808 (2%) ø
spike_lk_reinforcer ✔️ 206760 (9%) ø 49208 (9%) ø
spike_lk_rfid ✔️ 79084 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ 78388 (3%) ø 12600 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 67272 (3%) ø 11424 (2%) ø
spike_lk_serial_number ✔️ 133084 (6%) ø 14304 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_touch_sensor_kit ✔️ 87896 (4%) ø 12824 (2%) ø
spike_lk_update_process_app_base ✔️ 145452 (6%) ø 15584 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ 80196 (3%) ø 13288 (2%) ø
spike_lk_wifi ✔️ 116544 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-23 18:34:44.214941818 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-23 18:34:44.586939607 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       684(+684) |     18(+18) |     246(+246) |
+| [fill]                     |       692(+692) |     18(+18) |     246(+246) |
 | [lib]/ActivityKit.a        |   10590(+10590) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1476(+1476) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
-| [lib]/BehaviorKit.a        |     1852(+1852) |   460(+460) |         0(+0) |
+| [lib]/BehaviorKit.a        |     1652(+1652) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       544(+544) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       580(+580) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |     1006(+1006) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       838(+838) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       820(+820) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 180206(+180206) |   773(+773) | 19667(+19667) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10668(+10668) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
 | main.cpp.obj               |   76950(+76950) |   108(+108) | 27122(+27122) |
-| Subtotals                  | 390500(+390500) | 4424(+4424) | 78360(+78360) |
+| Subtotals                  | 390308(+390308) | 4424(+4424) | 78360(+78360) |
 Total Static RAM memory (data + bss): 82784(+82784) bytes
-Total Flash memory (text + data): 394924(+394924) bytes
+Total Flash memory (text + data): 394732(+394732) bytes
 
Flash used: 434912 (20%) / total: 2097152
SRAM used: 83112 (15%) / total: 524288
spike_lk_behavior_kit (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_behavior_kit-map.txt	2023-01-23 18:34:53.094888925 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_behavior_kit-map.txt	2023-01-23 18:34:53.306887657 +0000
@@ -1,29 +1,29 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       238(+238) |     11(+11) |       42(+42) |
-| [lib]/BehaviorKit.a    |     1276(+1276) |   460(+460) |         0(+0) |
+| [fill]                 |       258(+258) |     11(+11) |       42(+42) |
+| [lib]/BehaviorKit.a    |     1256(+1256) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a       |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a      |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a        |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a        |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a   |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a      |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/EventLoopKit.a   |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a |     1238(+1238) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a         |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/VideoKit.a       |     1004(+1004) |       0(+0) |       36(+36) |
 | [lib]/c.a              |   42000(+42000) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a            |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a              |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a |   64832(+64832) |   464(+464) | 10261(+10261) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |   10296(+10296) |     16(+16) |     204(+204) |
 | __/__                  |       108(+108) |       0(+0) |         0(+0) |
 | main.cpp.obj           |     3698(+3698) |       8(+8) |   2736(+2736) |
 | Subtotals              | 161860(+161860) | 3536(+3536) | 44224(+44224) |
 Total Static RAM memory (data + bss): 47760(+47760) bytes
 Total Flash memory (text + data): 165396(+165396) bytes
 
Flash used: 189656 (9%) / total: 2097152
SRAM used: 48080 (9%) / total: 524288

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1266 (a48870f) into develop (6fc6b93) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1266   +/-   ##
========================================
  Coverage    96.21%   96.21%           
========================================
  Files          150      150           
  Lines         3727     3727           
========================================
  Hits          3586     3586           
  Misses         141      141           
Impacted Files Coverage Δ
libs/BehaviorKit/source/BehaviorKit.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This script recursively walks the content of `fs/` and generates the
equivalent namespace strcture:

- directories --> namespace
- files --> std::string_view
@ladislas ladislas force-pushed the ladislas/feature/generate-directory-strcture-as-namespace branch from a48870f to d71751a Compare January 23, 2023 18:25
@ladislas ladislas merged commit 1c46e28 into develop Jan 23, 2023
@ladislas ladislas deleted the ladislas/feature/generate-directory-strcture-as-namespace branch January 23, 2023 18:25
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants