♻️ (video): Forward declare CGColor and CGPixel struct #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 25, 2023
Version comparison
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
Codecov Report
@@ Coverage Diff @@
## develop #1271 +/- ##
========================================
Coverage 98.20% 98.20%
========================================
Files 150 150
Lines 3727 3727
========================================
Hits 3660 3660
Misses 67 67
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
YannLocatelli
force-pushed
the
yann/refactor/video/forward-declare-CGColor-CGPixel-struct
branch
from
a78c489
to
aec856f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ladislas
approved these changes
Jan 31, 2023
Comment on lines
+13
to
+17
| struct FilledRectangle { | ||
| CGPoint origin {0, 0}; // * Top left corner by convention | ||
| uint16_t width {}; | ||
| uint16_t height {}; | ||
| }; |
There was a problem hiding this comment.
why not just Rectangle? :)
Also I'm wondering if it would not be simpler to store the color directly in the struct.
If we look at how SVG is designed, we can see that the fill color is stored directly into the object and used when it's drawn.
This would allow us to move the rectangle on the screen without the need to store the color somewhere else.
In the future, we might have stroke and stroke_width which are also object related.
Suggested change
| struct FilledRectangle { | |
| CGPoint origin {0, 0}; // * Top left corner by convention | |
| uint16_t width {}; | |
| uint16_t height {}; | |
| }; | |
| struct Rectangle { | |
| CGPoint origin {0, 0}; // * Top left corner by convention | |
| uint16_t width {}; | |
| uint16_t height {}; | |
| CGColor color {}; | |
| }; |
Comment on lines
+11
to
+12
| struct CGColor; | ||
| struct Character; |
There was a problem hiding this comment.
Nice! 👍
In the future, I still have the wish to put all those "user types" in the main include directory and have our code depend on it directly.
This is something discussed by Tony in the Cpp.chat episode https://www.youtube.com/watch?v=WRMhO9Gn5GM
Very interesting talk btw.
| CGColor background = CGColor::white) = 0; | ||
| virtual void display(const char *text, uint32_t size, uint32_t starting_line, CGColor foreground = CGColor::black, | ||
| CGColor background = CGColor::white) = 0; | ||
| virtual void drawChar(Character character, CGColor foreground, CGColor background) = 0; |
There was a problem hiding this comment.
the same question about background/foreground can be asked here: could they be stored directly inside the struct?
Comment on lines
+147
to
150
| Character character {}; | ||
| character.ascii = '.'; | ||
| CGColor foreground_color = CGColor::pure_red; | ||
| CGColor background_color = CGColor::black; |
There was a problem hiding this comment.
building on the previous comment, storing the colors inside the struct would allow us to do:
Suggested change
| Character character {}; | |
| character.ascii = '.'; | |
| CGColor foreground_color = CGColor::pure_red; | |
| CGColor background_color = CGColor::black; | |
| Character character {.ascii = '.', | |
| .foreground = CGColor::pure_red, | |
| .background= CGColor::black, | |
| }; |
ladislas
deleted the
yann/refactor/video/forward-declare-CGColor-CGPixel-struct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation