Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (rc): Get Magic card via BLE #1273

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Jan 26, 2023

Validation

  • LekaOS

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Jan 26, 2023
@YannLocatelli YannLocatelli added this to the Future Release milestone Jan 26, 2023
@YannLocatelli YannLocatelli self-assigned this Jan 26, 2023
@github-actions
Copy link

github-actions bot commented Jan 26, 2023

Version comparison

- Version Same as filename Same as os_version
os 1.3.0+1675167188 ✔️ ✔️
firmware
(os + bootloader)
1.3.0+1675167188 ✔️ ✔️

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

File comparision analysis report

🔖 Info

Target Flash Used (base/head) Fash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 170784 (65%) ø 91360 (34%)
91360 (34%)
30968 (5%) ø
os 434912 (27%)
435376 (27%)
📈
+464 (+0%)
1129760 (72%)
1129296 (72%)
83112 (15%)
83368 (15%)
📈
+256 (+0%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 434912 (20%)
435376 (20%)
📈
+464 (+0%)
83112 (15%)
83368 (15%)
📈
+256 (+0%)
bootloader ✔️ 170784 (8%) ø 30968 (5%) ø
functional_ut_boost_ut ✔️ 394140 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ 377348 (17%) ø 20432 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 360600 (17%) ø 20440 (3%) ø
functional_ut_deep_sleep_core_motor ✔️ 364540 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ 366676 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ 352568 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 354344 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ 374928 (17%) ø 20696 (3%) ø
functional_ut_firmware_kit ✔️ 366972 (17%) ø 20688 (3%) ø
functional_ut_imu_kit ✔️ 382840 (18%) ø 20424 (3%) ø
functional_ut_io_expander ✔️ 359576 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ 360744 (17%) ø 20424 (3%) ø
spike_lk_accel_gyro ✔️ 71408 (3%) ø 11800 (2%) ø
spike_lk_audio ✔️ 126988 (6%) ø 14600 (2%) ø
spike_lk_behavior_kit ✔️ 189656 (9%) ø 48080 (9%) ø
spike_lk_ble ✔️ 229600 (10%) ø 28472 (5%) ø
spike_lk_bluetooth ✔️ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ 145976 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ 65840 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ 209528 (9%) ø 52024 (9%) ø
spike_lk_config_kit ✔️ 127284 (6%) ø 14368 (2%) ø
spike_lk_coreled ✔️ 76292 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ 80508 (3%) ø 12248 (2%) ø
spike_lk_event_queue ✔️ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ 139400 (6%) ø 14440 (2%) ø
spike_lk_file_reception ✔️ 336000 (16%) ø 27792 (5%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ 175208 (8%) ø 47904 (9%) ø
spike_lk_imu_kit ✔️ 87980 (4%) ø 12168 (2%) ø
spike_lk_lcd ✔️ 162796 (7%) ø 46664 (8%) ø
spike_lk_led_kit ✔️ 103424 (4%) ø 14528 (2%) ø
spike_lk_log_kit ✔️ 63288 (3%) ø 12256 (2%) ø
spike_lk_motion_kit ✔️ 102172 (4%) ø 14288 (2%) ø
spike_lk_motors ✔️ 62864 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ 78852 (3%) ø 11808 (2%) ø
spike_lk_reinforcer ✔️ 206760 (9%) ø 49208 (9%) ø
spike_lk_rfid ✔️ 79084 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ 78388 (3%) ø 12600 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 67272 (3%) ø 11424 (2%) ø
spike_lk_serial_number ✔️ 133084 (6%) ø 14304 (2%) ø
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_touch_sensor_kit ✔️ 87896 (4%) ø 12824 (2%) ø
spike_lk_update_process_app_base ✔️ 145452 (6%) ø 15584 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ 80196 (3%) ø 13288 (2%) ø
spike_lk_wifi ✔️ 116544 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-31 00:10:03.526323362 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2023-01-31 00:10:03.914328093 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       692(+692) |     18(+18) |     246(+246) |
+| [fill]                     |       636(+636) |     18(+18) |     246(+246) |
 | [lib]/ActivityKit.a        |   10590(+10590) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1476(+1476) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1652(+1652) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       544(+544) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       580(+580) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |     1006(+1006) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       838(+838) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       820(+820) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 180206(+180206) |   773(+773) | 19667(+19667) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10668(+10668) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               |   76950(+76950) |   108(+108) | 27122(+27122) |
-| Subtotals                  | 390308(+390308) | 4424(+4424) | 78360(+78360) |
-Total Static RAM memory (data + bss): 82784(+82784) bytes
-Total Flash memory (text + data): 394732(+394732) bytes
+| main.cpp.obj               |   77390(+77390) |   108(+108) | 27378(+27378) |
+| Subtotals                  | 390692(+390692) | 4424(+4424) | 78616(+78616) |
+Total Static RAM memory (data + bss): 83040(+83040) bytes
+Total Flash memory (text + data): 395116(+395116) bytes
 
Flash used: 435376 (20%) / total: 2097152
SRAM used: 83368 (15%) / total: 524288

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

File comparision analysis report

🔖 Info

Target Flash Used (base/head) Fash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 183068 (69%) ø 79076 (30%)
79076 (30%)
41664 (7%) ø
os 495884 (31%)
496412 (31%)
📈
+528 (+0%)
1068788 (68%)
1068260 (68%)
94328 (17%)
94584 (18%)
📈
+256 (+0%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 495884 (23%)
496412 (23%)
📈
+528 (+0%)
94328 (17%)
94584 (18%)
📈
+256 (+0%)
bootloader ✔️ 183068 (8%) ø 41664 (7%) ø
functional_ut_boost_ut ✔️ 409276 (19%) ø 30608 (5%) ø
functional_ut_core_imu ✔️ 389476 (18%) ø 30584 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ 368332 (17%) ø 30560 (5%) ø
functional_ut_deep_sleep_core_motor ✔️ 376140 (17%) ø 30632 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ 378356 (18%) ø 30632 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ 365268 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ 366712 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ 386812 (18%) ø 30856 (5%) ø
functional_ut_firmware_kit ✔️ 378420 (18%) ø 30840 (5%) ø
functional_ut_imu_kit ✔️ 391668 (18%) ø 30576 (5%) ø
functional_ut_io_expander ✔️ 371176 (17%) ø 30576 (5%) ø
functional_ut_qdac ✔️ 372344 (17%) ø 30576 (5%) ø
spike_lk_accel_gyro ✔️ 94264 (4%) ø 22560 (4%) ø
spike_lk_audio ✔️ 137172 (6%) ø 25176 (4%) ø
spike_lk_behavior_kit ✔️ 198204 (9%) ø 58656 (11%) ø
spike_lk_ble ✔️ 237980 (11%) ø 39416 (7%) ø
spike_lk_bluetooth ✔️ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ 153672 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ 88544 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ 219788 (10%) ø 63112 (12%) ø
spike_lk_config_kit ✔️ 139228 (6%) ø 25192 (4%) ø
spike_lk_coreled ✔️ 88108 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ 93164 (4%) ø 22824 (4%) ø
spike_lk_event_queue ✔️ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ 154432 (7%) ø 25520 (4%) ø
spike_lk_file_reception ✔️ 339964 (16%) ø 38448 (7%) ø
spike_lk_flash_memory ✔️ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ 174568 (8%) ø 47992 (9%) ø
spike_lk_imu_kit ✔️ 98144 (4%) ø 22888 (4%) ø
spike_lk_lcd ✔️ 172716 (8%) ø 57496 (10%) ø
spike_lk_led_kit ✔️ 115204 (5%) ø 25104 (4%) ø
spike_lk_log_kit ✔️ 84776 (4%) ø 23408 (4%) ø
spike_lk_motion_kit ✔️ 107144 (5%) ø 24840 (4%) ø
spike_lk_motors ✔️ 86336 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ 91796 (4%) ø 22768 (4%) ø
spike_lk_reinforcer ✔️ 215324 (10%) ø 59784 (11%) ø
spike_lk_rfid ✔️ 84216 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ 87376 (4%) ø 23312 (4%) ø
spike_lk_sensors_light ✔️ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ 90616 (4%) ø 22192 (4%) ø
spike_lk_serial_number ✔️ 145028 (6%) ø 25256 (4%) ø
spike_lk_ticker_timeout ✔️ 82712 (3%) ø 22232 (4%) ø
spike_lk_touch_sensor_kit ✔️ 96668 (4%) ø 23392 (4%) ø
spike_lk_update_process_app_base ✔️ 157244 (7%) ø 26288 (5%) ø
spike_lk_update_process_app_update ✔️ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ 87520 (4%) ø 24136 (4%) ø
spike_lk_wifi ✔️ 130984 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2023-01-31 00:11:44.227115303 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2023-01-31 00:11:44.699117302 +0000
@@ -1,53 +1,53 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       626(+626) |     18(+18) |     267(+267) |
+| [fill]                     |       630(+630) |     18(+18) |     267(+267) |
 | [lib]/ActivityKit.a        |   10590(+10590) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1476(+1476) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1652(+1652) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       544(+544) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     5018(+5018) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       580(+580) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1756(+1756) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |     1006(+1006) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |     1416(+1416) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       838(+838) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         82(+82) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       806(+806) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     2092(+2092) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 181458(+181458) |   773(+773) | 19755(+19755) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10716(+10716) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               | 137186(+137186) |   108(+108) | 38229(+38229) |
-| Subtotals                  | 450660(+450660) | 4424(+4424) | 89576(+89576) |
-Total Static RAM memory (data + bss): 94000(+94000) bytes
-Total Flash memory (text + data): 455084(+455084) bytes
+| main.cpp.obj               | 137630(+137630) |   108(+108) | 38485(+38485) |
+| Subtotals                  | 451108(+451108) | 4424(+4424) | 89832(+89832) |
+Total Static RAM memory (data + bss): 94256(+94256) bytes
+Total Flash memory (text + data): 455532(+455532) bytes
 
Flash used: 496412 (23%) / total: 2097152
SRAM used: 94584 (18%) / total: 524288

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #1273 (de65ae2) into develop (b397f86) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1273      +/-   ##
===========================================
+ Coverage    98.20%   98.21%   +0.01%     
===========================================
  Files          150      151       +1     
  Lines         3727     3749      +22     
===========================================
+ Hits          3660     3682      +22     
  Misses          67       67              
Impacted Files Coverage Δ
libs/BLEKit/include/BLEServiceMagicCard.h 100.00% <100.00%> (ø)
libs/RobotKit/include/RobotController.h 94.68% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YannLocatelli YannLocatelli force-pushed the yann/feature/get-magic-card-via-ble branch 3 times, most recently from 9d60ab5 to 7391970 Compare January 27, 2023 11:04
@YannLocatelli YannLocatelli marked this pull request as ready for review January 27, 2023 11:16
@YannLocatelli YannLocatelli force-pushed the yann/feature/get-magic-card-via-ble branch from 7391970 to 0fc671a Compare January 27, 2023 11:17
Copy link
Contributor

@HPezz HPezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • Validated on robot

@YannLocatelli YannLocatelli force-pushed the yann/feature/get-magic-card-via-ble branch from 0fc671a to de65ae2 Compare January 30, 2023 23:43
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ladislas ladislas force-pushed the yann/feature/get-magic-card-via-ble branch from de65ae2 to 1f366b4 Compare January 31, 2023 12:11
@ladislas ladislas merged commit 029f724 into develop Jan 31, 2023
@ladislas ladislas deleted the yann/feature/get-magic-card-via-ble branch January 31, 2023 12:11
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants