Feature - Images & animations #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladislas
force-pushed
the
feature/images_and_animations
branch
2 times, most recently
from
d95757b
to
be9053d
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
ladislas
force-pushed
the
feature/images_and_animations
branch
from
4ac4bb8
to
179af94
Compare
ladislas
force-pushed
the
feature/images_and_animations
branch
from
500d1b2
to
f628ba8
Compare
ladislas
force-pushed
the
feature/images_and_animations
branch
from
f628ba8
to
3259ce0
Compare
YannLocatelli
force-pushed
the
feature/images_and_animations
branch
from
8bd9d67
to
73bf058
Compare
ladislas
force-pushed
the
feature/images_and_animations
branch
from
3d69e3d
to
ef5d245
Compare
ladislas
force-pushed
the
feature/images_and_animations
branch
from
64f0cc2
to
9926d88
Compare
ladislas
force-pushed
the
feature/images_and_animations
branch
from
7230cfc
to
2451506
Compare
| uint32_t DataCount, uint32_t *ConvertedDataCount) | ||
| { | ||
| uint32_t numberMCU; | ||
| uint32_t i, j, currentMCU, xRef, yRef; |
There was a problem hiding this comment.
The scope of the variable yRef can be reduced.
| uint32_t numberMCU; | ||
| uint32_t i, j, currentMCU, xRef, yRef; | ||
|
|
||
| uint32_t refline; |
There was a problem hiding this comment.
The scope of the variable refline can be reduced.
|
|
||
| int32_t c_red, c_blue, c_green; | ||
|
|
||
| uint8_t *pOutAddr, *pChrom; |
There was a problem hiding this comment.
The scope of the variable pChrom can be reduced.
| */ | ||
| void JPEG_InitPostProcColorTables(void) | ||
| { | ||
| int32_t index, i; |
There was a problem hiding this comment.
The scope of the variable index can be reduced.
|
|
||
| for (i = 0; i <= 255; i++) { | ||
| index = (i * 2) - 256; | ||
| CR_RED_LUT[i] = ((((int32_t)((1.40200 / 2) * (1L << 16))) * index) + ((int32_t)1 << (16 - 1))) >> 16; |
There was a problem hiding this comment.
Shifting a negative value is technically undefined behaviour
| index = (i * 2) - 256; | ||
| CR_RED_LUT[i] = ((((int32_t)((1.40200 / 2) * (1L << 16))) * index) + ((int32_t)1 << (16 - 1))) >> 16; | ||
|
|
||
| CB_BLUE_LUT[i] = ((((int32_t)((1.77200 / 2) * (1L << 16))) * index) + ((int32_t)1 << (16 - 1))) >> 16; |
There was a problem hiding this comment.
Shifting a negative value is technically undefined behaviour
Codecov Report
@@ Coverage Diff @@
## develop #140 +/- ##
===========================================
- Coverage 100.00% 99.76% -0.24%
===========================================
Files 18 61 +43
Lines 232 1677 +1445
===========================================
+ Hits 232 1673 +1441
- Misses 0 4 +4
Continue to review full report at Codecov.
|
Co-authored-by: Ladislas de Toldi <ladislas@detoldi.me>
+ Homogenize the same type in arguments Co-authored-by: Ladislas de Toldi <ladislas@detoldi.me>
Co-authored-by: Ladislas de Toldi <ladislas@detoldi.me>
Add intermediate method
ladislas
force-pushed
the
feature/images_and_animations
branch
from
6253de2
to
29ef108
Compare
🩹 (otm8009a): Use std::byte for bitwise operation 🩹 (jpeg): Remove redundant cast 🩹 (dma2d): Fix implicit conversion loses 🩹 (jpeg): Add tests recommanded by sonarcloud 🩹 (hal): Remove unused acces specifier 🩹 (hal): Use =default as default implementation 🩹 const non-mutable member function 🩹 (ll): Remove unused namespace 🩹 (dsi): Avoid implicit conversion 🩹 (lcd) Add missing final keyword 🩹 (font): Add const in fontGetPixelBytes argument 🩹 (otm8009a): Replace "/*" by "//" 🩹 (otm8009a): Nested namespace 🩹 (sonarcloud): Fix implicit conversion loses integer precision https://sonarcloud.io/project/issues?id=leka_LekaOS&issues=AXiE6yzYQJJ2tBYqGH4h&open=AXiE6yzYQJJ2tBYqGH4h&pullRequest=140 🩹 (sonarcloud): Fix Use "=default" instead of the default implementation of this special member functions https://sonarcloud.io/project/issues?id=leka_LekaOS&issues=AXiE6y3oQJJ2tBYqGH5j&open=AXiE6y3oQJJ2tBYqGH5j&pullRequest=140 🩹 (sonarcloud): Fix Add the "explicit" keyword to this constructor 🩹 (sonarcloud): Explicitly use reinterpret_cast instead of C-style cast 🩹 (sonarcloud): Fix Merge this "if" statement with the enclosing one https://sonarcloud.io/project/issues?id=leka_LekaOS&issues=AXiE6ywSQJJ2tBYqGH2k&open=AXiE6ywSQJJ2tBYqGH2k&pullRequest=140 🩹 (sonarcloud): Fix field '_dsi' will be initialized after field '_backlight' 🩹 (sonarcloud): Define command array as const 🩹 (sonarcloud): Fix duplicated blocks of code must be removed 🩹 (sonarcloud): Fix Concatenate this namespace with the nested one 🩹 (sonarcloud): Fix Remove the misleading "/*" characters 🩹 (sonarcloud): Fix Rename this namespace to match the regular expression
ladislas
force-pushed
the
feature/images_and_animations
branch
from
23464b6
to
3acb567
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR to bring LKCoreVideo, LKCoreAudio and LKAVKit to LekaOS