Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout Ninja a install.md #165

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

Kabroc
Copy link
Contributor

@Kabroc Kabroc commented Mar 2, 2021

Ajout de l'installation de Ninja dans le INSTALL.md dans LekaOS/docs.

@Kabroc Kabroc added the 01 - type: task Something to do label Mar 2, 2021
@Kabroc Kabroc requested a review from ladislas March 2, 2021 10:18
@Kabroc Kabroc self-assigned this Mar 2, 2021
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci pour la PR! je te propose qu'on ouvre à plus que Ninja.

j'ai rajouté pour les deps, mais on peut aussi mettre pour gcc, comme on avait eu du mal, ça permettra de s'en souvenir.

docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nouvelle review :)

docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated
Comment on lines 164 to 165
- OpenOCD : [Github Openocd](https://github.com/ntfreak/openocd)
- STlink : [Github Stlink](https://github.com/stlink-org/stlink)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peut être rajouter après comment on les installe aussi si besoin.

Suggested change
- OpenOCD : [Github Openocd](https://github.com/ntfreak/openocd)
- STlink : [Github Stlink](https://github.com/stlink-org/stlink)
- OpenOCD - [Github Openocd](https://github.com/ntfreak/openocd)
- STlink - [Github Stlink](https://github.com/stlink-org/stlink)

docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated
Comment on lines 91 to 110
#### For Windows

You can download the toolchain here:

> <https://developer.arm.com/tools-and-software/open-source-software/developer-tools/gnu-toolchain/gnu-rm/downloads>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu peux supprimer windows, on va ps s'embêter.

docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
@ladislas ladislas force-pushed the benjamin/doc/Adding_ninja_to_install.md branch from ac12eb0 to 12dcee0 Compare March 17, 2021 15:06
docs/INSTALL.md Outdated Show resolved Hide resolved
docs/INSTALL.md Show resolved Hide resolved
docs/INSTALL.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #165 (29dc99c) into develop (5b5d875) will not change coverage.
The diff coverage is n/a.

❗ Current head 29dc99c differs from pull request most recent head 50b65dc. Consider uploading reports for the commit 50b65dc to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #165   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          215       215           
=========================================
  Hits           215       215           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5d875...50b65dc. Read the comment docs.

@ladislas ladislas force-pushed the benjamin/doc/Adding_ninja_to_install.md branch from 12dcee0 to 29dc99c Compare March 17, 2021 15:15
@codeclimate
Copy link

codeclimate bot commented Mar 17, 2021

Code Climate has analyzed commit 29dc99c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@ladislas ladislas force-pushed the benjamin/doc/Adding_ninja_to_install.md branch from 29dc99c to 50b65dc Compare March 17, 2021 15:33
@ladislas ladislas merged commit 8b86bda into develop Mar 17, 2021
@ladislas ladislas deleted the benjamin/doc/Adding_ninja_to_install.md branch March 19, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants