Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Replace ThisThread stub by the mbed one #180

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

YannLocatelli
Copy link
Member

No description provided.

@codeclimate
Copy link

codeclimate bot commented Mar 16, 2021

Code Climate has analyzed commit 10f6891 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi! ✅

j'avais fait ça à l'origine pour ne garder que ce dont on a besoin dans les stubs de mbed et nous permettre de rajouter de spys si besoin.

mais tu as raison, c'est plus propre de faire comme ça ! et si jamais on a besoin de faire des spys ont remettra chez nous mais on saura pourquoi.

avec les nouvelles versions de mbed faudra voir si le path est toujours le même, j'ai cru comprendre qu'ils étaient en train de tout changer, mais la CI nous le dira :)

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #180 (10f6891) into develop (5e5cfa0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          194       194           
=========================================
  Hits           194       194           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5cfa0...10f6891. Read the comment docs.

@ladislas ladislas merged commit 39d2ab1 into develop Mar 16, 2021
@ladislas ladislas deleted the yann/replace-ThisThread-stub branch March 16, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants