Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(sonarcloud): Fix issues & code smells #209

Merged
merged 14 commits into from
Apr 8, 2021

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Apr 7, 2021

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #209 (ee45d15) into develop (f7a9266) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ee45d15 differs from pull request most recent head a1e8927. Consider uploading reports for the commit a1e8927 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #209   +/-   ##
========================================
  Coverage    99.76%   99.76%           
========================================
  Files           61       61           
  Lines         1677     1677           
========================================
  Hits          1673     1673           
  Misses           4        4           
Impacted Files Coverage Δ
drivers/LKCoreBattery/include/LKCoreBattery.h 100.00% <100.00%> (ø)
...vers/LKCoreLightSensor/include/LKCoreLightSensor.h 100.00% <100.00%> (ø)
...rivers/LKCoreMicrophone/include/LKCoreMicrophone.h 100.00% <100.00%> (ø)
libs/LKUtils/include/LKUtils.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7a9266...a1e8927. Read the comment docs.

@ladislas ladislas force-pushed the ladislas/bugfix/sonarcloud-bugs branch from 68cd95f to 2a0bcc2 Compare April 7, 2021 14:18
@ladislas ladislas force-pushed the ladislas/bugfix/sonarcloud-bugs branch from 2a0bcc2 to e3d2686 Compare April 7, 2021 14:53
@ladislas ladislas force-pushed the ladislas/bugfix/sonarcloud-bugs branch from 53d0221 to 338ecc0 Compare April 7, 2021 20:12
@ladislas ladislas force-pushed the ladislas/bugfix/sonarcloud-bugs branch from b20dded to fa9358d Compare April 7, 2021 21:08
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2021

Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testé sur le robot

-[x] motors_test_reduction_and_wheels → ✅
-[x] emc_ble_bt_lcd_led_motors / BLE → ✅
-[x] emc_ble_bt_lcd_led_motors / LEDs → ❌
-[x] spike lk_led / LEDs → ❌

Pour les LEDs: seules les LEDS {1, 3, 5} s'allument en blanc.
En effectuant un rollback de la for-loop, ça fonctionne à nouveau

@ladislas ladislas force-pushed the ladislas/bugfix/sonarcloud-bugs branch from ee45d15 to a1e8927 Compare April 8, 2021 13:06
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2021

@ladislas ladislas merged commit cc7d6c4 into develop Apr 8, 2021
@ladislas ladislas deleted the ladislas/bugfix/sonarcloud-bugs branch April 8, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants