-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LKCoreI2C #220
Add LKCoreI2C #220
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #220 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 665 659 -6
=========================================
- Hits 665 659 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c'est bien ! 👍
on est presque au bout, il y a quelques changements de fond et de forme + quelques questions techniques.
Prends bien le temps de tout lire en détails, j'ai mis les suggestions. Prends du recul par rapport à tout ça.
bf2682b
to
062f3b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nouvelle review --
il y a quelques trucs étonnants, en particulier dans spy_temperatureSensor_setValueBeforeRead
pourras tu m'expliquer dans slack?
c6296de
to
2e48c67
Compare
2e48c67
to
aa2d390
Compare
aa2d390
to
1e57a57
Compare
Code Climate has analyzed commit 1e57a57 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! |
Implementation and test of LKCoreI2C driver.