Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LKCoreI2C #220

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Add LKCoreI2C #220

merged 3 commits into from
Apr 20, 2021

Conversation

Kabroc
Copy link
Contributor

@Kabroc Kabroc commented Apr 19, 2021

Implementation and test of LKCoreI2C driver.

@Kabroc Kabroc added the 01 - type: task Something to do label Apr 19, 2021
@Kabroc Kabroc self-assigned this Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #220 (c6296de) into develop (f70dbab) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c6296de differs from pull request most recent head 1e57a57. Consider uploading reports for the commit 1e57a57 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #220   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines          665       659    -6     
=========================================
- Hits           665       659    -6     
Impacted Files Coverage Δ
drivers/LKCoreI2C/include/LKCoreI2C.h 100.00% <100.00%> (ø)
drivers/LKCoreI2C/source/LKCoreI2C.cpp 100.00% <100.00%> (ø)
libs/LKAnimationKit/source/LKAnimationKit.cpp
libs/LKAnimationKit/include/internal/CGAnimation.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f70dbab...1e57a57. Read the comment docs.

Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est bien ! 👍

on est presque au bout, il y a quelques changements de fond et de forme + quelques questions techniques.

Prends bien le temps de tout lire en détails, j'ai mis les suggestions. Prends du recul par rapport à tout ça.

drivers/CMakeLists.txt Outdated Show resolved Hide resolved
drivers/LKCoreI2C/include/LKCoreI2C.h Outdated Show resolved Hide resolved
drivers/LKCoreI2C/include/LKCoreI2C.h Outdated Show resolved Hide resolved
drivers/LKCoreI2C/include/LKCoreI2C.h Outdated Show resolved Hide resolved
drivers/LKCoreI2C/tests/LKCoreI2C_test.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.h Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.h Outdated Show resolved Hide resolved
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nouvelle review --

il y a quelques trucs étonnants, en particulier dans spy_temperatureSensor_setValueBeforeRead pourras tu m'expliquer dans slack?

drivers/LKCoreI2C/tests/LKCoreI2C_test.cpp Outdated Show resolved Hide resolved
drivers/LKCoreI2C/tests/LKCoreI2C_test.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.h Outdated Show resolved Hide resolved
drivers/LKCoreI2C/tests/LKCoreI2C_test.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.cpp Outdated Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.cpp Show resolved Hide resolved
tests/unit/mbed-os/stubs/stub_I2C.cpp Outdated Show resolved Hide resolved
@Kabroc Kabroc force-pushed the benjamin/feature/driver_i2c branch from c6296de to 2e48c67 Compare April 20, 2021 12:08
@ladislas ladislas force-pushed the benjamin/feature/driver_i2c branch from 2e48c67 to aa2d390 Compare April 20, 2021 12:38
@ladislas ladislas force-pushed the benjamin/feature/driver_i2c branch from aa2d390 to 1e57a57 Compare April 20, 2021 12:41
@codeclimate
Copy link

codeclimate bot commented Apr 20, 2021

Code Climate has analyzed commit 1e57a57 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit 2b4302f into develop Apr 20, 2021
@ladislas ladislas deleted the benjamin/feature/driver_i2c branch April 22, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants