Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ladislas/feature/mock mbed digitalout #264

Merged
merged 2 commits into from
May 31, 2021

Conversation

ladislas
Copy link
Member

  • 🔧 (mbed): Add EXPERIMENTAL_API to target's features
  • 🤡 (mbed): Mock mbed::interface::DigitalOut

@ladislas ladislas force-pushed the ladislas/feature/mock-mbed-digitalout branch from e6c848c to eaaab27 Compare May 31, 2021 09:50
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #264 (395a1b9) into develop (4552ace) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines          940       940           
=========================================
  Hits           940       940           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4552ace...395a1b9. Read the comment docs.

Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi
Attention toutefois, ça ne fonctionnera que avec mbed-os 6.11 et ultérieur !

tests/unit/mbed-os/mocks/mock_DigitalOut.h Outdated Show resolved Hide resolved

#include "PinNames.h"

#include "drivers/interfaces/InterfaceDigitalOut.h"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbed-os en 6.11, sinon l'erreur suivante survient:

fatal error: 'drivers/interfaces/InterfaceDigitalOut.h' file not found
#include "drivers/interfaces/InterfaceDigitalOut.h"

@ladislas ladislas force-pushed the ladislas/feature/mock-mbed-digitalout branch 2 times, most recently from 6d628ad to c3de701 Compare May 31, 2021 13:48
This is necessary to use the DigitalIn interface
To work we need to also stub mbed::gpio_read and mbed::gpio_is_connected
@ladislas ladislas force-pushed the ladislas/feature/mock-mbed-digitalout branch from c3de701 to 395a1b9 Compare May 31, 2021 14:24
@codeclimate
Copy link

codeclimate bot commented May 31, 2021

Code Climate has analyzed commit 395a1b9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ladislas ladislas merged commit 833b0e3 into develop May 31, 2021
@ladislas ladislas deleted the ladislas/feature/mock-mbed-digitalout branch June 3, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants