Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ladislas/feature/move array utils to cxxsupport #267

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Jun 2, 2021

  • 🔧 (vscode): Configure language association for lstd_* & mstd_* files
  • ✨ (cxxsupport): Add cxxsupport directory with lstd_array header
  • ✅ (cxxsupport): Add include/cxxsupport lstd_array related unit tests
  • 🔥 (utils): Remove ArrayUtils

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #267 (8e7a0e3) into develop (6e1bdc0) will not change coverage.
The diff coverage is n/a.

❗ Current head 8e7a0e3 differs from pull request most recent head af7f49a. Consider uploading reports for the commit af7f49a to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        55    -1     
  Lines          940       936    -4     
=========================================
- Hits           940       936    -4     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1bdc0...af7f49a. Read the comment docs.

@ladislas ladislas force-pushed the ladislas/feature/move-array-utils-to-cxxsupport branch 2 times, most recently from 51b91f6 to 05b0991 Compare June 3, 2021 07:42
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a effectivement l'histoire de ces tests qui n'a pas forcément sa place dans l'include, sinon tout est bon pour moi

include/CMakeLists.txt Outdated Show resolved Hide resolved
@ladislas ladislas force-pushed the ladislas/feature/move-array-utils-to-cxxsupport branch 2 times, most recently from 8e7a0e3 to b471ded Compare June 3, 2021 10:32
The cxxsupport directory is intended for implementing C++ features not
yet available in C++17 (std version used at the time of writting)

The first header is <lstd_array> which mimics <array> and adds
the (l)std::to_array function from C++20
It is replaced by cxxsupport/lstd_array
@ladislas ladislas force-pushed the ladislas/feature/move-array-utils-to-cxxsupport branch from b471ded to af7f49a Compare June 3, 2021 10:35
@codeclimate
Copy link

codeclimate bot commented Jun 3, 2021

Code Climate has analyzed commit af7f49a and detected 0 issues on this pull request.

View more on Code Climate.

@ladislas ladislas merged commit 5a7fe30 into develop Jun 3, 2021
@ladislas ladislas deleted the ladislas/feature/move-array-utils-to-cxxsupport branch June 3, 2021 10:36
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants